From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 67417-done@debbugs.gnu.org, arteen@linux.ucla.edu
Subject: bug#67417: 29.1.50; c-ts-mode syntax issues with no brackets
Date: Mon, 11 Dec 2023 02:29:47 +0200 [thread overview]
Message-ID: <d3312339-85bc-af84-c2cd-e93934a34a95@gutov.dev> (raw)
In-Reply-To: <b41d7f08-10fb-4f70-8fb7-4a5d9294301b@gmail.com>
Version: 29.2
On 10/12/2023 11:29, Yuan Fu wrote:
>
>
> On 12/9/23 12:27 AM, Eli Zaretskii wrote:
>>> Date: Thu, 30 Nov 2023 23:58:14 -0800
>>> Cc: 67417@debbugs.gnu.org
>>> From: Yuan Fu <casouri@gmail.com>
>>>
>>>> The rest of the nodes (if/while/do/for) don't result in parse errors
>>>> here, as long as the condition in parentheses is typed out correctly.
>>>>
>>>> I tried some additional clauses looking for "previous sibling",
>>>> checking whether it's for_statement, etc, which ends with "expression
>>>> statement", and that one is empty... but it a fair amount of code
>>>> which will likely miss other edge cases anyway. Or breaks when the
>>>> grammar changes.
>>> Yeah, for now we can match for the specific case where there's an else
>>> before a "}". That should reduce the chance of it matching other edge
>>> cases. I'll give it another look on this weekend.
>> Any progress here?
> I pushed a commit that changes the too-board heuristic to only match
> "else before closing bracket". Hopefully this won't cause any false
> matches.
>
> I think we can close this. Dmitry, WDYT?
LGTM! (And closing.)
Arteen, let us know if you see any problems with the fixes that are now
in the emacs-29 branch.
prev parent reply other threads:[~2023-12-11 0:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 20:55 bug#67417: 29.1.50; c-ts-mode syntax issues with no brackets Arteen Abrishami via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24 7:23 ` Eli Zaretskii
2023-11-24 18:26 ` Dmitry Gutov
2023-11-27 1:47 ` Yuan Fu
2023-11-27 2:22 ` Dmitry Gutov
2023-11-28 6:55 ` Yuan Fu
2023-11-28 14:27 ` Eli Zaretskii
2023-11-28 15:31 ` Dmitry Gutov
2023-12-01 7:58 ` Yuan Fu
2023-12-09 8:27 ` Eli Zaretskii
2023-12-10 9:29 ` Yuan Fu
2023-12-11 0:29 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3312339-85bc-af84-c2cd-e93934a34a95@gutov.dev \
--to=dmitry@gutov.dev \
--cc=67417-done@debbugs.gnu.org \
--cc=arteen@linux.ucla.edu \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).