unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Pankaj Jangid <pankaj@codeisgreat.org>, 43715@debbugs.gnu.org
Subject: bug#43715: 28.0.50; Duplicate results in project-find-regexp
Date: Thu, 1 Oct 2020 23:38:01 +0300	[thread overview]
Message-ID: <d2eb589f-ae7b-7498-9bdb-b9d37be0fc8b@yandex.ru> (raw)
In-Reply-To: <87lfgqwxtf.fsf@gnus.org>

On 01.10.2020 04:15, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
> 
>> The behavior is less than ideal, but the fix will have to satisfy
>> multiple constraints: the xref item creation (taking care of the
>> format being backward-compatible), the rendering of them in the
>> buffer, and the 'xref-query-replace-in-results' command, the
>> implementation of which relies on the one-line-per-match property of
>> an xref buffer.
> 
> Right.  I know next to nothing about xref internals...  but...  couldn't
> this function just squash the multiple-matches-on-a-single-line into one
> line?  Preserving the text props from the multiple lines and whatnot?
> So a post-processing step?

Which function?

xref-query-replace-in-results works on an existing xref buffer. And it 
uses the position of point (at the beginning of line) as both user 
indicator and to persist the state of the replacement process.

Going back to xref buffers, if two matches are rendered on one line, 
that leads to a question of how 'n' and 'p' should behave (whether they 
would also jump between the matches on the same line).





  reply	other threads:[~2020-10-01 20:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  7:01 bug#43715: 28.0.50; Duplicate results in project-find-regexp Pankaj Jangid
2020-09-30 13:59 ` Lars Ingebrigtsen
2020-09-30 19:25   ` Juri Linkov
2020-09-30 22:52   ` Dmitry Gutov
2020-10-01  1:15     ` Lars Ingebrigtsen
2020-10-01 20:38       ` Dmitry Gutov [this message]
2020-10-01 20:39         ` Lars Ingebrigtsen
2020-10-01 21:28           ` Dmitry Gutov
2020-10-01 21:30             ` Dmitry Gutov
2020-10-01 21:38             ` Lars Ingebrigtsen
2020-10-01 21:45               ` Dmitry Gutov
2020-10-02  6:37                 ` Eli Zaretskii
2020-10-02  8:52                   ` Dmitry Gutov
2020-10-02  9:18                     ` Eli Zaretskii
2020-10-02  9:52                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2eb589f-ae7b-7498-9bdb-b9d37be0fc8b@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=43715@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=pankaj@codeisgreat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).