From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23356: [PATCH] Cache results of `css--property-values' Date: Sun, 24 Apr 2016 16:00:01 +0300 Message-ID: References: <1461501890.5416.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1461502889 23888 80.91.229.3 (24 Apr 2016 13:01:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 13:01:29 +0000 (UTC) To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , 23356@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 24 15:01:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auJf3-0000qf-P6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 15:01:18 +0200 Original-Received: from localhost ([::1]:55311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJf2-0002Sc-2a for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 09:01:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJev-0002NH-Af for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 09:01:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJeo-0005np-O4 for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 09:01:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJeo-0005nl-KK for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 09:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1auJeo-0000mN-Dx for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 09:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2016 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23356-submit@debbugs.gnu.org id=B23356.14615028112929 (code B ref 23356); Sun, 24 Apr 2016 13:01:02 +0000 Original-Received: (at 23356) by debbugs.gnu.org; 24 Apr 2016 13:00:11 +0000 Original-Received: from localhost ([127.0.0.1]:44606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJdz-0000lB-9q for submit@debbugs.gnu.org; Sun, 24 Apr 2016 09:00:11 -0400 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:34230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJdx-0000kC-Ap for 23356@debbugs.gnu.org; Sun, 24 Apr 2016 09:00:09 -0400 Original-Received: by mail-wm0-f66.google.com with SMTP id n3so17624330wmn.1 for <23356@debbugs.gnu.org>; Sun, 24 Apr 2016 06:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2KnqWBaw5lsiEccin8G+8VVD/XS5sztmPCxKFLUcWwQ=; b=oD8V725EsV15PvVZ3IVRBy4UPPTItig6kAb6ii3/QE447VkdCV9FblDAQOpC+/Dbgn CYkzyd3B8aEVVazMNoaWDrn7/ZxsYV7cL03lchYxmy5SflvLaSsIeVEaQyyLM2R0eqRs uB872B19GF42vL2GnPlwifUIxOFwmdlifqaZ3JhyOF20j4lXGjORwGdqH/T/CWZeLPLC Csc74gJCNX9Xt+Uk4l8qIbmp5vOP+vkQwOTjxrh+IDU9Rj25Inj2tt1mGxzLKSM53yLH mfUd5fGjw4E7TWG9E3EhNTSc7D6Yfk1opPEA4SnJq6fc0PtBB0JLhtAxxPFyVZrN5TRs yibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2KnqWBaw5lsiEccin8G+8VVD/XS5sztmPCxKFLUcWwQ=; b=HKf2uRSD9/FW6QnWaZZc/HZfTLCex8bdEF0knvhGR/NNN9/TgiOkSyQMSWDuOXuM81 z3dISjjuV6WP1cghvrtd/QnqsOHrjmIsjWEygFmgksNnF4UfcO9uF19ASvWNJGnEpMAE mJdrPLNoRPbu+GIm7LQjyN9b1h7ASYbEmlA/BvWRNrhbWtYso1QuPy4ubDZZQ1cJc1YG S3sY5aUI5HZqdvVfrOHnJIYvjhAtIrQBOzBCSOMOGIM/FtiyB+nJgS/dzkU1YM2laVMp sxhPP1qK8hmvNUODDNQePz1z79Yew9YKZROh5Gv+xBhsl6opB8sc5Iy8ZV084QROhQQR EX8A== X-Gm-Message-State: AOPr4FV6+I/98JyahUraMwZ+HnJoJVP02gEEjYbYxGnXkJX7OzWCOi7UjR6m5Hu16CoCYQ== X-Received: by 10.194.231.104 with SMTP id tf8mr28893554wjc.5.1461502803131; Sun, 24 Apr 2016 06:00:03 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id r75sm12944464wme.18.2016.04.24.06.00.02 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 06:00:02 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <1461501890.5416.0@smtp.gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116748 Archived-At: On 04/24/2016 03:44 PM, Simen Heggestøyl wrote: > During one of the iterations for 269d5631 (Support completion of > attribute values in CSS mode), the code that actually updates the > `css--property-value-cache' cache in `css--property-values' got lost. > The attached patch reintroduces it along with a regression test. LGTM. You should be able to push this kind of changes without going through review anyway.