From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#8927: 24.0.50; Flaw in C-x v u Date: Fri, 24 Jun 2011 16:59:29 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1308949241 17876 80.91.229.12 (24 Jun 2011 21:00:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2011 21:00:41 +0000 (UTC) Cc: 8927@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 24 23:00:33 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QaDUO-0003sz-T6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Jun 2011 23:00:33 +0200 Original-Received: from localhost ([::1]:36891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaDUN-0007Eg-E8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Jun 2011 17:00:31 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaDTy-0007CW-R1 for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 17:00:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaDTx-00017C-3Q for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 17:00:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaDTw-00016k-Nt for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2011 17:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QaDTv-0003rT-Ad; Fri, 24 Jun 2011 17:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2011 21:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8927 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8927-submit@debbugs.gnu.org id=B8927.130894917814766 (code B ref 8927); Fri, 24 Jun 2011 21:00:03 +0000 Original-Received: (at 8927) by debbugs.gnu.org; 24 Jun 2011 20:59:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaDTW-0003q7-18 for submit@debbugs.gnu.org; Fri, 24 Jun 2011 16:59:38 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QaDTU-0003px-DX for 8927@debbugs.gnu.org; Fri, 24 Jun 2011 16:59:36 -0400 Original-Received: from localhost ([127.0.0.1]:58134) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaDTO-00021p-3A; Fri, 24 Jun 2011 16:59:30 -0400 X-Spook: SP4 Agfa EuroFed Croatian bluebird mania Indigo ASIO X-Ran: tNCmaX{,w,7()tC.F|_D!?p6qk~D)uJc`YLbzJMV"H7)&k$?2&w,j_7WY9k1A@L(Y (Richard Stallman's message of "Fri, 24 Jun 2011 05:37:28 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 24 Jun 2011 17:00:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47444 Archived-At: Richard Stallman wrote: > I did C-x v = to see the changes in a file, then reverted the file > with C-x v u so I could install and commit those changes one by one. > > Unfortunately, C-x v u deleted the *vc-diff* buffer and made this fail. > > C-x v u should not delete the *vc-diff* buffer. On a related note, it has always annoyed me that vc-revert unconditionally always shows me the diff of the file in question before letting me revert. Basically every time I use vc-revert, I have already checked the diff beforehand, so all this does is introduce an annoying delay when the backend is slow to produce a diff. I'm not aware of a command-line VCS that show you the diff when you run its revert command, so I don't see why Emacs should do so. Anyway, that's why it kills your *vc-diff* buffer - because it assumes it has just created it. The fix for your problem would presumably be for vc-revert to only kill the buffer if it did not exist beforehand. But personally I still wish it would not always insist on showing me the diff.