From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tim Ruffing Newsgroups: gmane.emacs.bugs Subject: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient Date: Fri, 12 Nov 2021 20:44:54 +0100 Message-ID: References: <20201129165641.00308157@ventiloplattform.tastytea.de> <87r1hfs2iw.fsf@gnus.org> <87y29zkh2u.fsf@gnus.org> <8897e49181dca3edec91bb2b08494e7484b88cd0.camel@timruffing.de> <87bl2r8bg7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-31z6Gys/g2gJFmsF01Ug" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3092"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tastytea To: Lars Ingebrigtsen , Eli Zaretskii , 44950@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 12 20:46:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlcVJ-0000cG-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Nov 2021 20:46:30 +0100 Original-Received: from localhost ([::1]:53804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlcVI-0002nW-Nr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Nov 2021 14:46:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlcUt-0002mg-Es for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 14:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlcUs-000142-He for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 14:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlcUs-0003vF-Bp for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 14:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Ruffing Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Nov 2021 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44950-submit@debbugs.gnu.org id=B44950.163674631515000 (code B ref 44950); Fri, 12 Nov 2021 19:46:02 +0000 Original-Received: (at 44950) by debbugs.gnu.org; 12 Nov 2021 19:45:15 +0000 Original-Received: from localhost ([127.0.0.1]:46025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcU6-0003ts-Gn for submit@debbugs.gnu.org; Fri, 12 Nov 2021 14:45:14 -0500 Original-Received: from mout-p-102.mailbox.org ([80.241.56.152]:13100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlcU1-0003tV-Mw for 44950@debbugs.gnu.org; Fri, 12 Nov 2021 14:45:13 -0500 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4HrTZR2Ln2zQjhn; Fri, 12 Nov 2021 20:45:03 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timruffing.de; s=MBO0001; t=1636746299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z1zcw2wAXwYIIMvLHgtGhrd42friSSLwZXkOxM4ubyw=; b=m+arPFx1KHoGkX+18Qy2/5VccYc/FNzOuJ9QBJJVbhjkiKrJz+0+rtNiLSBQpcRFpNIB0T 6hyTSrSfcqAsCfry+7t2WgLrPzXrHKpkPpUkeYA910JHqczYl9wqZMujAtykDUBgxJ4z4E qivi3NbZdAfk3fxbyjInIsU7as7ByQvWjHxBgqQ0BlHb563W5tHHTaEcHhBcr6XI9m6f6+ 885DJLNvh1m5zXngU9M16/8TjSk5H8tqLNAxX2Q+HwhVLcXUyp9BKsP9DAYWR+9JWOczbY Tqj2wksMl1P4fhUqsCLE+t6DnEdvDkfv1nvpLAXAqDKmsQxWLE22aFIVgzOAZQ== In-Reply-To: <87bl2r8bg7.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219790 Archived-At: --=-31z6Gys/g2gJFmsF01Ug Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sorry for committing to send an updating patch but not replying for so long... Good that the broken patch was quickly fixed after it broke colors in the macOS Terminal app. I looked again into the issue. One potential further pitfall is that the Tc logic in tmux, which introduced the Tc flag, is still different from what we do: while Tc is meant to mean "support for the default sequences as in xterm+direct", tmux first relies on the setrgbf/setrgbb escape sequences in the terminfo and only provide the default sequences if setrgbf/setrgbb are not present. I've attached a patch that would introduce full support for setrgbf/setrgbb as previously proposed [2]. Before I propose an update for the efaq.texi, let me know if you're interested in this patch (with a proper commit messagea and NEWS entry) or not. I personally don't care too much. With the Tc fix applied, Emacs works for me, and believe our current code is fine, even though we don't fully replicate tmux's logic respect to Tc. On the other hand, with full support for setrgbf/setrgbb, we'd support pretty much every existing method out there and the diff is not that large. Best, Tim [1] See for example https://github.com/tmux/tmux/commit/7eb496c00c313c2f8ab8debe6d154d5ac0db277b#diff-de4f90e163caf6cc83476898c795355523776a76f9ccc7783e9bd3a99fde671dR526 (this code was replaced later in https://github.com/tmux/tmux/commit/a6129e99749d2bbc8b4a991c7b5d09300aa55f39# but the logic is still the same and the earlier commit is easier to read). Another relevant discussion is https://github.com/tmux/tmux/issues/2418 . [2] https://lists.gnu.org/archive/html/bug-ncurses/2013-10/msg00007.html On Thu, 2021-11-11 at 07:15 +0100, Lars Ingebrigtsen wrote: > Tim Ruffing writes: > > > Hi Lars, not yet. I'm currently on vacation, I'll come back to you in > > about two weeks. > > This was some months ago, so I went ahead and pushed the change to > Emacs > 29. > --=-31z6Gys/g2gJFmsF01Ug Content-Disposition: attachment; filename="0001-Support-setrgbb-setrgbf-for-setting-24-bit-color.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Support-setrgbb-setrgbf-for-setting-24-bit-color.patch"; charset="UTF-8" RnJvbSBjMjk2ZGU1Nzc4ZjA0MGU1ODAzMzI2ZGJiNzRhNzM2MmFjMDE0NmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gUnVmZmluZyA8Y3J5cHRvQHRpbXJ1ZmZpbmcuZGU+CkRh dGU6IEZyaSwgMTIgTm92IDIwMjEgMjA6Mzc6MzkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBTdXBw b3J0IHNldHJnYmIvc2V0cmdiZiBmb3Igc2V0dGluZyAyNC1iaXQgY29sb3IKCi0tLQogc3JjL3Rl cm0uYyAgICAgfCAyOCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCiBzcmMvdGVybWNoYXIu aCB8IDEwICsrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm0uYyBiL3NyYy90ZXJtLmMKaW5kZXgg YjRmM2RmYzI1ZS4uODAyMmNhOTVmMSAxMDA2NDQKLS0tIGEvc3JjL3Rlcm0uYworKysgYi9zcmMv dGVybS5jCkBAIC0xOTQ1LDcgKzE5NDUsMTAgQEAgdHVybl9vbl9mYWNlIChzdHJ1Y3QgZnJhbWUg KmYsIGludCBmYWNlX2lkKQogICAgICAgdHMgPSB0dHktPnN0YW5kb3V0X21vZGUgPyB0dHktPlRT X3NldF9iYWNrZ3JvdW5kIDogdHR5LT5UU19zZXRfZm9yZWdyb3VuZDsKICAgICAgIGlmIChmYWNl X3R0eV9zcGVjaWZpZWRfY29sb3IgKGZnKSAmJiB0cykKIAl7Ci0gICAgICAgICAgcCA9IHRwYXJh bSAodHMsIE5VTEwsIDAsIGZnLCAwLCAwLCAwKTsKKwkgIGlmICh0dHktPlRGX3JnYl9zZXBhcmF0 ZSkKKwkgICAgcCA9IHRwYXJhbSAodHMsIE5VTEwsIDAsIGZnID4+IDE2LCAoZmcgPj4gOCkgJiAw eEZGLCBmZyAmIDB4RkYsIDApOworCSAgZWxzZQorCSAgICBwID0gdHBhcmFtICh0cywgTlVMTCwg MCwgZmcsIDAsIDAsIDApOwogCSAgT1VUUFVUICh0dHksIHApOwogCSAgeGZyZWUgKHApOwogCX0K QEAgLTE5NTMsNyArMTk1NiwxMCBAQCB0dXJuX29uX2ZhY2UgKHN0cnVjdCBmcmFtZSAqZiwgaW50 IGZhY2VfaWQpCiAgICAgICB0cyA9IHR0eS0+c3RhbmRvdXRfbW9kZSA/IHR0eS0+VFNfc2V0X2Zv cmVncm91bmQgOiB0dHktPlRTX3NldF9iYWNrZ3JvdW5kOwogICAgICAgaWYgKGZhY2VfdHR5X3Nw ZWNpZmllZF9jb2xvciAoYmcpICYmIHRzKQogCXsKLSAgICAgICAgICBwID0gdHBhcmFtICh0cywg TlVMTCwgMCwgYmcsIDAsIDAsIDApOworCSAgaWYgKHR0eS0+VEZfcmdiX3NlcGFyYXRlKQorCSAg ICBwID0gdHBhcmFtICh0cywgTlVMTCwgMCwgYmcgPj4gMTYsIChiZyA+PiA4KSAmIDB4RkYsIGJn ICYgMHhGRiwgMCk7CisJICBlbHNlCisJICAgIHAgPSB0cGFyYW0gKHRzLCBOVUxMLCAwLCBiZywg MCwgMCwgMCk7CiAJICBPVVRQVVQgKHR0eSwgcCk7CiAJICB4ZnJlZSAocCk7CiAJfQpAQCAtNDEz MywxMCArNDEzOSwxMCBAQCBpbml0X3R0eSAoY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAq dGVybWluYWxfdHlwZSwgYm9vbCBtdXN0X3N1Y2NlZWQpCiAKICNpZmRlZiBURVJNSU5GTwogICAg ICAgewotCWNvbnN0IGNoYXIgKmZnID0gdGlnZXRzdHIgKCJzZXRmMjQiKTsKLQljb25zdCBjaGFy ICpiZyA9IHRpZ2V0c3RyICgic2V0YjI0Iik7Ci0JLyogTm9uLXN0YW5kYXJkIHN1cHBvcnQgZm9y IDI0LWJpdCBjb2xvcnMuICovCi0JaWYgKGZnICYmIGJnCisJY29uc3QgY2hhciAqZmc7CisJY29u c3QgY2hhciAqYmc7CisJLyogT3VyIG93biBub24tc3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0 IGNvbG9ycy4gKi8KKwlpZiAoKGZnID0gdGlnZXRzdHIgKCJzZXRmMjQiKSkgJiYgKGJnID0gdGln ZXRzdHIgKCJzZXRiMjQiKSkKIAkgICAgJiYgZmcgIT0gKGNoYXIgKikgKGludHB0cl90KSAtMQog CSAgICAmJiBiZyAhPSAoY2hhciAqKSAoaW50cHRyX3QpIC0xKQogCSAgewpAQCAtNDE0NCw2ICs0 MTUwLDE2IEBAIGluaXRfdHR5IChjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICp0ZXJtaW5h bF90eXBlLCBib29sIG11c3Rfc3VjY2VlZCkKIAkgICAgdHR5LT5UU19zZXRfYmFja2dyb3VuZCA9 IGJnOwogCSAgICB0dHktPlROX21heF9jb2xvcnMgPSAxNjc3NzIxNjsKIAkgIH0KKwkvKiBPdGhl ciBub24tc3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0IGNvbG9ycy4gKi8KKwllbHNlIGlmICgo ZmcgPSB0aWdldHN0ciAoInNldHJnYmYiKSkgJiYgKGJnID0gdGlnZXRzdHIgKCJzZXRyZ2JiIikp CisJICAgICYmIGZnICE9IChjaGFyICopIChpbnRwdHJfdCkgLTEKKwkgICAgJiYgYmcgIT0gKGNo YXIgKikgKGludHB0cl90KSAtMSkKKwkgIHsKKwkgICAgdHR5LT5UU19zZXRfZm9yZWdyb3VuZCA9 IGZnOworCSAgICB0dHktPlRTX3NldF9iYWNrZ3JvdW5kID0gYmc7CisJICAgIHR0eS0+VE5fbWF4 X2NvbG9ycyA9IDE2Nzc3MjE2OworCSAgICB0dHktPlRGX3JnYl9zZXBhcmF0ZSA9IDE7CisJICB9 CiAJLyogU3RhbmRhcmQgc3VwcG9ydCBmb3IgMjQtYml0IGNvbG9ycy4gICovCiAJZWxzZSBpZiAo dGlnZXRmbGFnICgiUkdCIikgPiAwKQogCSAgewpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm1jaGFyLmgg Yi9zcmMvdGVybWNoYXIuaAppbmRleCA3YWI5MzM3ZmJlLi5kMjY2ZmQxNmY5IDEwMDY0NAotLS0g YS9zcmMvdGVybWNoYXIuaAorKysgYi9zcmMvdGVybWNoYXIuaApAQCAtMTU0LDEwICsxNTQsMTIg QEAgI2RlZmluZSBFTUFDU19URVJNQ0hBUl9ICiAgIC8qICJvcCIgLS0gU1ZyNCBzZXQgZGVmYXVs dCBwYWlyIHRvIGl0cyBvcmlnaW5hbCB2YWx1ZS4gICovCiAgIGNvbnN0IGNoYXIgKlRTX29yaWdf cGFpcjsKIAotICAvKiAiQUYiLyJBQiIgb3IgIlNmIi8iU2IiLS0gc2V0IEFOU0kgb3IgU1ZyNCBm b3JlZ3JvdW5kL2JhY2tncm91bmQgY29sb3IuCi0gICAgIDEgcGFyYW0sIHRoZSBjb2xvciBpbmRl eC4gICovCi0gIGNvbnN0IGNoYXIgKlRTX3NldF9mb3JlZ3JvdW5kOwotICBjb25zdCBjaGFyICpU U19zZXRfYmFja2dyb3VuZDsKKyAgY29uc3QgY2hhciAqVFNfc2V0X2ZvcmVncm91bmQ7IC8qICJB RiIvIlNmIi8ic2V0cmdiZiIgLS0gc2V0IGZvcmVncm91bmQgY29sb3IuICovCisgIGNvbnN0IGNo YXIgKlRTX3NldF9iYWNrZ3JvdW5kOyAvKiAiQUIiLyJTYiIvInNldHJnYmIiIC0tIHNldCBiYWNr Z3JvdW5kIGNvbG9yLiAqLworICAvKiBJZiBzZXQsIFRTX3NldF9mb3JlZ3JvdW5kIGFuZCBUU19z ZXRfYmFja2dyb3VuZCB0YWtlIDMgc2VwYXJhdGUKKyAgICAgcGFyYW1zIGZvciBSLCBHLCBhbmQg QiB2YWx1ZXMgKCJzZXRyZ2JmIi8ic2V0cmdiYiIgLS0gbm9uLXN0YW5kYXJkKS4KKyAgICAgSWYg dW5zZXQsIHRoZXkgdGFrZSAxIHBhcmFtICgiQUYiLyJBQiIgb3IgIlNmIi8iU2IiIC0tIEFOU0kg b3IgU1ZyNHIpLiAqLworICBpbnQgVEZfcmdiX3NlcGFyYXRlOwogCiAgIGludCBURl9oYXplbHRp bmU7ICAgICAgICAgICAgIC8qIHRlcm1jYXAgaHogZmxhZy4gKi8KICAgaW50IFRGX2luc21vZGVf bW90aW9uOyAgICAgICAgLyogdGVybWNhcCBtaSBmbGFnOiBjYW4gbW92ZSB3aGlsZSBpbiBpbnNl cnQgbW9kZS4gKi8KLS0gCjIuMzMuMQoK --=-31z6Gys/g2gJFmsF01Ug--