From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Angelo Graziosi Newsgroups: gmane.emacs.bugs Subject: bug#23510: Strange redisplay in global highlighted mode moving the scroll bar Date: Tue, 17 May 2016 00:28:57 +0200 Message-ID: References: <583a66be-763b-1a75-45be-b892eeacb48e@alice.it> <87shxhbsdu.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1463437824 18343 80.91.229.3 (16 May 2016 22:30:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 May 2016 22:30:24 +0000 (UTC) Cc: 23510@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 17 00:30:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2R1g-0002x3-6S for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 00:30:12 +0200 Original-Received: from localhost ([::1]:47640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2R1f-0002Kb-1h for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 May 2016 18:30:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2R1b-0002By-5w for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 18:30:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2R1W-0000rh-QJ for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 18:30:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2R1W-0000rc-Nv for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 18:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2R1W-0006aE-DE for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Angelo Graziosi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 May 2016 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23510-submit@debbugs.gnu.org id=B23510.146343774925225 (code B ref 23510); Mon, 16 May 2016 22:30:02 +0000 Original-Received: (at 23510) by debbugs.gnu.org; 16 May 2016 22:29:09 +0000 Original-Received: from localhost ([127.0.0.1]:54518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2R0f-0006Yn-0W for submit@debbugs.gnu.org; Mon, 16 May 2016 18:29:09 -0400 Original-Received: from smtp204.alice.it ([82.57.200.100]:33476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2R0b-0006YH-KK for 23510@debbugs.gnu.org; Mon, 16 May 2016 18:29:07 -0400 Original-Received: from [192.168.1.103] (95.246.229.228) by smtp204.alice.it (8.6.060.43) (authenticated as angelo.graziosi@alice.it) id 571880A504B02F50; Tue, 17 May 2016 00:28:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87shxhbsdu.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118334 Archived-At: Stephen, I tried your patch without an init file and calling "M-x hl-line-mode" and then "M-x global-hl-line-mode" and I think I can reproduce all your arguments below. Now my init file contains (setq global-hl-line-sticky-flag t) (global-hl-line-mode 1) so that I can see the line in all windows of the frame. Obviously, no flickering in all case you describe below.. Angelo Il 16/05/2016 23:33, Stephen Berman ha scritto: > On Sat, 14 May 2016 09:42:13 +0200 Angelo Graziosi wrote: > >>> If my fix is found acceptable >> >> I have tested the patch with this init.el file: >> >> ;; >> (global-hl-line-mode 1) >> >> >> and it seems to work.. > > I take it you mean you see no flickering? That would confirm the patch > fixes problem you reported. You should also see, when you make the > frame have two (or more) windows, that the current line of only the > selected window is highlighted; this is the default behavior without the > patch and should obtain with the patch as well. > >> Any other configuration for testing? > > The default for global-hl-line-mode, which you tested with the above, is > for the value of global-hl-line-sticky-flag to be nil; if you set it to > non-nil, then when you make the frame display two (or more) windows, the > current line is highlighted in all of them. A difference between the > behavior of the existing version of hl-line.el and the behavior with my > patch is that, in the former, the current line of each window displaying > a different buffer becomes highlighted only as soon as that window is > selected (and remains highlighted when another window is selected), > while with my patch, the current line in all live (visible) windows is > highlighted at once. So this is a new feature and the question is, do > you prefer this behavior to the original behavior? (If all the windows > display the same buffer, then with non-nil global-hl-line-sticky-flag > the highlighting appears in all of them simultaneously both with and > without the patch.) > > It would be helpful if you'd also test the behavior of the patch with > the buffer local hl-line-mode. Here, the default is for the value of > hl-line-sticky-flag to be non-nil, which means that if the same buffer > is displayed in two (or more) windows of a frame, the current line is > highlighted in each of these windows, and in addtion, when you select a > window displaying a different buffer, the line in the previously > selected window (displaying the buffer in which hl-line-mode was > enabled) remains highlighted. If you set hl-line-sticky-flag to nil, > then only the current line of the selected window is highlighted. These > behaviors of hl-line-mode should still be the same with the patch. But > without the patch, setting hl-line-sticky-flag to nil results in > flickering of the highlighted line when moving the scroll bar with the > mouse; with the patch, there should be no flickering. > > Steve Berman >