From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing Date: Thu, 3 Oct 2019 10:15:11 +0200 Message-ID: References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> <87d0fgamzj.fsf@kenko.localhost.com> <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253100"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37563@debbugs.gnu.org To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 10:16:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFwI8-0013i6-Rh for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 10:16:52 +0200 Original-Received: from localhost ([::1]:33724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFwI7-00074S-GC for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 04:16:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39951) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFwHN-00073O-IF for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 04:16:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFwHL-0002t0-Ac for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 04:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58139) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFwHK-0002so-RD for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 04:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFwHK-0001tJ-Js for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 04:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 08:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37563 X-GNU-PR-Package: emacs Original-Received: via spool by 37563-submit@debbugs.gnu.org id=B37563.15700905277213 (code B ref 37563); Thu, 03 Oct 2019 08:16:02 +0000 Original-Received: (at 37563) by debbugs.gnu.org; 3 Oct 2019 08:15:27 +0000 Original-Received: from localhost ([127.0.0.1]:38727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwGk-0001sH-PB for submit@debbugs.gnu.org; Thu, 03 Oct 2019 04:15:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:55935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFwGg-0001s1-EY for 37563@debbugs.gnu.org; Thu, 03 Oct 2019 04:15:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570090513; bh=YwV4DaJYfhc0MGCyiGDu8kLX0B9LUtoo6ggbLErWroI=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=ekDVMGVjKp5Bhk12Im/9M92BTKCpmJXMsPKF9rnWmxs/W+/oytetBAWuy3aaO6Aaq +mq74bdROGCUgFU2BXvVbz0qzYzohf36N06fDT4pwmXV7Ew5nsK2Txdd6t5+E2MgRG /mcFukXBugtr6eDT2K9nPNr+DM/0ynW53l/Bq9X4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([46.125.249.90]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MG9gE-1iLPO133cK-00GbSR; Thu, 03 Oct 2019 10:15:13 +0200 In-Reply-To: <93140a98-fd99-7d55-0d5b-dd8c3c733521@gmx.at> Content-Language: de-AT X-Provags-ID: V03:K1:TvzwgTFussNziT3BbddE0qj7S7NS0hN5MZFk6ZR5cCDyxKD2JBr rtzdIQ4Gk4QII9sCpNO/hROc+CD6Yrlh79ysV3Zf3q1Bb+Xw+EMuO2uPVX15AGxprg9JRVE hn7FsREiQVgl0KMNDoss6F8OEcdba7FqIxTTR9k5S98bdz1v0cTAW/s6KLs/J3ijRLlxWhI qqU+Mooxv6p6IEs40Sb4g== X-UI-Out-Filterresults: notjunk:1;V03:K0:VRl5ns64j7Y=:vo/uhXrN4JgXrWeTIjXZeK O/Yqa5NNt65XiMQ+OwfQZbtd0zHdtQS0bB6AgEhLYLGTu2mT0NBYZoSgCRGCWp1bVxxWNXmrG DcbZfqok3B+1cPIX6uTJauVVCuL+bLU65Zgd5/0MpJHumETR3Lb+Iy0mxpxzpPg8u3Ne0tXh6 0wdHZLvPWsKkgNJYIex44qvSHYtBZqmc66n0E0/o3m0rA/sqfcp9iqT3MEDAWLplEl5IKOu6V yiW7avt1FEyv83v2iFdZe0ONhpklxPI/FUYqM6QwXo5q4DmRtuRDb1vL1Co8OFSWYLoJqSS04 qImP1USwhrudi/y/p+CxS6HtPGZNnf/auS8BR9zW0057Hs4XJnUPpwiv7J0n371k9LzB43W2S 3FhUm0oIm6AVa+0SoeEfSCs2Vh8Qov+YaKY2esGpN6Xw8pSmOqetFqB8zR4I0qwl6wb7NO/vA LSFw6ZkobC+1yYg5zorTmU2dj7qy4/ao9Zea2gpDrTEN9n2nxKA6A3O/zlhtmukzgXugRWVhD p9ZEkZZMmbFGiHf/lX/iPLz9meisxiBWIVwr3kk1pMDFVcwEzESB4PwKEHi6MiFlsSedNaFyS t71nzwmIBr+45UZdeMbmOQF8sNXXvySyrTbd2u8uXKXE30PaxDoz05lfAGMffkqZ9p7sgwNDC H/fhl6pFX7T655owaAZCzdqjfDE3LL/vS1Fj4RFfY8AeZxTV5UJ6CpLmzu4xw9i0GZec+HRov 6Yvg5bI8UurPxhIqNQCLjzG+3teYvS8Q9WegIaCpSA2kn7qjffDBPuhCDsS+0I/gtbbkNBlT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168204 Archived-At: > Agreed. But if I change 'fit-frame-to-buffer', then, for consistency, > I have to at least change 'fit-window-to-buffer' too. > > > + (setq height (* (/ (+ height line-height -1) line-height) > > + line-height))) > [...] > > And then char-height can be dropped. > > Right. Hmm... Back to the roots, unfortunately. When we are here, 'height' is the calculated height the window should have in pixels. When we want to communicate this value to the window manager and 'frame-resize-pixelwise' is nil, we have to transform this value (which already includes the pixels needed for line spacing) to a multiple of the canonical character height of the frame and not the line height we calculated earlier. So using 'line-height' here is not the TRT unless I'm missing something. WDYT? martin PS: My 'window-line-height' must be renamed to not clash with the homonymous function in window.c. It will probably become something like 'window-default-line-height' unless I manage to merge it into 'default-line-height' itself.