From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 16 Nov 2019 10:17:34 +0200 Message-ID: References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <83blte7kvc.fsf@gnu.org> <838soi5xm1.fsf@gnu.org> <838soh4l4n.fsf@gnu.org> <83tv746y3x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146095"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: jonas@bernoul.li, 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 09:18:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVtHX-000bsq-CB for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 09:18:11 +0100 Original-Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVtHV-0006br-JH for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2019 03:18:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54493) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVtHP-0006bW-Gd for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:18:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVtHO-0004ZA-7V for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVtHO-0004Z5-4L for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVtHN-0008FQ-Uf for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 03:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2019 08:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157389227131688 (code B ref 37774); Sat, 16 Nov 2019 08:18:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Nov 2019 08:17:51 +0000 Original-Received: from localhost ([127.0.0.1]:37671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVtHA-0008F0-QA for submit@debbugs.gnu.org; Sat, 16 Nov 2019 03:17:50 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:37824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVtH9-0008Ej-Bz for 37774@debbugs.gnu.org; Sat, 16 Nov 2019 03:17:47 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id b17so12845857wmj.2 for <37774@debbugs.gnu.org>; Sat, 16 Nov 2019 00:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Cxh9KCqR8IY3FJ/CyKtxPSiyp2cVTBnuPFsfWrUXXdw=; b=f94T32k261CdSsS3ADRcA0gRiRMzCNzSWBuh/UnYMY8t3ZUjocadWuqiCNXkwBGL0Z AGaL4uLyWYNbusxyhtmaNPb6dgZE4RTGOmEMsdjQLO5CJtOOlF24ps0mtEhxYgLjJM8G by75TdnB1k2qE5+pBNGjo11bBC3niSVZDgiCl9M5xZDY5sTIWUXq4sfc/zR/DrbM5Ohr 97DgXNhckHfj48/9PFdVa1E/JQjSqo7aFqAB/NjEvnyDX6IAGJHLMfrOtcZQSsWO7Ak4 JSDoQ9bsqktXSi+mXR5c3SJ6BSOn/5AN/LdoCGDgAKFFwCRUzyiHCSV4nsGGhgHY8ljj 0JFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cxh9KCqR8IY3FJ/CyKtxPSiyp2cVTBnuPFsfWrUXXdw=; b=ZDXNnVkU9jlaMEwOKTP8zbhwkdbuqsHNKPbOL8+TvTCipmB7PYS4q4WKjT14ekqvPb aUG3QLabHz+XDnAlLc7j9lc+cRITzEE82ljwd2hBsEkEyU3kQ7I5HV+TpRMuExK85Hhx AydDBhlloRrRid8YMG2gQCMohr6NPxf3fAIxySyGao7yi6Dwo2NRWsgg0eSHX1lPbMwY rt9D94vyIjPmAOB7++BAmuOCuR9cWkjM6vsbHdYGfYoVXxidyoJd3/28I6KhH7vlcvcO qgsT0cA0v7yfLskjyMTSWYB2O6EsP0SxxxGLQykUFq1ihEXMju+60bsRdyC3O30x/P9l tjwA== X-Gm-Message-State: APjAAAXSUbf53VdG3METBhyOunkDwgb8P2iNbeCUZh+Ypyyao9k1Mx8n 7mKS7EmeOnJbNt5s8I59KsXvyUT6aIA= X-Google-Smtp-Source: APXvYqyZ2/1phDYnot24SWO7fDX9Jms5AFahClHj2aoxVmkpuEPFljRKNqPBz0AO4qfjw2FZv7rUtQ== X-Received: by 2002:a1c:814b:: with SMTP id c72mr20042453wmd.167.1573892261236; Sat, 16 Nov 2019 00:17:41 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 83sm12835268wme.2.2019.11.16.00.17.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Nov 2019 00:17:40 -0800 (PST) In-Reply-To: <83tv746y3x.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171703 Archived-At: On 16.11.2019 10:09, Eli Zaretskii wrote: >> Well, it kind of does. At least, if the default value of the new >> attribute is in line with the previous behavior, most faces won't have >> to change. > > I was talking about the case where the defface we have for that face > DOES use the new attribute. In that case, the default value of the > attribute doesn't matter, since the defface uses some specific value, > and that will always be a non-default value. My point is those should be more rare. Or, well, bring significant value somehow. > IOW, whenever we introduce a new face attribute and use it to modify > the defface of a built-in face, this problem will pop up. Yes. But in some of those cases third-party faces would not have to be updated. And if the default doesn't change the behavior from the previous Emacs releases, they certainly wouldn't have to be updated right away. >> Another option that had been voiced is to split the value into two >> attributes: :extend-foreground and :extend-background. > > But :extend is not just about colors, it is also about underline, > overline, strike-through, and box attributes. In fact, the underline > attribute was an even more important one, because extending it looks > exceptionally ugly (we even had a few bug reports about that). I think the idea for this approach is to consider underline, overline, strike-through to be a part of foreground. Maybe box as well, I'm not sure. >> But that brings me to a question. I think whether the 'region' face has >> :extend-background to nil or not is a personal choice. Would the user >> have to fight and convince the author of the theme they are using to >> change that attribute? Or will it be easy to apply personal >> customization and call it a day? > > Why would using a theme need anything beyond a simple face > customization to modify :extend (or any other attribute)? The author > of a theme can do what they think is best, but users can always > override that by customizing the face after loading the theme. OK, good. :-)