From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Wed, 26 Dec 2018 02:43:08 +0200 Message-ID: References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <87imzng7gn.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545784929 19299 195.159.176.226 (26 Dec 2018 00:42:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Dec 2018 00:42:09 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 26 01:42:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbxGu-0004tA-RD for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Dec 2018 01:42:04 +0100 Original-Received: from localhost ([127.0.0.1]:43861 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbxJ1-00084M-4r for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 19:44:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbxIs-00084H-Ai for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 19:44:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbxIo-0003CP-CN for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 19:44:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbxIo-0003CF-8R for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 19:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbxIn-00005Z-Tx for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 19:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Dec 2018 00:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.1545785037314 (code B ref 33567); Wed, 26 Dec 2018 00:44:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 26 Dec 2018 00:43:57 +0000 Original-Received: from localhost ([127.0.0.1]:36519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbxIf-00004v-SO for submit@debbugs.gnu.org; Tue, 25 Dec 2018 19:43:57 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:39818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbxIa-0008WJ-Nx for 33567@debbugs.gnu.org; Tue, 25 Dec 2018 19:43:52 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id f81so14213863wmd.4 for <33567@debbugs.gnu.org>; Tue, 25 Dec 2018 16:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=58ix1XFVTxAC0Bpq9d2iY8VhQOc6WPZXBYt5mHqYAvI=; b=S0pc2Vs9STFHhogJ06ShIYbYKyrGenjS52p6RzK6OFjqDt0/WN1dQsW5YPRcGSjv1N h7K/3N65nLZISQxWyEdDT8yW2mPqcp67HoPNHa0d2V5asXCSUqSFgWWaRFi1t2DuCJ0w tNTDA5BTrD16JxOvUZLMpm0eX2Gd295fU+vlsJRJwzwy3jqryGOfYEfA8sNixp9QtCWu bM+cOxcxVW7KZqwpiSaae+mrWfWE0yvxNM93Y8YQ8ZSkjcwe0HDP4VfmLToqMHfDZzda SGVEF75S8xa4PdIj26/1v97/IyftVEgNyqhLF/Htz59P6nX1uGxxMpdQUjljyGyOOR5f ZORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=58ix1XFVTxAC0Bpq9d2iY8VhQOc6WPZXBYt5mHqYAvI=; b=Lf0VMrECbjvCd7DEBmWwmMmxKFoqR6IoJStb1+I8LHtECIry6Hmn+WXIXqg/ieik+p uiapiRSS4wYZ4MjummYpE/YmoCS1NqtRfRxBd5/L9xKpXHAIj4ExkmBir2EJUT9PLGnG e3HDz72i1D1rATXtUNxlt/FH/zoaLn2RekPNaNyBrWBa6fp0zh6Br9DmZ1y7LKapHWw+ /O8TQgzZLs+YW+KRaUHSxoCr39ulDX5r39zfkkUdluiZ4cyhQ6YmJZaL0Rm5VXbveZXb qGawV7HdYeCk54n8DltgL2qS0rcEYq3Mt2VICtMGJ8VP39F3WrtbXcGP301A5sMjwL42 tG1g== X-Gm-Message-State: AA+aEWaija5ARJKH7VQoGr+9rEbSN0xFeuBe5P5EDXEXe9lbRZvBvRaW udA809LHWgAEWtxpPUgB6ZyTN63m X-Google-Smtp-Source: AFSGD/UfndCeWzepxQ0AFM8lWwW2BSCYh5ouMtht5lUL5shXCGLJdJXyK9cXRzcu8neqBrimq2BuJA== X-Received: by 2002:a1c:70b:: with SMTP id 11mr17079456wmh.74.1545785022517; Tue, 25 Dec 2018 16:43:42 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id e17sm36810811wri.36.2018.12.25.16.43.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Dec 2018 16:43:41 -0800 (PST) In-Reply-To: <87imzng7gn.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153854 Archived-At: On 21.12.2018 0:17, Juri Linkov wrote: > But please see in https://debbugs.gnu.org/10181#68 > why red and green colors are not symmetrical and > how is was wrong on GitHub. Thanks! (TBC in another email). > Your proposed new colors for added/removed are the same that are used > GitHub/GitLab, so this should be a good change. Now pushed, thank you. > While at it, please also tone down file/hunk header colors: > diff-header from grey80 to grey90 and > diff-file-header from grey70 to grey80 I see you have done that yourself, looks good.