From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#56025: [WIP PATCH] 29.0.50; em-extpipe-test-2 times out on EMBA and Cygwin Date: Sun, 17 Jul 2022 17:59:32 -0400 Message-ID: References: <8e21db9c-0100-998e-f280-81304e7ff61a@cornell.edu> <17d41105-b006-f9ad-af0b-ece84a7f5248@gmail.com> <040b3a36-459b-a94d-f879-7f45aac50bda@cornell.edu> <83sfnud26o.fsf@gnu.org> <96e47ba7-efaa-b6df-dd98-60f09068e68c@gmail.com> <874k097lbh.fsf@melete.silentflame.com> <8735frmjrr.fsf@athena.silentflame.com> <4676f52c-4758-38df-f0f4-dbcb5d848c1b@gmail.com> <8735fr2kq6.fsf@melete.silentflame.com> <10cf6a90-f86a-b0df-4dc2-c258b7494158@gmail.com> <18e79c02-3a2a-77d1-3798-33711f52d6b9@cornell.edu> <19c66901-2eeb-1f40-17a4-4ed54827e065@gmail.com> <5990de80-63a5-ac9b-1a11-c814aa9e38f2@gmail.com> <3779ea08-f481-5fb5-3257-ca9fa7c604bc@cornell.edu> <60cf587b-5d83-31d6-f0af-56979b221425@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38229"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: larsi@gnus.org, 56025@debbugs.gnu.org To: Jim Porter , Sean Whitton , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 18 00:00:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDCJu-0009ig-Vu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 00:00:59 +0200 Original-Received: from localhost ([::1]:42802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDCJt-0006MA-T8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 18:00:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDCJ0-0006Kz-S1 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 18:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDCJ0-0007S4-GE for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 18:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDCJ0-0004FA-Ad for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 18:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2022 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56025 X-GNU-PR-Package: emacs Original-Received: via spool by 56025-submit@debbugs.gnu.org id=B56025.165809518716265 (code B ref 56025); Sun, 17 Jul 2022 22:00:02 +0000 Original-Received: (at 56025) by debbugs.gnu.org; 17 Jul 2022 21:59:47 +0000 Original-Received: from localhost ([127.0.0.1]:48682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDCIk-0004EH-NX for submit@debbugs.gnu.org; Sun, 17 Jul 2022 17:59:47 -0400 Original-Received: from mail-dm6nam10on2125.outbound.protection.outlook.com ([40.107.93.125]:22370 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDCIg-0004E1-Nd for 56025@debbugs.gnu.org; Sun, 17 Jul 2022 17:59:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lXOrM82Vu3DhxwdTCi4ItGQRPKfifSNoU1y1JSZDhQF0u3msPC+w51iwajpQ0FiQ8WsmueQuAFYaosrOLdqa6F6IvW9Alsd3QHiJdA8N2UekbEOaO/FHEHgmwWK6qXXqJfNYQYDw7zzzBER1xoXPZTDbk4T68PxxAVYBTHOQFk8+fWZQLxNy73wob0j/+hsPhm3XlC+mxcR28riDzcImUlqDYP9Avw2UmrGWM7/ta27UOUHZ9MQ8XuwmWoziBD56cEVrQbx7zqOEJ56UZng7m6mXoxLdfaMZYHn8Hng3CU0ezpVWtAUZEvkLoK5DiZgGnOzn1zrCWwXyugIwm5WLvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gGTujauc9wHxnkXhsjYYb3LI42EUuEvhH+AFYL2wT00=; b=UFAklDYPDILEV9XMJdE36rOqUjbndgK5g9VHEqxhWONJqX+Du87VOVe5VrADAnjN9ii+iXCWpt3vU95fuLq920pPTiyIlEOacXwPhNnG0z8iaZhz1WjARp06j/rLFafAQiQ6JZGUs+6p0KxRV2PCAknDy3YafnwT2pIuGEDKDn6SaDC5yBVLro1xuvdb5M18I14PpRIsV0+TT1INClDnxk51xseW0sZyMEVmzb13QUMOIItfRQt0WkVMGPZhCEkIorDRtNeEqbIVd0MJLsL7JmspidfB8cOEn46dnz9sGwaYfJ7TEXz2w1NvONiK+9//yhTzYE6jELBrp4hteEXLNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGTujauc9wHxnkXhsjYYb3LI42EUuEvhH+AFYL2wT00=; b=VBE/74U6d/CtyFxe2P1zfiEEKISqbfs/hxsujtLmgTiGeU9mmJLyfdAlHZ6fezNHuhKxumcbT+iTyVFFx+8qHLclEiL9wXP9R7giBfv5gWkAaSA1ddKpjKtOTHyoXYvktf6H5YkWPFh9+SJ5mYolBF1E706OKdRkwhWDcAMGNuM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN7PR04MB4036.namprd04.prod.outlook.com (2603:10b6:406:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Sun, 17 Jul 2022 21:59:35 +0000 Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::901f:a758:30f5:309d]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::901f:a758:30f5:309d%2]) with mapi id 15.20.5438.023; Sun, 17 Jul 2022 21:59:34 +0000 Content-Language: en-US In-Reply-To: <60cf587b-5d83-31d6-f0af-56979b221425@gmail.com> X-ClientProxiedBy: BL1PR13CA0079.namprd13.prod.outlook.com (2603:10b6:208:2b8::24) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84dea0c4-ce5c-4cfa-e3d7-08da683fa29b X-MS-TrafficTypeDiagnostic: BN7PR04MB4036:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /8TR3N1vCRK0AIsSrsK2DlOazuqT5aGgSKTazGavV8bEAF5QmhGvtZc2EZBNjkZKbWc5FFI7I0j+XaoLHDzF2BQLSuYgcOJKb0s78+B/pfm8CD8H2DdGLACPzL6em4WMwdnjWk5sZ4wr/L4B0T24zDHxrCESyU6irhzvHlvv3yvnCBKe9hCqxCvlMdWwTlevMl0ivQR2rYaPMLAUP5vq4hIaJjpa9PHKkfKxaW0JPqtUkMp4dOcPCsyOuzouTR1XzKyFYFigd1w/7UxolWbv6RlFfMhnk6vw4Hsai6RmsVllmhqYsF9wNhriLH7Dh+zGsisrIKIhnF7Axi2jarsEGnQS7q+IpS9/9g069IIlj1CJVY73NNsWrwJ5DzS8qS2iGJxdLR0CTrZzNC5eUd2jMm3oeEzuU8EBqlcdkouG7H35bOLj+8dNFMs2jJvV53UJrwO+lJR4mS8LenwWVYjLXnM/EsHkSpP4mXifHiS5uHuh/Sa3aog4gBzCSxR3miu5kOl70++vP8U4aM+nJOjIqJ6e2XOHkl0vkANw22/xgPuT79qDeQJ3QiHawps2AV9+6Jr5DluRdPeRbZ6g92uotcYXJQRoyE45/VFmiei/sLa9+fT4+rs7tVgtwSieyXpBDCih/g/nbCJpNba1G8/iWYZ/hsEOwzr9jdsUsUtwVqb8h20iwaUJ/f4U85xjH9nrNdO3XzHs1PaPInKIRo8hYnwrxs7n42ynRRmNhfGlw1D52HqQFCtOdkhhYNDUD AICtzPsFX0295KqmVDvuwxlaCNjY5SHHJeZvK06aDmewDJ7jKuq2vypOB4u9qMF7EzkED4mMBfGb+DzN1mVTscC/bYlYH+9l4o X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(2616005)(186003)(38100700002)(6486002)(478600001)(53546011)(6506007)(6512007)(41300700001)(66946007)(2906002)(8936002)(5660300002)(36756003)(41320700001)(31686004)(8676002)(75432002)(31696002)(86362001)(786003)(316002)(110136005)(66556008)(66476007)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uAYSJvA+CRbAKaTp457z56IWGGYXgDAja3KHZBY8banmWiDjLplaicxev8+E5CxqhAgcomBmqwDaFSK582Na6uPaLbSq2NGPEHYPhM3uZYHIhSzrcbixxj3MaemwiUSpP22JjSM1SP4DQgzdKkTidDCyFC7JmCaXA1ULMheTvIuq9YSWk6MFNrUTI4HeMev8Y+l5+7dDmgdHCydJq2HGnW/JcLa1OBS1BsqxzgITieHYe9JFNsQTAPtIr0KewgFSDZ87FmjVa9icXPudb4RhaQbCQjo54a35x3ZYahaoCJqPvO/m6Ej6CdKDriYKqVQiHA52fW+SRrtJiBNP6AvOATAiMAT6BSFQFLrw9+WL6KeGAqwIx5QL7lqrpRc8G+Dv61QlmaZYQdavMzwNjoT+bl83jAvSPZUukFCm12KUhUmMEqDIR5ldaCiM3y3D1imPmtROseMBhFu07IWT6NDL8h+3Y7u8EIRogibp4qoWgO5RSUh4F4JUc/T1IOHqNK6Vg0xJZP9VhAF9wD9v6liCVXFrgOa2IYPWqqM+ddb73yKvvvjQR+a/OmVfFPZSysnyHZIrOEw5bwwLKx1Qf6BmWmjUibqrW6ZwBRx30+oYfmmTpMMFRuzVYBn4BW1kk2XjQmOITxxFla/tAGwgDppCPK/DMb+V4G/T06b8x4Iyyz6iaQyP/eZiEbri/vzeI0QT1je4CpW4J/N0f9U0gfffsFniFlRqUL51BraD5c9YtiZqoiLoMW9LVi/ZA4 3w1bvkwVpxE0h92iCBxS9M4M+gLqxW/6miV7J8XLUemGpocuModlkHtLf/Tbydq98xLg4rgjUgAPhGOF+zDzHyGXohOGaNNKFC X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 84dea0c4-ce5c-4cfa-e3d7-08da683fa29b X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2022 21:59:34.8262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +knez9nZaFU+gyX1l/XtsA1OL3A80EONW/Ksu/GcFOAIJu8n7v9+OoHFoI6GVcxXoL+y3HTh5av/hOjtLtVI7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR04MB4036 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237303 Archived-At: On 7/16/2022 10:35 PM, Jim Porter wrote: > Ok, attached is a WIP patch to do this. It seems to work for me under Cygwin, > although I've only lightly tested it in that environment. If this works for you > too, I'll finish cleaning this up and add tests/documentation for it. It does work for me too. Thanks! > Note that in my patch, I temporarily undid my previous patch to send EOF > multiple times. This is just for testing purposes, but since we're using a pipe > for this connection now, a single call to `process-send-eof' should be > sufficient. There shouldn't be a need for any calls to process-send-eof. This is a noop anyway when writing to a pipe, as it should be. A process reading from a pipe automatically recognizes EOF when a read returns 0 bytes, which is supposed to happen when no process has the pipe open for writing. > (There are some obscure cases where we might want to keep the > current behavior, like redirecting to a process created some other way, so I > think it makes sense to keep that code. Probably...) Ideally, Eshell should know whether it's writing to a pipe or a pty. It should send up to 3 EOFs in the latter case and 0 in the former case. If it's too hard to arrange that, then it's probably harmless to send up to 3 EOFs in the pipe case too. But then maybe a comment in the code would be useful, so that readers don't wonder why you're sending EOF to a pipe. Thanks again for your work. Ken