From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Fri, 16 Dec 2022 00:20:47 +0200 Message-ID: References: <8735budxiz.fsf@gmail.com> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> <86o7s5i1ec.fsf@mail.linkov.net> <86h6xwabpv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27389"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Eli Zaretskii , Augusto Stoffel , 58447@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 23:21:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5wbP-0006sB-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 23:21:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5wbB-0006kQ-9l; Thu, 15 Dec 2022 17:21:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5wb9-0006jv-22 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 17:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5wb8-0001ay-PW for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 17:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5wb8-0004YX-J2 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 17:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.167114285717470 (code B ref 58447); Thu, 15 Dec 2022 22:21:02 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 15 Dec 2022 22:20:57 +0000 Original-Received: from localhost ([127.0.0.1]:45261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5wb3-0004Xi-6G for submit@debbugs.gnu.org; Thu, 15 Dec 2022 17:20:57 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:34739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5wb2-0004Xc-1Q for 58447@debbugs.gnu.org; Thu, 15 Dec 2022 17:20:56 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id bi26-20020a05600c3d9a00b003d3404a89faso449303wmb.1 for <58447@debbugs.gnu.org>; Thu, 15 Dec 2022 14:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=3bQLvdzI/JT88WWMtVfWgdrnJEDo0NP/RRQM6TWIupQ=; b=ixMIHtSjb0XB0u0VQNRw1e+oaOvMbnbTg0c1zzrNbaNpvrPW4JGSlHnrhe81nFBR3a f0uUnM1M5aye9kwEbF8xIZBhzB562GeC2oJ/wjD4wNUM9o4fayKgnJmE852NRR0qEUk9 ULkWx3XPcsS29BcignSUlYTVYfkVutTUZg+i/O57MU7oVVMMdtB3anc4O+sArudKUwDH ltCcs6wHJeJwMvI7O+ffp+dFvI1T47/OQImYTdfTZoZNJZN3q2MDHic12YIWprgVQgOS TvpoDyY4doKl4X8VbK4JhhtaJveTTT9ZywoIGgN99M0u/eqUifTu2sI5hV7+WtpgT8g+ 6GLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3bQLvdzI/JT88WWMtVfWgdrnJEDo0NP/RRQM6TWIupQ=; b=OOChDpSBCyIlAp3UIhfxGu6FpBMf4r6OjW9QZg4yoTJw6o09E5i8Jq1i8ZtEFqdHFp u/IaRQJnUdtU/mAKHfDGlKHQKN8vGipfm7prSLgEoUojk6B3YpUPm053HDyKwvIh9NF/ O94Jt61EGs03ynvXSaLTFRN/4GG6wIUuKOCbShMmfFA2RB9SLi6pceo6E3j9zlQCC0vh V9dNgBd5UIo+/kNZqNCgMQ9jeQCF1ujRInRGosTKV0uir2rTatS/WM0HvXkAANP3hBx/ 4w09RB2ovuuiSo3K2ONP9CxJVzXUeD8gRJmq1NBXZj1bCjVP/80esiCbd0EjADpVQ+7/ ZfSQ== X-Gm-Message-State: ANoB5pkJQmlNzL68daAAAyL1yWGJwLPrSR1n2NvPda1pB/OyxfDvVgFQ yzAY+JO60/P/ZbYl14mzkzk= X-Google-Smtp-Source: AA0mqf4BYF098zNBV1rpCxUKHOrigIq2nGgwQNRntaWvLhE/iGU4TSpFJtC6M8lOPoksbIxNwa2BJg== X-Received: by 2002:a05:600c:5120:b0:3d2:5e4e:6fa with SMTP id o32-20020a05600c512000b003d25e4e06famr3866966wms.34.1671142849864; Thu, 15 Dec 2022 14:20:49 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m35-20020a05600c092300b003b3307fb98fsm386354wmp.24.2022.12.15.14.20.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 14:20:49 -0800 (PST) Content-Language: en-US In-Reply-To: <86h6xwabpv.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251155 Archived-At: On 15/12/2022 19:24, Juri Linkov wrote: >>> But please also note that its value 'project--read-file-absolute' >>> is also broken. It asks confirmation for re-visiting even absolute >>> filenames, because currently 'C-x p f' adds abbreviated filenames, >>> but confirmation checks for absolute. >> Does the breakage show itself only when you add a history entry using one >> value of project-read-file-name-function and then try to look it up when >> using another value of project-read-file-name-function? >> >> If so, that's probably bearable enough for now (people don't really change >> this value often). Fixing it will require resolving the abbreviation >> situation. And we might as well switch to relative names in project-files >> first. > Visiting with 'C-x C-f' adds an abbreviated file name to the history. > So it looks strange that 'C-x p f M-p' doesn't understand that it's > absolute even though it's abbreviated. Fair enough. Can we do something with it, though, without piping all-files through #'expand-file-name?