From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Charalampos Mitrodimas Newsgroups: gmane.emacs.bugs Subject: bug#70139: 29.3.50; key-translate does not support all keyboard-translate usages Date: Tue, 2 Apr 2024 14:28:47 +0000 Message-ID: References: <87v850t7nz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------s2bEnr4L4gsAjk0B9bgA92cL" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70139@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 02 18:02:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrgan-0009Ss-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Apr 2024 18:02:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrgaX-0008AI-IF; Tue, 02 Apr 2024 12:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrgaG-0007zy-0P for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 12:02:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrgaF-0004yV-NC for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 12:01:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rrgaJ-0005p2-Fo for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 12:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Charalampos Mitrodimas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Apr 2024 16:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70139 X-GNU-PR-Package: emacs Original-Received: via spool by 70139-submit@debbugs.gnu.org id=B70139.171207371122302 (code B ref 70139); Tue, 02 Apr 2024 16:02:03 +0000 Original-Received: (at 70139) by debbugs.gnu.org; 2 Apr 2024 16:01:51 +0000 Original-Received: from localhost ([127.0.0.1]:55042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrga5-0005nX-H3 for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:01:51 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:34595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrf8E-0000FF-CO for 70139@debbugs.gnu.org; Tue, 02 Apr 2024 10:29:01 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3C9EE240027 for <70139@debbugs.gnu.org>; Tue, 2 Apr 2024 16:28:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712068128; bh=Lr1YbGuFd62NI/9QBPTQPC4DROVE1VMTs5kBz+AVW2Y=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=YdpIuJ7fs4H4B7L2IFqPn3t18mxk19+2J2yltEELAs7siJoVHqP6AnEfZlyAwwCc2 YeTQmLa52wLfSi4/O8od16ike7Vvt/RNi2ydsCTZrBQPHjU8VoanqaBuBFlMQlQREq 9zgWOmEbZi/NQzgxLSvshHwmyfPoz0OU6LZu+js9KLjHCy2bUoll1xjSbsuM/qkic2 GEXx8Bw/UC6bY/lSlvd6e9GXEGEDHT3Bj+FtJsLgLiSkhwOVj5HEA6Y+newVZcrL6t Dt8wLU1cd0DV05xrQNn1hFFhmXsadxQKDEB2WrIqLJGQuT1dN4+ayPiHAE1m67yzdu pbvdvpW0W2o3A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V89H348kTz9rxT; Tue, 2 Apr 2024 16:28:47 +0200 (CEST) Content-Language: en-US In-Reply-To: <87v850t7nz.fsf@gmail.com> X-Mailman-Approved-At: Tue, 02 Apr 2024 12:01:46 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282521 Archived-At: This is a multi-part message in MIME format. --------------s2bEnr4L4gsAjk0B9bgA92cL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/2/24 12:50, Robert Pluim wrote: > When `key-translate' was added, it didnʼt cover all the cases that > `keyboard-translate' does. > > Add a translation: > > (keyboard-translate ?\C-a ?\C-z) > > Two ways to remove, of which I submit the first is 'obvious': > > (keyboard-translate ?\C-a nil) > (keyboard-translate ?\C-a ?\C-a) > > Add: > > (key-translate "C-a" "C-z") > > This works for removing a translation but is non-obvious: > > (key-translate "C-a" "C-a") > > But this doesnʼt: > > (key-translate "C-a" nil) > > => > Debugger entered--Lisp error: (error "nil is not a valid key definition; see ‘key-valid-...") > signal(error ("nil is not a valid key definition; see ‘key-valid-...")) > error("%S is not a valid key definition; see `key-valid-p..." nil) > > Iʼm not sure this is worth fixing, but perhaps documenting that > re-adding the same translation is (almost) the same as removing it? > > Thanks > > Robert > > In GNU Emacs 29.3.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version > 3.24.38, cairo version 1.16.0) of 2024-04-02 built on rltb > Repository revision: 6b8b0a12333afeadb32744ba481679b05b758ed2 > Repository branch: emacs-29 > Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 > System Description: Debian GNU/Linux 12 (bookworm) > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG > JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY > INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF > TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB I accidentally sent the patch the wrong way (newcomer here), attaching here. -- Charalampos Mitrodimas --------------s2bEnr4L4gsAjk0B9bgA92cL Content-Type: text/x-patch; charset=UTF-8; name="0001-Improve-key-translate-to-support-removing-translatio.patch" Content-Disposition: attachment; filename*0="0001-Improve-key-translate-to-support-removing-translatio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0YzM1ZTQ1YzEyOGQ4YWQwYzkzYWM3ODdmZTUxZWVjYmNkNTcwMjg2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFyYWxhbXBvcyBNaXRyb2RpbWFzIDxjaGFybWl0 cm9AcG9zdGVvLm5ldD4KRGF0ZTogVHVlLCAyIEFwciAyMDI0IDE3OjIwOjQ0ICswMzAwClN1 YmplY3Q6IFtQQVRDSF0gSW1wcm92ZSBrZXktdHJhbnNsYXRlIHRvIHN1cHBvcnQgcmVtb3Zp bmcgdHJhbnNsYXRpb25zCgpUaGlzIHBhdGNoIGVuaGFuY2VzIHRoZSBrZXktdHJhbnNsYXRl IGZ1bmN0aW9uIHRvIGFsbG93IHJlbW92aW5nCmtleWJvYXJkIHRyYW5zbGF0aW9ucyBieSBw YXNzaW5nIG5pbCBhcyB0aGUgc2Vjb25kIGFyZ3VtZW50IChUTykuCgpJZiBUTyBpcyBuaWws IGFueSBleGlzdGluZyB0cmFuc2xhdGlvbiBmb3IgdGhlIEZST00ga2V5IHdpbGwgYmUgcmVt b3ZlZC4KVGhlIGNvbXBpbGVyIG1hY3JvIGlzIHVwZGF0ZWQgdG8gb25seSBjaGVjayBUTyB3 aGVuIGl0IGlzIG5vbi1uaWwuCgpUaGlzIGNoYW5nZSBtYWtlcyBrZXktdHJhbnNsYXRlIG1v cmUgY29uc2lzdGVudCB3aXRoIHRoZSBiZWhhdmlvciBvZgprZXlib2FyZC10cmFuc2xhdGUs IHByb3ZpZGluZyBhIHdheSB0byByZW1vdmUgdHJhbnNsYXRpb25zIHdpdGhvdXQKaGF2aW5n IHRvIHNwZWNpZnkgdGhlIHNhbWUga2V5IGZvciBib3RoIEZST00gYW5kIFRPLgoKVGhlIGRv Y3VtZW50YXRpb24gc3RyaW5nIGlzIHVwZGF0ZWQgdG8gcmVmbGVjdCB0aGUgbmV3IGJlaGF2 aW9yLgotLS0KIGxpc3Ava2V5bWFwLmVsIHwgMTAgKysrKysrLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L2tleW1hcC5lbCBiL2xpc3Ava2V5bWFwLmVsCmluZGV4IGIyYjQ3NWM3ZDcxLi4xNDgxZjFm ZTcyYiAxMDA2NDQKLS0tIGEvbGlzcC9rZXltYXAuZWwKKysrIGIvbGlzcC9rZXltYXAuZWwK QEAgLTM4MiwxNyArMzgyLDE5IEBAIGtleS10cmFuc2xhdGUKIFRoaXMgZnVuY3Rpb24gY3Jl YXRlcyBhIGBrZXlib2FyZC10cmFuc2xhdGUtdGFibGUnIGlmIG5lY2Vzc2FyeQogYW5kIHRo ZW4gbW9kaWZpZXMgb25lIGVudHJ5IGluIGl0LgogCi1Cb3RoIEZST00gYW5kIFRPIHNob3Vs ZCBiZSBzcGVjaWZpZWQgYnkgc3RyaW5ncyB0aGF0IHNhdGlzZnkgYGtleS12YWxpZC1wJy4i CitCb3RoIEZST00gYW5kIFRPIHNob3VsZCBiZSBzcGVjaWZpZWQgYnkgc3RyaW5ncyB0aGF0 IHNhdGlzZnkgYGtleS12YWxpZC1wJy4KK0lmIFRPIGlzIG5pbCwgcmVtb3ZlIGFueSBleGlz dGluZyB0cmFuc2xhdGlvbiBmb3IgRlJPTS4iCiAgIChkZWNsYXJlIChjb21waWxlci1tYWNy bwotICAgICAgICAgICAgKGxhbWJkYSAoZm9ybSkgKGtleW1hcC0tY29tcGlsZS1jaGVjayBm cm9tIHRvKSBmb3JtKSkpCisgICAgICAgICAgICAobGFtYmRhIChmb3JtKSAoa2V5bWFwLS1j b21waWxlLWNoZWNrIGZyb20gKGFuZCB0byB0bykpIGZvcm0pKSkKICAgKGtleW1hcC0tY2hl Y2sgZnJvbSkKLSAgKGtleW1hcC0tY2hlY2sgdG8pCisgICh3aGVuIHRvCisgICAgKGtleW1h cC0tY2hlY2sgdG8pKQogICAob3IgKGNoYXItdGFibGUtcCBrZXlib2FyZC10cmFuc2xhdGUt dGFibGUpCiAgICAgICAoc2V0cSBrZXlib2FyZC10cmFuc2xhdGUtdGFibGUKICAgICAgICAg ICAgIChtYWtlLWNoYXItdGFibGUgJ2tleWJvYXJkLXRyYW5zbGF0ZS10YWJsZSBuaWwpKSkK ICAgKGFzZXQga2V5Ym9hcmQtdHJhbnNsYXRlLXRhYmxlCiAgICAgICAgIChhcmVmIChrZXkt cGFyc2UgZnJvbSkgMCkKLSAgICAgICAgKGFyZWYgKGtleS1wYXJzZSB0bykgMCkpKQorICAg ICAgICAoYW5kIHRvIChhcmVmIChrZXktcGFyc2UgdG8pIDApKSkpCiAKIChkZWZ1biBrZXlt YXAtbG9va3VwIChrZXltYXAga2V5ICZvcHRpb25hbCBhY2NlcHQtZGVmYXVsdCBuby1yZW1h cCBwb3NpdGlvbikKICAgIlJldHVybiB0aGUgYmluZGluZyBmb3IgY29tbWFuZCBLRVkgaW4g S0VZTUFQLgotLSAKMi4zNC4xCgo= --------------s2bEnr4L4gsAjk0B9bgA92cL--