* bug#18575: package-test-signed should use skip-unless, not expected-result
@ 2014-09-27 19:00 Glenn Morris
2014-09-27 22:01 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2014-09-27 19:00 UTC (permalink / raw)
To: 18575
Package: emacs
Version: 24.4.50
Severity: minor
package-test-signed should use skip-unless rather than expected-result.
The latter can lead to false "failures" when the test succeeds, eg
https://hydra.nixos.org/build/14915239/log/raw
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#18575: package-test-signed should use skip-unless, not expected-result
2014-09-27 19:00 bug#18575: package-test-signed should use skip-unless, not expected-result Glenn Morris
@ 2014-09-27 22:01 ` Glenn Morris
2014-09-30 13:18 ` Ted Zlatanov
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2014-09-27 22:01 UTC (permalink / raw)
To: 18575
Glenn Morris wrote:
> package-test-signed should use skip-unless rather than expected-result.
> The latter can lead to false "failures" when the test succeeds, eg
>
> https://hydra.nixos.org/build/14915239/log/raw
The fact that the test can pass even when epg-check-configuration fails
probably indicates that is the wrong thing to test anyway. The cause on
hydra is probably that HOME does not exist, which causes gpg
--list-config to fail:
HOME=/tmp/foo/bar gpg --with-colons --list-config
gpg: fatal: can't create directory `/tmp/foo/bar/.gnupg': No such file or directory
Perhaps tests should bind epg-gpg-home-directory to a suitable value.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#18575: package-test-signed should use skip-unless, not expected-result
2014-09-27 22:01 ` Glenn Morris
@ 2014-09-30 13:18 ` Ted Zlatanov
0 siblings, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2014-09-30 13:18 UTC (permalink / raw)
To: Glenn Morris; +Cc: 18575
On Sat, 27 Sep 2014 18:01:42 -0400 Glenn Morris <rgm@gnu.org> wrote:
GM> Glenn Morris wrote:
>> package-test-signed should use skip-unless rather than expected-result.
>> The latter can lead to false "failures" when the test succeeds, eg
>>
>> https://hydra.nixos.org/build/14915239/log/raw
GM> The fact that the test can pass even when epg-check-configuration fails
GM> probably indicates that is the wrong thing to test anyway. The cause on
GM> hydra is probably that HOME does not exist, which causes gpg
GM> --list-config to fail:
GM> HOME=/tmp/foo/bar gpg --with-colons --list-config
GM> gpg: fatal: can't create directory `/tmp/foo/bar/.gnupg': No such file or directory
GM> Perhaps tests should bind epg-gpg-home-directory to a suitable value.
`package-refresh-contents` should create this directory and set it as
the EPG context's homedir. That does not depend, in theory, on
`epg-gpg-home-directory` because `package-refresh-contents` calls
`package-import-keyring` which does:
(let ((context (epg-make-context 'OpenPGP))
(homedir (expand-file-name "gnupg" package-user-dir)))
(make-directory homedir t)
(epg-context-set-home-directory context homedir)
...
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-30 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-27 19:00 bug#18575: package-test-signed should use skip-unless, not expected-result Glenn Morris
2014-09-27 22:01 ` Glenn Morris
2014-09-30 13:18 ` Ted Zlatanov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).