bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions

bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions

[Pavel Repin]

Hello,

Hi, when building Emacs 23.4 using homebrew on OS X 10.7 with Xcode
4.3.2, I've encountered errors described below when running "make
bootstrap":

src/nsterm.m:5451:5: error: non-void method 'performDragOperation:'
should return a value [-Wreturn-type]
src/nsimage.m:337:5: error: non-void method 'setXBMColor:' should
return a value [-Wreturn-type]
src/nsfont.m:1281:5: error: non-void function 'nsfont_draw' should
return a value [-Wreturn-type]

The patch to fix these errors is specified here:
https://github.com/mxcl/homebrew/issues/11263

Hope this helps. Thanks.

PS:
Build details (I built this version of Emacs using homebrew with the
fix applied):

In GNU Emacs 23.4.1 (x86_64-apple-darwin11.3.0, NS apple-appkit-1138.32)
of 2012-03-28 on mac-pavel.local
Windowing system distributor `Apple', version 10.3.1138
configured using `configure  '--prefix=/usr/local/Cellar/emacs/23.4'
'--without-dbus'
'--enable-locallisppath=/usr/local/share/emacs/site-lisp'
'--infodir=/usr/local/Cellar/emacs/23.4/share/info/emacs' '--with-ns'
'--disable-ns-self-contained' 'CC=/usr/bin/clang' 'CFLAGS=-Os -w -pipe
-march=native -Qunused-arguments''

bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions

[Glenn Morris]

Pavel Repin wrote:

> The patch to fix these errors is specified here:
> https://github.com/mxcl/homebrew/issues/11263

Thanks. I looked at the patch (which is small; why not include it in
your original report?). It seems to me that this is already fixed in the
Emacs trunk for 24.1, by this:

http://lists.gnu.org/archive/html/emacs-devel/2010-11/msg00133.html

It would be great if you try a pretest from

http://alpha.gnu.org/gnu/emacs/pretest/

to confirm.

bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions

[Pavel Repin]

On Mar 28, 2012, at 20:58, Glenn Morris <rgm@gnu.org> wrote:

> Thanks. I looked at the patch (which is small; why not include it in
> your original report?).

My bad. The patch is pasted below.

> It seems to me that this is already fixed in the
> Emacs trunk for 24.1, by this:
>
> http://lists.gnu.org/archive/html/emacs-devel/2010-11/msg00133.html

Yes this is great it was fixed in trunk (my patch is almost identical).
Any chance it might be applied to 23.4 branch?

The patch against 23.4 tarball:

diff -ur a/src/nsfont.m b/src/nsfont.m
--- a/src/nsfont.m  2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsfont.m  2012-01-11 04:35:01.000000000 -0800
@@ -1278,7 +1278,7 @@
       }

     CGContextRestoreGState (gcontext);
-    return;
+    return 0;
   }
 #endif  /* NS_IMPL_COCOA */

diff -ur a/src/nsimage.m b/src/nsimage.m
--- a/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsimage.m 2012-01-11 04:35:01.000000000 -0800
@@ -334,7 +334,7 @@
   NSColor *rgbColor;

   if (bmRep == nil || color == nil)
-    return;
+    return nil;

   if ([color colorSpaceName] != NSCalibratedRGBColorSpace)
     rgbColor = [color colorUsingColorSpaceName: NSCalibratedRGBColorSpace];
diff -ur a/src/nsterm.m b/src/nsterm.m
--- a/src/nsterm.m  2012-01-11 04:35:01.000000000 -0800
+++ b/src/nsterm.m  2012-01-11 04:35:01.000000000 -0800
@@ -5431,7 +5431,7 @@
   NSTRACE (performDragOperation);

   if (!emacs_event)
-    return;
+    return NO;

   position = [self convertPoint: [sender draggingLocation] fromView: nil];
   x = lrint (position.x);  y = lrint (position.y);

bug#11119: 23.4; Xcode 4.3.2 dislikes valueless return statements in non-void functions

[Chong Yidong]

Pavel Repin <prepin@gmail.com> writes:

> Yes this is great it was fixed in trunk (my patch is almost identical).
> Any chance it might be applied to 23.4 branch?

No more changes are going to that branch, since we are not planning any
more 23.x releases.