bindings displayed by describe-mode do not reflect minor mode overrides

bindings displayed by describe-mode do not reflect minor mode overrides

[Jason Eisner]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.3.1 (i386-redhat-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2004-04-15 on bugs.devel.redhat.com
configured using `configure  --host=i386-redhat-linux --build=i386-redhat-linux --target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --with-pop --with-sound'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I was visiting a Gnus buffer *Summary nndraft:drafts*, with major mode
gnus-summary-mode and minor modes including gnus-draft-mode.

I used C-h m (describe-mode) to get a description of the mode.
Indented below is what appeared in the *Help* window.  It lists D
twice, first in the major mode bindings (false since this is
overridden), and second in the minor mode bindings (true).

Listing D as part of the major mode is misleading, particularly in the
context of the description text supplied by this particular major mode
("The following commands are available").  

(Perhaps it is deliberately included so that describe-mode can always
be relied on to give a complete description of the major mode.  But if
so, currently overridden bindings should be flagged as such, IMHO.)

By contrast, C-h b (describe-bindings) does not list D twice.  It
lists the minor mode bindings first, followed by the major mode
binding with D omitted.  

	The major mode is described first.
	For minor modes, see following pages.
	
	Summary mode:
	Major mode for reading articles.
<snip>
	The following commands are available:
	
	key             binding
	---             -------
<snip>	
	D		gnus-summary-mark-as-read-backward
<snip>
	\f
	Gnus-Draft minor mode (indicator Draft):
	Minor mode for providing a draft summary buffers.
	
	key             binding
	---             -------
	e		gnus-draft-edit-message
	D		Prefix Command
	
	D S		gnus-draft-send-all-messages
	D s		gnus-draft-send-message
	D e		gnus-draft-edit-message
	D t		gnus-draft-toggle-sending
<snip>

Recent input:
C-p C-p C-p C-n C-n <switch-frame> <down-mouse-1> <mouse-movement> 
<mouse-1> <escape> x u <backspace> b u g <tab> M-b 
C-k e m s <backspace> a c s - b u g <tab> <backspace> 
<backspace> C-g C-g C-h a b u g <return> C-x o C-n 
C-n C-n C-s s u b m i t - b u g C-s C-s C-s C-s C-s 
C-s C-s C-s C-r C-r C-n C-p C-n C-s b u g C-s C-s C-s 
C-v C-v C-n C-n <escape> x r e p o r t - e m a c s 
- b u g <return>

Recent messages:
Mark saved where search started
Mark set
Mark saved where search started
Mark set
call-interactively: Quit
keyboard-quit: Quit
Loading apropos...done
Type C-x 4 b RET to restore the other window.  C-M-v to scroll the help.
Mark saved where search started [2 times]
Loading emacsbug...done

Re: bindings displayed by describe-mode do not reflect minor mode overrides

[Kevin Rodgers]

Jason Eisner wrote:
 > I used C-h m (describe-mode) to get a description of the mode.
 > Indented below is what appeared in the *Help* window.  It lists D
 > twice, first in the major mode bindings (false since this is
 > overridden), and second in the minor mode bindings (true).
 >
 > Listing D as part of the major mode is misleading, particularly in the
 > context of the description text supplied by this particular major mode
 > ("The following commands are available").
 >
 > (Perhaps it is deliberately included so that describe-mode can always
 > be relied on to give a complete description of the major mode.

Exactly: the command is always available via M-x, and it would be
available via D were the minor mode turned off.

 > But if so, currently overridden bindings should be flagged as such,
 > IMHO.)

-- 
Kevin Rodgers