From: Glenn Morris <rgm@gnu.org>
To: Chong Yidong <cyd@gnu.org>
Cc: 10650@debbugs.gnu.org
Subject: bug#10650: view-mode inconsistencies wrt special mode-class
Date: Wed, 01 Feb 2012 12:15:12 -0500 [thread overview]
Message-ID: <cjehuewk4f.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <v87h09r25v.fsf@fencepost.gnu.org>
Chong Yidong wrote:
> I changed view-buffer-other-* to behave like view-buffer.
> (Could have changed view-mode-enter instead, but that is called from
> other placed in Emacs so it didn't seem worth the risk.)
Probably not for 24.1 indeed, but the first usage I looked at is in
files.el and it duplicates the same logic wrt mode-class:
(when (and buffer-read-only
view-read-only
(not (eq (get major-mode 'mode-class) 'special)))
(view-mode-enter))
I'd guess (with no data) that most of the other callers either use
something similar, should use something similar but did not think of it,
or would not be affected if something similar were added.
next prev parent reply other threads:[~2012-02-01 17:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 9:05 bug#10650: view-mode inconsistencies wrt special mode-class Glenn Morris
2012-01-30 20:10 ` Glenn Morris
2012-01-30 23:29 ` Juri Linkov
2012-01-31 0:38 ` Glenn Morris
2012-01-31 1:49 ` Stefan Monnier
2012-01-31 2:50 ` Glenn Morris
2012-01-31 6:17 ` Chong Yidong
2012-01-31 17:37 ` Stefan Monnier
2012-02-01 7:38 ` Glenn Morris
2012-02-01 8:32 ` Chong Yidong
2012-02-01 17:15 ` Glenn Morris [this message]
2012-02-01 14:31 ` Stefan Monnier
2012-02-01 17:12 ` Glenn Morris
2012-02-02 0:40 ` Juri Linkov
2012-02-02 18:49 ` Stefan Monnier
2012-02-02 20:03 ` Glenn Morris
2012-02-02 21:11 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cjehuewk4f.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=10650@debbugs.gnu.org \
--cc=cyd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).