* bug#7166: browse-url truncates the given url after an '&'
@ 2010-10-06 13:26 Ken Hori
2010-10-06 17:32 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Ken Hori @ 2010-10-06 13:26 UTC (permalink / raw)
To: 7166
Observed emacs-version:
GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
of 2010-10-06
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7166: browse-url truncates the given url after an '&'
2010-10-06 13:26 bug#7166: browse-url truncates the given url after an '&' Ken Hori
@ 2010-10-06 17:32 ` Glenn Morris
2010-10-07 5:36 ` Ken Hori
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2010-10-06 17:32 UTC (permalink / raw)
To: Ken Hori; +Cc: 7166
Ken Hori wrote:
> Observed emacs-version:
> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
> of 2010-10-06
Please. Give. Details.
emacs -Q
(browse-url "http://www.google.com/search?hl=en&q=emacs&lr=lang_en")
works for me in 23.2 and the current trunk.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7166: browse-url truncates the given url after an '&'
2010-10-06 17:32 ` Glenn Morris
@ 2010-10-07 5:36 ` Ken Hori
2010-10-07 18:11 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Ken Hori @ 2010-10-07 5:36 UTC (permalink / raw)
To: Glenn Morris; +Cc: 7166
Details:
$ ./src/emacs -Q
(browse-url "http://www.google.com/search?hl=en&lr=lang_en&q=emacs")
=> 0
After you evaluate it, you'll get redirected to
http://www.google.com/webhp?hl=en on your primary browser because, I assume,
the original URI was somehow truncated or modified (haven't verified which).
If you type in http://www.google.com/search?hl=en&lr=lang_en&q=emacs manually,
you'll get the expected SRP.
VERSION:
GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
of 2010-10-06
On Wed, Oct 6, 2010 at 10:32 AM, Glenn Morris <rgm@gnu.org> wrote:
> Ken Hori wrote:
>
>> Observed emacs-version:
>> GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
>> of 2010-10-06
>
> Please. Give. Details.
>
> emacs -Q
> (browse-url "http://www.google.com/search?hl=en&q=emacs&lr=lang_en")
>
> works for me in 23.2 and the current trunk.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7166: browse-url truncates the given url after an '&'
2010-10-07 5:36 ` Ken Hori
@ 2010-10-07 18:11 ` Glenn Morris
2010-10-07 18:35 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2010-10-07 18:11 UTC (permalink / raw)
To: Ken Hori; +Cc: 7166
Ken Hori wrote:
> $ ./src/emacs -Q
>
> (browse-url "http://www.google.com/search?hl=en&lr=lang_en&q=emacs")
Works for me.
By experiment, this is a bug in browse-url-xdg-open, which I don't use.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7166: browse-url truncates the given url after an '&'
2010-10-07 18:11 ` Glenn Morris
@ 2010-10-07 18:35 ` Glenn Morris
2010-10-08 4:21 ` Ken Hori
2010-10-08 17:24 ` Andreas Schwab
0 siblings, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2010-10-07 18:35 UTC (permalink / raw)
To: Ken Hori, 7166, Jan Dj�rv
I guess this might fix it:
*** lisp/net/browse-url.el 2010-09-23 06:42:45 +0000
--- lisp/net/browse-url.el 2010-10-07 18:28:31 +0000
***************
*** 939,945 ****
(interactive (browse-url-interactive-arg "URL: "))
(call-process "/bin/sh" nil nil nil
"-c"
! (concat "nohup xdg-open " url
">/dev/null 2>&1 </dev/null")))
;;;###autoload
--- 939,945 ----
(interactive (browse-url-interactive-arg "URL: "))
(call-process "/bin/sh" nil nil nil
"-c"
! (concat "nohup xdg-open " (shell-quote-argument url)
">/dev/null 2>&1 </dev/null")))
;;;###autoload
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#7166: browse-url truncates the given url after an '&'
2010-10-07 18:35 ` Glenn Morris
@ 2010-10-08 4:21 ` Ken Hori
2010-10-08 17:24 ` Andreas Schwab
1 sibling, 0 replies; 7+ messages in thread
From: Ken Hori @ 2010-10-08 4:21 UTC (permalink / raw)
To: Glenn Morris; +Cc: 7166
The diff did it. Thanks for the fix.
On Thu, Oct 7, 2010 at 11:35 AM, Glenn Morris <rgm@gnu.org> wrote:
>
> I guess this might fix it:
>
> *** lisp/net/browse-url.el 2010-09-23 06:42:45 +0000
> --- lisp/net/browse-url.el 2010-10-07 18:28:31 +0000
> ***************
> *** 939,945 ****
> (interactive (browse-url-interactive-arg "URL: "))
> (call-process "/bin/sh" nil nil nil
> "-c"
> ! (concat "nohup xdg-open " url
> ">/dev/null 2>&1 </dev/null")))
>
> ;;;###autoload
> --- 939,945 ----
> (interactive (browse-url-interactive-arg "URL: "))
> (call-process "/bin/sh" nil nil nil
> "-c"
> ! (concat "nohup xdg-open " (shell-quote-argument url)
> ">/dev/null 2>&1 </dev/null")))
>
> ;;;###autoload
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#7166: browse-url truncates the given url after an '&'
2010-10-07 18:35 ` Glenn Morris
2010-10-08 4:21 ` Ken Hori
@ 2010-10-08 17:24 ` Andreas Schwab
1 sibling, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2010-10-08 17:24 UTC (permalink / raw)
To: Glenn Morris; +Cc: 7166
Glenn Morris <rgm@gnu.org> writes:
> I guess this might fix it:
>
> *** lisp/net/browse-url.el 2010-09-23 06:42:45 +0000
> --- lisp/net/browse-url.el 2010-10-07 18:28:31 +0000
> ***************
> *** 939,945 ****
> (interactive (browse-url-interactive-arg "URL: "))
> (call-process "/bin/sh" nil nil nil
> "-c"
> ! (concat "nohup xdg-open " url
> ">/dev/null 2>&1 </dev/null")))
>
> ;;;###autoload
> --- 939,945 ----
> (interactive (browse-url-interactive-arg "URL: "))
> (call-process "/bin/sh" nil nil nil
> "-c"
> ! (concat "nohup xdg-open " (shell-quote-argument url)
> ">/dev/null 2>&1 </dev/null")))
>
> ;;;###autoload
The use of /bin/sh is completely unnecessary. The nil for infile and
buffer are already equivalent to the explicit redirections.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-10-08 17:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-06 13:26 bug#7166: browse-url truncates the given url after an '&' Ken Hori
2010-10-06 17:32 ` Glenn Morris
2010-10-07 5:36 ` Ken Hori
2010-10-07 18:11 ` Glenn Morris
2010-10-07 18:35 ` Glenn Morris
2010-10-08 4:21 ` Ken Hori
2010-10-08 17:24 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).