From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61340: 29.0.60; Extra space in xref buffer Date: Wed, 8 Feb 2023 17:14:05 +0200 Message-ID: References: <868rh9zzws.fsf@mail.linkov.net> <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> <86r0v0zk1o.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61340@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 16:15:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPmA8-0009Uy-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 16:15:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPmA3-0003eV-GD; Wed, 08 Feb 2023 10:15:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPmA2-0003eM-7J for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 10:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPmA1-0006yA-SD for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 10:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPmA1-0002qW-NB for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 10:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 15:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61340 X-GNU-PR-Package: emacs Original-Received: via spool by 61340-submit@debbugs.gnu.org id=B61340.167586925610869 (code B ref 61340); Wed, 08 Feb 2023 15:15:01 +0000 Original-Received: (at 61340) by debbugs.gnu.org; 8 Feb 2023 15:14:16 +0000 Original-Received: from localhost ([127.0.0.1]:56324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPm9H-0002pF-Qk for submit@debbugs.gnu.org; Wed, 08 Feb 2023 10:14:16 -0500 Original-Received: from mail-ej1-f53.google.com ([209.85.218.53]:41527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPm9F-0002p0-Q9 for 61340@debbugs.gnu.org; Wed, 08 Feb 2023 10:14:14 -0500 Original-Received: by mail-ej1-f53.google.com with SMTP id m2so51985317ejb.8 for <61340@debbugs.gnu.org>; Wed, 08 Feb 2023 07:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=a4vKAXksGITBS0CiSFCMlo7eEJrURRreor2NLyWD5jg=; b=cmZ3d1aJ/g0ioPm+uMjM2lbKv61n+PkJekJcYmlPhPK1o2z1P+hwgWmom0mud7P8Y8 WQiC1+7rqWHE83rAu5z0JNRx0m9JJyD+ef0rrSb2Uxuo5aGrVTZi6hMUj/c8m6bSa0GE kuWGa1KAyIQXJiRLWRWFwMiW2eSVCnENhnzlSQ0gtkWrDcfXcSYy1/ZjkOcEMjMJiCkN zxjE+VTXgDSS2QCV6Yu4tTC3dBT3zZYvwU0aTwEHG145RipX10zTYD6V+rMCBCVyHLrE KcgnHFX2arcP6knEDc7pTCy3ODfQaf0yviH+fuelRorTeeaHgXjFnIIt4Eqz+laK719c LMuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a4vKAXksGITBS0CiSFCMlo7eEJrURRreor2NLyWD5jg=; b=dZ/bwJiCqG/6bCLcaBnZhMXQte0cLRpG1q2jyT0DSfm6Qw0UxDL9lJuGoKiy5rJ9jo MG6Wj9PB0eISNAVYZ0R019snzvFb4DhzsBoBoAiOZWpJYn5R+X/il4Am5Sz73VGKGHg9 AdkybkXAVevdJF0t3ek1LREeMtYv9xGWZ2K+S99ZMtIZYQMODxmQlFiRfBYdboScesSG iLHx8IOx516Ia3nZiv/qfKUV8ByXMkTwgr56VmYhGr1gBWirdKTSpPq/XoiMlSRjKopC BN5yKh6WCwWhZgcDVckp6YvcgpsMN2lmS0sBF/K2XI1wxof9ufUaBEHOnhopZGNSOtkI nDvg== X-Gm-Message-State: AO0yUKWw0Xzrw8WojyJPxYPI32PfhnFmHKKRyTVgs1ZulccJXZrpzpTt sAnHbOtsalw4u5q1J126n8k= X-Google-Smtp-Source: AK7set8JOMTWa9kgYVD8mFDzIZVgt9nCScm8ELxzuj9e/86MJvIhFudv4SurJDrseOP+44QG/hneZg== X-Received: by 2002:a17:907:2142:b0:888:7d50:33b4 with SMTP id rk2-20020a170907214200b008887d5033b4mr8086854ejb.34.1675869247871; Wed, 08 Feb 2023 07:14:07 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id y19-20020a17090668d300b00880d9530761sm8389938ejr.209.2023.02.08.07.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 07:14:07 -0800 (PST) Content-Language: en-US In-Reply-To: <86r0v0zk1o.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255143 Archived-At: On 08/02/2023 09:35, Juri Linkov wrote: > close 61340 30.0.50 > thanks > >>> @@ -1108,7 +1108,7 @@ xref--insert-xrefs >>> maximize (xref-location-line >>> (xref-item-location xref))) >>> for line-format = (and max-line >>> - (format "%%%dd: " (1+ (floor (log max-line 10))))) >>> + (format "%%%dd:" (1+ (floor (log max-line 10))))) >>> with item-text-props = (list 'mouse-face 'highlight >>> 'keymap xref--button-map >>> 'help-echo >>> ``` >> This was originally an effort to give the outputted text some "breathing >> room", and I think it looks a little better. > Indeed, it looks better but unfortunately at the cost of caused ambiguity. > I guess this is the reason why Grep and Occur don't add space. > I suppose we could try to tone down the colon. Occur uses 'shadow' for both the number and the colon; Grep uses the color from 'default' (with an underline). If we fontify it with 'shadow' rather than 'xref-line-number', that might look a little better.