From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Date: Sun, 15 May 2016 13:08:21 -0400 Message-ID: References: <83futj5mcl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1463332204 486 80.91.229.3 (15 May 2016 17:10:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 May 2016 17:10:04 +0000 (UTC) Cc: 23540@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 15 19:09:54 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b1zXx-0005ee-NP for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 19:09:41 +0200 Original-Received: from localhost ([::1]:40958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1zXx-0007v3-36 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 13:09:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1zXR-0006Z0-MW for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 13:09:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1zXL-0006zH-KA for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 13:09:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1zXL-0006zD-H1 for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 13:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b1zXL-0003Ux-EA for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 13:09:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 May 2016 17:09:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23540 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23540-submit@debbugs.gnu.org id=B23540.146333211613390 (code B ref 23540); Sun, 15 May 2016 17:09:03 +0000 Original-Received: (at 23540) by debbugs.gnu.org; 15 May 2016 17:08:36 +0000 Original-Received: from localhost ([127.0.0.1]:52954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1zWt-0003Tu-OT for submit@debbugs.gnu.org; Sun, 15 May 2016 13:08:35 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:36068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1zWq-0003TY-Tu for 23540@debbugs.gnu.org; Sun, 15 May 2016 13:08:33 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4FH8OVA022085; Sun, 15 May 2016 13:08:24 -0400 Original-Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4FH8Ll6029069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 15 May 2016 13:08:22 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 In-Reply-To: <83futj5mcl.fsf@gnu.org> X-PMX-Cornell-Gauge: Gauge=XXXXX X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118265 Archived-At: On 5/15/2016 12:15 PM, Eli Zaretskii wrote: >> From: Ken Brown >> The error is generated by >> Ffind_operation_coding_system when it is called by >> >> CALLN (Ffind_operation_coding_system, >> Qopen_network_stream, name, p->buffer, >> host, service) >> >> in set_network_socket_coding_system. > > Ffind_operation_coding_system includes an explicit test for the 4th > argument to be an integer: > > if (!(STRINGP (target) > || (EQ (operation, Qinsert_file_contents) && CONSP (target) > && STRINGP (XCAR (target)) && BUFFERP (XCDR (target))) > || (EQ (operation, Qopen_network_stream) && INTEGERP (target)))) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > error ("Invalid argument %"pI"d of operation `%s'", > XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation))); > > This should obviously be augmented, now that the value can also be t. Presumably the documentation of open-network-stream should also be updated to reflect this. I hesitate to do this myself without knowing for sure that t is an acceptable value for all calls to open-network-stream. I'd rather leave it for someone more familiar with the code, like Lars. Ken