From: Cecilio Pardo <cpardo@imayhem.com>
To: 73258@debbugs.gnu.org
Subject: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken
Date: Sat, 14 Sep 2024 21:33:00 +0200 [thread overview]
Message-ID: <ce2f5d58-3849-4074-9fcc-606c69044de5@imayhem.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
dnd-handle-multiple-urls is called once for each file. This brings
problems, such that when dropping two directories, emacs open the first
one on dired, then tries to copy the contents of the second to the
first. The attached patch fixes this. -- Cecilio Pardo
[-- Attachment #2: patch.diff --]
[-- Type: text/plain, Size: 1677 bytes --]
diff --git a/lisp/term/w32-win.el b/lisp/term/w32-win.el
index 3c0acf368f4..29629c9072c 100644
--- a/lisp/term/w32-win.el
+++ b/lisp/term/w32-win.el
@@ -100,7 +100,7 @@ w32-color-map
;; (interactive "e")
;; (princ event))
-(defun w32-handle-dropped-file (window file-name)
+(defun w32-dropped-file-to-url (file-name)
(let ((f (if (eq system-type 'cygwin)
(cygwin-convert-file-name-from-windows file-name t)
(subst-char-in-string ?\\ ?/ file-name)))
@@ -117,14 +117,12 @@ w32-handle-dropped-file
(split-string (encode-coding-string f coding)
"/")
"/")))
- ;; FIXME: is the W32 build capable only of receiving a single file
- ;; from each drop?
- (dnd-handle-multiple-urls window (list (concat
- (if (eq system-type 'cygwin)
- "file://"
- "file:")
- file-name))
- 'private))
+
+ (concat
+ (if (eq system-type 'cygwin)
+ "file://"
+ "file:")
+ file-name))
(defun w32-drag-n-drop (event &optional new-frame)
"Edit the files listed in the drag-n-drop EVENT.
@@ -146,8 +144,11 @@ w32-drag-n-drop
(raise-frame)
(setq window (selected-window))
- (mapc (apply-partially #'w32-handle-dropped-file window)
- (car (cdr (cdr event)))))))
+ (dnd-handle-multiple-urls
+ window
+ (mapcar #'w32-dropped-file-to-url
+ (car (cdr (cdr event))))
+ 'private))))
(defun w32-drag-n-drop-other-frame (event)
"Edit the files listed in the drag-n-drop EVENT, in other frames.
next reply other threads:[~2024-09-14 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 19:33 Cecilio Pardo [this message]
2024-09-15 8:25 ` bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken Eli Zaretskii
2024-09-15 19:22 ` Cecilio Pardo
2024-09-20 11:20 ` Cecilio Pardo
2024-09-20 13:26 ` Eli Zaretskii
2024-09-21 10:11 ` Eli Zaretskii
2024-09-21 13:41 ` Cecilio Pardo
2024-09-22 9:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2f5d58-3849-4074-9fcc-606c69044de5@imayhem.com \
--to=cpardo@imayhem.com \
--cc=73258@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).