unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Raoul Comninos <revcomninos@gmail.com>, 65110-done@debbugs.gnu.org
Subject: bug#65110: eshell variable triggers error
Date: Mon, 7 Aug 2023 19:41:35 -0700	[thread overview]
Message-ID: <cda147b1-4393-5244-2c4a-9807e6a2626f@gmail.com> (raw)
In-Reply-To: <5f01c663-9aa7-f83b-d91e-27bc0288b3e4@gmail.com>

On 8/6/2023 1:44 PM, Jim Porter wrote:
> Happily, this issue *wasn't* a bug in the I/O refcounting code. The 
> failed assertion (which is new in Emacs 30 and exists for exactly this 
> reason) just revealed a bug in another part of Eshell. Fix attached 
> (plus fixing another issue mentioned in the code comments) with some 
> regression tests.
> 
> Let me know if this works for you, or if you see any further issues.

After discussing this off-list, this looks good (thanks for testing!). 
Merged to master as 301e6a747ac, and closing this now.





      reply	other threads:[~2023-08-08  2:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06  8:51 bug#65110: eshell variable triggers error Raoul Comninos
2023-08-06 19:20 ` Jim Porter
2023-08-06 20:44   ` Jim Porter
2023-08-08  2:41     ` Jim Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cda147b1-4393-5244-2c4a-9807e6a2626f@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=65110-done@debbugs.gnu.org \
    --cc=revcomninos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).