From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Thu, 5 Dec 2024 20:08:09 +0200 Message-ID: References: <871pzbj8mq.fsf@mail.linkov.net> <87sernhxoa.fsf@mail.linkov.net> <1d08c589-2d0e-4f10-8c2e-e21c206ac118@gmx.at> <78a96965-31c1-4688-b808-2de09d1832c4@gmx.at> <878qt9pz4w.fsf@mail.linkov.net> <05452bef-dd2e-4e93-abdd-6eb391027197@gmx.at> <87y118cyyk.fsf@mail.linkov.net> <871pyzp6br.fsf@mail.linkov.net> <25443bb1-788a-4f06-9350-5d2c666f6795@gmx.at> <32b8cc56-afa1-40f6-933f-6de0df2b9f63@gutov.dev> <688d5119-0900-46a4-86c7-32a9b06cc349@gmx.at> <87ed2v1aec.fsf@mail.linkov.net> <19124901-e749-4daa-bf47-27e12ea619aa@gutov.dev> <87mshbj4lk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10275"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: martin rudalics , 74361@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 19:09:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJGIL-0002WW-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 19:09:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJGHz-0001NX-Pb; Thu, 05 Dec 2024 13:09:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJGHj-0001Me-6y for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 13:09:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJGHe-0000hK-75 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 13:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=xKtYt2jUleAPzT/FRAAtJQlPx2keysu+H1EAXyUq/i4=; b=vbDOgOpLGhas+4m/A8DrlQHP2X7HYUobsOX9ewHVulxqdlr1P9MPBzgdH5WERLDz1Uw541+iNVjemMYIZO/K+uL1pgGE9NnQ8jbZ86EZMRECTvdaTvfQ1wVQfVfmGdHr7XXK3yukDZU1yEl0cEFW137zsWURhO40Oe9twdB6C0F8Ax2jZAh87LPCmmv67BBhaKYXY2T4GJEYOMoSiehaaT3Hb5bAplaVBDJLGrAR4aJ1b+dsLBao/Uw+Ts9QrgSvuroJOPkfsaIf5RMlTFKSoxqdNO0CkJyIJKqcO7Uwco2phjJ4m3YSIrsof7MmF6Hw3+95y+rIYFbxX6+E1iGsrw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJGHe-0002jj-2V for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 13:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173342210110446 (code B ref 74361); Thu, 05 Dec 2024 18:09:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 5 Dec 2024 18:08:21 +0000 Original-Received: from localhost ([127.0.0.1]:40709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJGGz-0002iQ-GZ for submit@debbugs.gnu.org; Thu, 05 Dec 2024 13:08:21 -0500 Original-Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:54589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJGGw-0002i6-NO for 74361@debbugs.gnu.org; Thu, 05 Dec 2024 13:08:19 -0500 Original-Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 4F2B11382041; Thu, 5 Dec 2024 13:08:13 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Thu, 05 Dec 2024 13:08:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733422093; x=1733508493; bh=xKtYt2jUleAPzT/FRAAtJQlPx2keysu+H1EAXyUq/i4=; b= M9RGlqDoNXZ5Ei86mDw69pGZk42N4YAuO7u9sa673n2f+RlLvr3/be/mjHZow4Ek e5CfGE1l49goaSWhG91YCsbndHFmIwZlNN8V/zaFmqD238q2p2YGF8zZCe5XE1LV 6ZZbLrJafU2BRO8nVNncxUxMid2dEOJLwwVxL+yQeYPmVV6o1AQW2ijy6ZXBLBNr P/DiPvOCwSw8x5UlVOvnNoAhst7sSvKWHbSP0Bj/6l9vhEsT1ftgby/owGU214o8 CxBAFgtQvYAI/u7lWFhDkwieAGe2QoK/uAHB8tujZ8bIiqgwJ4PpFt5U7KOyMBm6 jt4NSVYbGj4uM7+RUiew1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733422093; x= 1733508493; bh=xKtYt2jUleAPzT/FRAAtJQlPx2keysu+H1EAXyUq/i4=; b=Y JTirqRgXrV3pKi3hm6wzqhGqnDk2YmR2lDC2+Qxa4W9zhAE4rMJx0npjRBaTV8cP hGeXj/fkfe2B+IANZUMAJPlKtSZTg+mWbYPo2gjCg9gxc5kOpwjisPjOuxMFeOFU 7Y/8Y8rqD9QGzZX5p+Nq0uC/RpDF6Idi8xhqb3xsEUknPbW5EEobRC0DMoLvSjIj WIUREuon9UXcXQjrdA7naIVNJY0mhaM9bnBcKLDzG4Z7LIhFJHegmdV8/8rDiND3 d+1sMIJsHQHLnvgbevbUHO7jht5iNYYllK4x4lzwLeqpCdNRLfAaGTowRi/hoB4u 0o67oaYyZ16s6oe0K5aHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrieejgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjuhhriheslhhinhhkohhvrd hnvghtpdhrtghpthhtoheprhhuuggrlhhitghssehgmhigrdgrthdprhgtphhtthhopeej geefieduseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Dec 2024 13:08:11 -0500 (EST) Content-Language: en-US In-Reply-To: <87mshbj4lk.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296480 Archived-At: On 04/12/2024 09:35, Juri Linkov wrote: >> The replacement for xref--display-buffer-in-window seems easier to do, >> IIUC this keeps all the current behavior (but it's also Emacs 31+ only): >> >> @@ -690,9 +690,9 @@ xref--show-pos-in-buf >> (window-live-p xref--original-window) >> (or (not (window-dedicated-p xref--original-window)) >> (eq (window-buffer xref--original-window) buf))) >> - `((xref--display-buffer-in-window) >> + `((display-buffer-use-some-window) >> (category . xref-jump) >> - (window . ,xref--original-window))) >> + (some-window . ,(cl-constantly xref--original-window)))) > I see no problems with this patch. Even better would be if Martin agrees > to modify 'display-buffer-use-some-window' to accept a window in > '(some-window . WINDOW)'. Thanks. In any case, like with some other changes, we should probably wait one-two Emacs releases before installing. Or organize it as backward-compatible dispatch along two paths, which unfortunately doesn't make things simpler in the short run.