From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24082: [PATCH] Use =?UTF-8?Q?=E2=80=98cvs_?= =?UTF-8?Q?update=E2=80=99?= instead =?UTF-8?Q?=E2=80=98cvs_?= =?UTF-8?Q?status=E2=80=99?= for CVS *vc-dir* buffers Date: Fri, 7 Oct 2016 02:25:24 +0300 Message-ID: References: <874m7crwv4.fsf@xi.bootis> <874m64wsui.fsf@xi.bootis> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475796393 18412 195.159.176.226 (6 Oct 2016 23:26:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2016 23:26:33 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Thunderbird/49.0 To: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp , 24082@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 07 01:26:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsI3N-0002v0-12 for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Oct 2016 01:26:17 +0200 Original-Received: from localhost ([::1]:59787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsI3L-0003H0-J5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Oct 2016 19:26:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsI3D-0003Gk-Ja for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2016 19:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsI38-0001Ku-HE for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2016 19:26:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsI38-0001Kl-Dp for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2016 19:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bsI38-0001qh-88 for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2016 19:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2016 23:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24082-submit@debbugs.gnu.org id=B24082.14757963357052 (code B ref 24082); Thu, 06 Oct 2016 23:26:02 +0000 Original-Received: (at 24082) by debbugs.gnu.org; 6 Oct 2016 23:25:35 +0000 Original-Received: from localhost ([127.0.0.1]:47028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsI2h-0001pg-KL for submit@debbugs.gnu.org; Thu, 06 Oct 2016 19:25:35 -0400 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:37540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsI2f-0001pO-8t for 24082@debbugs.gnu.org; Thu, 06 Oct 2016 19:25:33 -0400 Original-Received: by mail-wm0-f44.google.com with SMTP id b201so2452565wmb.0 for <24082@debbugs.gnu.org>; Thu, 06 Oct 2016 16:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=tEfxgljvZ+Ccnn2gbQkwuE/6aIXaZmcXnvGoUgNKz1A=; b=C100bGUDiKRw2Ve9q8LK+jqe7rccciue/UQiTiWAZpVjCVWHsRjfcYAEe/mXuJdvpz yd6XNBuvqyaV+Zh9zLboHD7orb1/wDbv3wO8KA9CiJcG+++snBdCs3oeDUbWb2tL+zS/ 1XnYf5FVXBxxHmrYcgcSscHmCdwv2TCHgp6eV3vWtVhkIAXIzc105eC7MM54/dgslsFQ 6F+lsy/URCe2Hr9ASd7SjvYAFmfBtAzXX5eXmMJEYwiZPc+NdJPLl0xyE5bhkR2PLKE8 QUqUnCVgV7Lv2m4KnF4vYzSmZciGNR86ZbtraZAXf048yjb4oSkbO2qnWDjpXpxJZPUS qJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=tEfxgljvZ+Ccnn2gbQkwuE/6aIXaZmcXnvGoUgNKz1A=; b=h/mWl+sx9FraI6/LAOAyIrLLRuB0pMHceKjI1VFYmrtEcNvJO2Ft9y6Zy69Dzjak+m xJkQR6turKI0DoNio6zgKPyxiyUR12rdky6ajQ/LubX9ZHK/rpKAIFykqXsgjZlOa80q 6LgJNRfuU6CvSCK1WqxXYRfT9e3Vx7+SDRRMAGgTWbI2fKIJvGfzqZU4PR+fovXPaL6S w7lmRZiz5uapGnsvtWRq9dkBgn/+v4NWbJR9V9pZAYmWrdXKSm+dg+JG7zRVIWIBV7KG zr/BED7Iq1wviyW6cnJe0UEdk1yYOWjS/1j9y77S7dQblq9j0jzk6e1jT2P3DOuWyG1r SYCw== X-Gm-Message-State: AA6/9RlTCN+ir3ncUwo0bGFFvW+ATzmFrT9uLiZoR90PFkEOYBYtRz6Y4w/B1uT9Tk2WKA== X-Received: by 10.28.142.14 with SMTP id q14mr10012823wmd.87.1475796327446; Thu, 06 Oct 2016 16:25:27 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.103]) by smtp.googlemail.com with ESMTPSA id n131sm170380wmd.3.2016.10.06.16.25.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 16:25:26 -0700 (PDT) In-Reply-To: <874m64wsui.fsf@xi.bootis> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124134 Archived-At: Hi! Sorry for the long wait. On 28.08.2016 23:17, Göktuğ Kayaalp wrote: > Hi, attached is a patch that fixes bug#24082. Could you help me reproduce the issue locally first? Either by pointing to a publicly available CVS repo with submodules, or by providing a sequence of commands that would create such repo locally (we do something like that in vc-tests.el). > The reason of the bug was that, in function ‘vc-cvs-after-dir-status’, > the CVS status line ‘cvs status: Examining ’ was excluded when the > function narrows to match, and when it tries to set the local variable > ‘subdir’, as it does not find this line, it skips setting it. As > ‘subdir’ defaults to ‘default-directory’, which is previously set to > repo root (i.e. the argument to function ‘vc-dir’, when ‘subdir’ is used > to construct the relative path to file, concatenating it with the > already-known file base name, it returns the basename, i.e. in > the form ‘name.ext’, with no directory path. This because it constructs > the relative path like ‘(file-relative-name basename subdir)’. Could we just fix that, to address this specific bug? > The patch uses ‘cvs update’ command instead. The implementation was > already there, commented out. I enabled and corrected it. The result > is more correct than the ‘cvs status’ approach, i.e. includes > unregistered and missing, and is faster compared to ‘cvs status’ way. If that change is mostly unrelated to the reported bug, could you send it as two separate patches? Further, do you have any inkling why the 'cvs update' implementation was commented out? Did it require a particular recent version of CVS, maybe? We can ask Dan if you don't.