From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#54025: 27.2; dired-do-find-regexp skips occurences Date: Sat, 26 Feb 2022 02:28:49 +0200 Message-ID: References: <611521ae-42d4-6584-915e-243060de536e@yandex.ru> <831qzwx5a6.fsf@gnu.org> <967624c188c942ff8ecbf23bd6be46d0@pay-lab.ru> <0239f68191344ab49b23ddc96c7bd6e9@pay-lab.ru> <8017fbd711264d36ba69b62c480a55c6@pay-lab.ru> <7f544a39-e32d-2d62-4db8-dc957d243aec@yandex.ru> <87fso7mkj0.fsf@gmx.de> <274c3d9c-205d-be47-1bc6-1aeeacd659e8@yandex.ru> <8735k7m1ez.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: "54025@debbugs.gnu.org" <54025@debbugs.gnu.org>, =?UTF-8?Q?=D0=9F=D0=B5=D1=82=D1=80=D0=BE=D0=B2_?= =?UTF-8?Q?=D0=90=D0=BD=D0=B4=D1=80=D0=B5=D0=B9?= To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 26 01:29:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNkyA-0008CM-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Feb 2022 01:29:54 +0100 Original-Received: from localhost ([::1]:41494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNky9-0005SN-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 19:29:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNkxS-00053u-Ri for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 19:29:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNkxK-000237-7f for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 19:29:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNkxK-000702-4m for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 19:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Feb 2022 00:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54025 X-GNU-PR-Package: emacs Original-Received: via spool by 54025-submit@debbugs.gnu.org id=B54025.164583534026898 (code B ref 54025); Sat, 26 Feb 2022 00:29:02 +0000 Original-Received: (at 54025) by debbugs.gnu.org; 26 Feb 2022 00:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNkxH-0006zm-SD for submit@debbugs.gnu.org; Fri, 25 Feb 2022 19:29:00 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:37704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNkxF-0006zY-Tz for 54025@debbugs.gnu.org; Fri, 25 Feb 2022 19:28:58 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id d28so6735123wra.4 for <54025@debbugs.gnu.org>; Fri, 25 Feb 2022 16:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hzxo4RwMhnVPC0DL4Ae+iRvDX0yaLTgCb//qV34Q3eU=; b=B4WXcU8arFm3PPPcZ6LUT3wL/z++ttcnZyYPcEj+O1uZbrSG4wwrgEVodUR2rEaabc EXF+wM4BKWBQt3OvEuTrg1V6Q+YrViMY7ZeHnmdsqqVtXqtg46DNevXwpYURqvSosLDB IEH3lU/IoVYhxA5D6HEgxvhZ+UspU14a96etaj7g0IngdkY6k1DZgkw1uy6v8EoxM9vm TGdLfxRWOcUTygxvD2duFt2fzJw/B5hhGebF9OSeZzwrkt2oPGBh3P/Wz+QaAx4CLO6b mZd6+f+bZ7G43wXnZNna07pMBdSQBzcIUv1lg5zwhSDIB3SLMZXtu7uy4EFtGnfiIte6 rZfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hzxo4RwMhnVPC0DL4Ae+iRvDX0yaLTgCb//qV34Q3eU=; b=7dcHL00nqK/2W0mwTadEG8Kprw7lmsHAHLuvm/QQ1oXVz3+i6xBP1hSaInGTa3cfH7 E41nQHeGyqgQai0S6ZdFTOqb/XYeZxslGwPD+B1huRIbsl7q+NuAIuFoyBL5nR6u7RKY o2sPYE7ZtZRXV2E41GoMcdwpfVFjoi7qkBxAIvjVCLUoTpOtr+obaf/Zi3coL5J8J8Mz p0dBf1Q/X59Tqv5cWlTxpxaCJYx/eQAv1YBY82Y9UoAKlNSSo1mD7zn93YVaiBPKckjJ hGaTrSUqrNrKzjM8IDZvNxC/JDIw4ahDpdwceFThBxGD0xG6/mWQCYAzicnpIaCYjgF8 Kbsw== X-Gm-Message-State: AOAM531kfUs67t730oIduQRB5drOnB65nmkdxg4LAXI9DYFWBcdz02k6 3M0X9m5ZFyVA7jFPIj0UzQI= X-Google-Smtp-Source: ABdhPJwhbyuKmYqO9GtqSt5Bi1E8df+jAXS9o8gUSsBGvBd5mRUi+7mquQRCsosXZHmrtRjqhDBkZQ== X-Received: by 2002:a5d:6c6b:0:b0:1ea:77ea:dde8 with SMTP id r11-20020a5d6c6b000000b001ea77eadde8mr7870275wrz.690.1645835331931; Fri, 25 Feb 2022 16:28:51 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z2-20020a056000110200b001e7140ddb44sm3357719wrw.49.2022.02.25.16.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 16:28:51 -0800 (PST) Content-Language: en-US In-Reply-To: <8735k7m1ez.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227660 Archived-At: Hi Michael, On 25.02.2022 17:05, Michael Albinus wrote: >> On 25.02.2022 10:13, Michael Albinus wrote: >>> Tramp does not use caches when computing >>> verify-visited-file-modtime. Let's see how it goes. >> >> I certainly hope that it doesn't invoke a remote call every time this >> function is called (when called locally, it hits the disk). > > verify-visited-file-modtime needs to read the file-attributes. That's > the idea of this function. IIUC Tramp caches some information about files, and flushes those cashes after "destructive" operations. "Last modification time" could reside in such a cache. > Yes, every time it is called, it goes remote. Thanks for the confirmation. I guess we need to predicate that check on the file being local, because the worst-case performance in our scenario (remote system with high rtt) could be very bad. We might even drop if later if some hdd users see a slowdown in common scenarios. It's a secondary check, after all. Commit 018eeb655a.