From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58265: 29.0.50; [PATCH] $HOME adjustment for 'ert-remote-temporary-file-directory' is wrong Date: Sun, 2 Oct 2022 18:32:32 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3A5NjpLU7KMqgqDUZrE0wqz2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14271"; mail-complaints-to="usenet@ciao.gmane.io" To: 58265@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 03 03:33:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofAKU-0003ZQ-Hk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 03:33:10 +0200 Original-Received: from localhost ([::1]:47388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofAKT-0004er-E2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 21:33:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofAKN-0004eS-GF for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 21:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofAKM-0003Q0-PP for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 21:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofAKM-0002f6-KV for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 21:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 01:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58265 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166476076110203 (code B ref -1); Mon, 03 Oct 2022 01:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Oct 2022 01:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:48472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofAK0-0002eU-Pj for submit@debbugs.gnu.org; Sun, 02 Oct 2022 21:32:41 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofAJy-0002eM-Qs for submit@debbugs.gnu.org; Sun, 02 Oct 2022 21:32:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofAJy-0004e8-Av for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 21:32:38 -0400 Original-Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:55883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofAJw-0003O6-IN for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 21:32:38 -0400 Original-Received: by mail-pj1-x1029.google.com with SMTP id gf8so6117430pjb.5 for ; Sun, 02 Oct 2022 18:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date; bh=4efS8uROUtV3e7hxr66kL+Z0VeThICWIAdwhOfvbGTU=; b=pp6Z3XbKmTiyRLfUy6ixrBR+8/k3EBI/8L+JuDsJ9AGRMzyKJsaDyUzxgmCIrqhuLu 6AhNNb5lglXBhqpeck24gkyD8jgUG6GbOu1jeEiGwE2Drv5sMZAbuj/x2fqM8gb4lnmq md3dbxjgo93mzC9zIbTxBZwO8Pj4aSklIDoH4fbuC9k76esU415ScqdqoI7/pvE27LUO r864CuWQxJ9FHCD2bIP8Erfd1WOhwcy6ardnkAgTBeWGVlArL9reVzVeGY22vzGoMPY/ ra3isyYlqrDvYZu/rRIts4dbkZhdh/sf19ZT9slZqNg1odIvf+OQiOHDO46N6V5Km+eM VdrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4efS8uROUtV3e7hxr66kL+Z0VeThICWIAdwhOfvbGTU=; b=WWtGKDC0ygpmjAxrvI2rvNbkJdrR6xOFqC44FPRoFO36MWfpoZmO3fG0206CDam+q6 kNlA/y+XkrmOtkRdY+NFjJOWJtefeJh4ggtJiYSVy3sg85LF9J0frYrlhiz+KtnEoTFm M6a98wz/Eebrg4b4YfsLITht4UcKNcCD1ycMIzGPp/O8v3piFl9nsxYBO4jPwQUgG2qh 1LHus1S147D4kYzYm/KBGyTsW6vVD20q96GTGjF4jI8GeWW8kymoT2sKiIp/vT5bd554 flNB8naWhCuHvWLQPjlWQ/x31Vte78MA4MYx94K/oa+9JIWkVUM0GC3dE+MWqcd3IlpH H56w== X-Gm-Message-State: ACrzQf3bqSMo1+4KWo7RyAmiVVyK+N4m3MG7r9PLFnCLxjcNjzmev21m 6U/nj7aSXn+y6VTHro1Aw4K0BeFnAGo= X-Google-Smtp-Source: AMsMyM5wQaOA4XRmPA/w4kQxbp+0yXuFh/X/+J1LrQVdVuelyAFghCVAgm+B+AKkxalBhz73eSrmrg== X-Received: by 2002:a17:90b:3a8a:b0:20a:7e68:91a with SMTP id om10-20020a17090b3a8a00b0020a7e68091amr7079333pjb.206.1664760754051; Sun, 02 Oct 2022 18:32:34 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k11-20020aa7972b000000b0053818255880sm1724496pfg.193.2022.10.02.18.32.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Oct 2022 18:32:33 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244278 Archived-At: This is a multi-part message in MIME format. --------------3A5NjpLU7KMqgqDUZrE0wqz2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I tried to use 'ert-remote-temporary-file-directory' in a test for an external package, but it ended up breaking some existing tests simply by requiring both tramp and ert-x. These tests indirectly used 'cd' (by way of 'compilation-start'), which triggered the failure. Steps to reproduce: $ mkdir -p ~/src $ emacs -Q --batch -l tramp -l ert-x --eval '(cd "~/src/")' Result: Error: error ("No such directory: ~/src/") mapbacktrace(#f(compiled-function (evald func args flags) #)) debug-early-backtrace() debug-early(error (error "No such directory: ~/src/")) error("No such directory: %s" "~/src/") cd("~/src") eval((cd "~/src") t) command-line-1(("-l" "tramp" "-l" "ert-x" "--eval" "(cd \"~/src/\")")) command-line() normal-top-level() No such directory: ~/src/ Looking at ert-x.el, I think this is because 'ert-remote-temporary-file-directory' does some fixup on $HOME, but it was too aggressive. See attached. --------------3A5NjpLU7KMqgqDUZrE0wqz2 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-logic-of-HOME-adjustment-for-ert-remote-temporar.patch" Content-Disposition: attachment; filename*0="0001-Fix-logic-of-HOME-adjustment-for-ert-remote-temporar.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1ZWY5YmNlMTA2ZGJjNzhjMGUyOWIzYzBlMWJhZjBlZTQ3ODU5ZWNlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMiBPY3QgMjAyMiAxODoxOTo1NiAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIDsgRml4IGxvZ2ljIG9mICRIT01FIGFkanVzdG1lbnQgZm9yCiAnZXJ0LXJlbW90ZS10 ZW1wb3JhcnktZmlsZS1kaXJlY3RvcnknCgoqIGxpc3AvZW1hY3MtbGlzcC9lcnQteC5lbCAo ZXJ0LXJlbW90ZS10ZW1wb3JhcnktZmlsZS1kaXJlY3RvcnkpOiBPbmx5CmFkanVzdCAkSE9N RSB3aGVuIGl0IGRvZXNuJ3QgZXhpc3QuCi0tLQogbGlzcC9lbWFjcy1saXNwL2VydC14LmVs IHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2VydC14LmVsIGIvbGlzcC9lbWFjcy1s aXNwL2VydC14LmVsCmluZGV4IGJmZDc5NjU4NmQuLmE4OTFmMDY4YTcgMTAwNjQ0Ci0tLSBh L2xpc3AvZW1hY3MtbGlzcC9lcnQteC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvZXJ0LXgu ZWwKQEAgLTU2OCw3ICs1NjgsNyBAQCBlcnQtcmVtb3RlLXRlbXBvcmFyeS1maWxlLWRpcmVj dG9yeQogICAgICAgICAgYCgiXFxgbW9ja1xcJyIgbmlsICwoc3lzdGVtLW5hbWUpKSkKICAg ICAgICAgOzsgRW1hY3MncyBNYWtlZmlsZSBzZXRzICRIT01FIHRvIGEgbm9uZXhpc3RlbnQg dmFsdWUuICBOZWVkZWQKICAgICAgICAgOzsgaW4gYmF0Y2ggbW9kZSBvbmx5LCB0aGVyZWZv cmUuCi0gICAgICAgICh1bmxlc3MgKGFuZCAobnVsbCBub25pbnRlcmFjdGl2ZSkgKGZpbGUt ZGlyZWN0b3J5LXAgIn4vIikpCisgICAgICAgICh3aGVuIChhbmQgbm9uaW50ZXJhY3RpdmUg KG5vdCAoZmlsZS1kaXJlY3RvcnktcCAifi8iKSkpCiAgICAgICAgICAgKHNldGVudiAiSE9N RSIgdGVtcG9yYXJ5LWZpbGUtZGlyZWN0b3J5KSkKICAgICAgICAgKGZvcm1hdCAiL21vY2s6 OiVzIiB0ZW1wb3JhcnktZmlsZS1kaXJlY3RvcnkpKSkpCiAgICAgIlRlbXBvcmFyeSBkaXJl Y3RvcnkgZm9yIHJlbW90ZSBmaWxlIHRlc3RzLiIpCi0tIAoyLjI1LjEKCg== --------------3A5NjpLU7KMqgqDUZrE0wqz2--