From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol Date: Fri, 13 Dec 2019 12:17:06 +0200 Message-ID: References: <4c2a9d55-57d1-4c19-fe20-4ccf61d20d68@yandex.ru> <83o8weaiem.fsf@gnu.org> <4220b126-0511-d6ee-521d-d79f463ab6ee@yandex.ru> <8336dpaiee.fsf@gnu.org> <2203b03e-5558-1fe1-788a-4006602626f2@yandex.ru> <83h8248wio.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207175"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38563@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 13 11:18:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifi1X-000rmd-2R for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 11:18:15 +0100 Original-Received: from localhost ([::1]:44958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifi1V-0002qv-A2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 05:18:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37009) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifi1N-0002qQ-Eg for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 05:18:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifi1M-0001PQ-83 for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 05:18:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifi1M-0001P1-3c for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 05:18:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifi1J-0007HZ-U0 for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 05:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38563 X-GNU-PR-Package: emacs Original-Received: via spool by 38563-submit@debbugs.gnu.org id=B38563.157623223727894 (code B ref 38563); Fri, 13 Dec 2019 10:18:01 +0000 Original-Received: (at 38563) by debbugs.gnu.org; 13 Dec 2019 10:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:33056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifi0b-0007Fp-J4 for submit@debbugs.gnu.org; Fri, 13 Dec 2019 05:17:17 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:40050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifi0Z-0007Fd-AS for 38563@debbugs.gnu.org; Fri, 13 Dec 2019 05:17:15 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id t14so5939409wmi.5 for <38563@debbugs.gnu.org>; Fri, 13 Dec 2019 02:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Pglp/bmOR7szy4FovWU6+/TlP0yaR96mvge3g/EJ+GE=; b=TheaDuRQS+0ZMS/nHyLhPsim+ooEScb1YHM57bvcSoJsncN/zEFe4hPnrulrtwVY7F kLjh1WCEshld9dN9+/eHwWtPYFe4w79UdiL8JhAcFjAsjhmbrkTwW2OvGO4RuyguvGmd iJf7pSnQkJOJQGwQrmakbTHPPwsZAMD+RA4KRKI+XFdAdytsxJ6PEREKV4Uv20liE1B9 mtWxE7zrx1KIRX7JkoceqAyv1fKkNL81YglbLeiKkSWm3S8GNRRZ6Op0JmPaDNEd29Ds /dPTd5JQ7COLRaoF4yX7l/hYqhK6ZnvbVp9p4RFETK3IbKDxWXQqGCEDUeNKBuPjVFXH OFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Pglp/bmOR7szy4FovWU6+/TlP0yaR96mvge3g/EJ+GE=; b=L9/1Nw5zqqTHXi22tAEIMTVMLg4mXEPGqn9ePvr0mlnpMClng2zCnBEC/WmUGv8hJd np0CWUJpwf1SQ0tLGq1u6jJ4zdosfJgQ9MkTFWvBYWUeWnX06lWnPEyQIbJvAQMX4NTf djXhgscOLwcHCrM4DYamUmTZI94iDBE8YFF+/E3sjpNgpoRUtKqin/FLMyJx43d2UdRz 2HmzOnapIxw7xtM17i2QQNMlLo9HHu2Xi4DD/pVNSbsylKpYbZiPTWMUA6s41pbtR/sO 0ZUNSS0wFfB5Ij3o9vkilDZiL+anJkNbMwfRqLNGCFDtsOO5YITkawBkyAhspMx+V1lP ojMQ== X-Gm-Message-State: APjAAAUNQMkGcgtF4Z9YK/RpU74RggFMUEYT0josNELHSrKV5BYPJ4OS cXLDBlSMP8/ntd2OYiU/uxfLgfd5 X-Google-Smtp-Source: APXvYqyY0QeznOQam1Onw2+dXj2YJuugodH6oJxwQdMNssS8SOvu6TnWf/TT2Ati1aUUyPwaT6wL1w== X-Received: by 2002:a1c:41c4:: with SMTP id o187mr12458488wma.24.1576232228778; Fri, 13 Dec 2019 02:17:08 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id t190sm1071502wmt.44.2019.12.13.02.17.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2019 02:17:07 -0800 (PST) In-Reply-To: <83h8248wio.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173264 Archived-At: On 13.12.2019 10:22, Eli Zaretskii wrote: >> It looks fixed in the whitespace-mode example, but not in the other one. >> >> Just call M-x company-complete-common on the "Author:" line in a LogEdit >> buffer to reproduce. (I've tested common d7efe98951). > > That's not a bug: the face on that thin line on whose first character > you put the tooltip overlay has a non-nil :extend attribute, so > Company will have to explicitly say ':extend nil' in its face(s) to > countermand that. Recall that a string from a display property merges > into its face all the attributes from the "underlying" face, so with > the current :extend machinery it is no longer enough just to specify a > background color in the display string's face, as you did before. I see. But isn't the issue that the background from the underlying face is used at all, rather that it's extended? But I suppose I could add a face with ':extend nil' and use it in place of 'default' there. > Btw, if you used 'default instead of '(default), I think that would > have avoided the issue as well, because the default face gets a > special treatment in this context. I can bump the requirement to Emacs 24.4 and use add-face-text-property there (too bad for setting mouse-face only the slower function is available), but as you noted in the follow-up email, it doesn't help with the remaining example. >> By the way, I kind of wonder why the fix added more lines than it >> deleted. > > ??? I added a condition under which not to merge a face, so how can I > avoid adding a few lines? The addition is 7 lines of code, including > a small refactoring, all the rest is comments. If the issue is "whether to extend", then indeed, it makes sense, thanks. >> Before, this feature just worked. Was that simply by accident? >> Or were the changes brought in by :extend major enough? > > Previously, whether a face's background was extended to EOL was > determined only by the background color of the newline; now the > :extend attribute determines that independently of the background > color. ...but the background color is taken specifically from the face that specified :extend?