From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Wed, 10 Feb 2021 03:48:28 +0200 Message-ID: References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> <87czx9u4h9.fsf@protesilaos.com> <8735y538wi.fsf@mail.linkov.net> <875z31td8p.fsf@protesilaos.com> <871rdpt9q6.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10149"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen To: Protesilaos Stavrou , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 02:49:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9ecw-0002VM-Bo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 02:49:10 +0100 Original-Received: from localhost ([::1]:55264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ecv-0000EV-Eh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 20:49:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9eco-0000EE-0v for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9ecn-00049P-Pt for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9ecn-0003jx-Oe for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 20:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 01:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161292172114346 (code B ref 46358); Wed, 10 Feb 2021 01:49:01 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 10 Feb 2021 01:48:41 +0000 Original-Received: from localhost ([127.0.0.1]:55195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9ecS-0003jJ-PG for submit@debbugs.gnu.org; Tue, 09 Feb 2021 20:48:41 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:53832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9ecP-0003j1-Jt for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 20:48:39 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id j11so468212wmi.3 for <46358@debbugs.gnu.org>; Tue, 09 Feb 2021 17:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+r1uHITHT6HRNzvGqVye6yrsFB1Bq8xNSQ1JoKEWoy0=; b=C4+F0Lne0ZzW+YmhByuxrauBh9uOR0U6FZxHDa/BgVz7vHDihvzCjXqoD75ujPqudq IFsqEJiOPlZiI6dxz0+PZT16fSXQCZ5ekdrPTDEa7T8U+zHIV90WocpEaokuLHS7TAT6 1BswcRSEdOzL+sfCV4w2Rin9JJwpE5dDy9kQmZmUUxwyyiSTUwwDWkNJwxCqujWjfjfB MZ6Segn8+VJYksn5jzDkgjjZUkBtOl7Ubj40tM62XIQ8yFF3GGjDzWlgU/5abT4dtYI4 WENkd9LdVNaGhm2OCMiFGLUBfzsQaD9udtI3ERY3hGUVv6L5dGIkhceBEDsuRRlIjoKC 8+eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+r1uHITHT6HRNzvGqVye6yrsFB1Bq8xNSQ1JoKEWoy0=; b=iRzUUkEG0VGiZnfqx0pSgtq1/QHZYrAU6o5rLGHD8YvZE4JqM2pHRiPKEQEQFYQAKn 1jlyLQu2HzEoxzEK+WJRNXCPy/nDbw51k/NW9thzDrKK3DRO9xmIbbrZtKx2N9IbtoWp /A9Z34Mz6TcpIfC46C+icdzUz77fx4PyKFVVIwqzZNWG0ICiywgr+4MOyrdO/bMvUqKR h8dvwM4WoJ4qLzIZ6wBNSKfNG4qF25iZdSocMloRllSfp5nwlHMZo20243c3rp4pHx2+ gxXx+Z44HUaGyYwcycuXanLY42yRBT1qmgOHn5BIR0HvcZk63vBkFRFH88HGmXk6iG4N yUTw== X-Gm-Message-State: AOAM530i7wZ27X1Qy29W7BPPP4JZi0Pudw8OlQQJ4akYJj1TqKhHjss/ r3A4YwQx5MXlH773/9txfTa1jYpAP1M= X-Google-Smtp-Source: ABdhPJz09/HV02Jtk+5Fr8Kko7yScGB1Ufr+hb78Y42SSO7+NFY1JCcQx28IyMlB2CNtRpuvn5iSOQ== X-Received: by 2002:a1c:a546:: with SMTP id o67mr671137wme.151.1612921711977; Tue, 09 Feb 2021 17:48:31 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j125sm711782wmb.44.2021.02.09.17.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 17:48:30 -0800 (PST) In-Reply-To: <871rdpt9q6.fsf@protesilaos.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199752 Archived-At: Hello! On 09.02.2021 19:46, Protesilaos Stavrou wrote: > I have prepared a new patch. > > 1. Incorporate the feedback received thus far: > > + Do not apply special treatment to the Git stash header. It now > looks the same as all other headers. > > + Rename 'vc-dir-ignored' to 'vc-dir-status-ignored'. > > + Apply 'vc-dir-status-ignored' to gitignored files. > > 2. Implement the new faces in all backends, while ensuring that every > value documented for 'vc-state' is taken into account. Thanks! Looking good, I've applied and pushed this patch. Except for one thing: > + Please double check that the 'rev-and-lock' state is correct: it is > the only one I could infer from the context of what the USER of > 'vc-state' is. USER denotes string values (which will denote being locked by that user). I don't think the symbol `rev-and-lock' can ever be the value returned by 'vc-state', though I'll have to admit not really understanding what vc-rcs-consult-headers does. So I removed that bit. Someone should feel free to correct me.