From: Dmitry Gutov <dgutov@yandex.ru>
To: Protesilaos Stavrou <info@protesilaos.com>,
Juri Linkov <juri@linkov.net>
Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git
Date: Wed, 10 Feb 2021 03:48:28 +0200 [thread overview]
Message-ID: <cba87876-e663-4ec8-2c8d-e3914fb789f2@yandex.ru> (raw)
In-Reply-To: <871rdpt9q6.fsf@protesilaos.com>
Hello!
On 09.02.2021 19:46, Protesilaos Stavrou wrote:
> I have prepared a new patch.
>
> 1. Incorporate the feedback received thus far:
>
> + Do not apply special treatment to the Git stash header. It now
> looks the same as all other headers.
>
> + Rename 'vc-dir-ignored' to 'vc-dir-status-ignored'.
>
> + Apply 'vc-dir-status-ignored' to gitignored files.
>
> 2. Implement the new faces in all backends, while ensuring that every
> value documented for 'vc-state' is taken into account.
Thanks!
Looking good, I've applied and pushed this patch. Except for one thing:
> + Please double check that the 'rev-and-lock' state is correct: it is
> the only one I could infer from the context of what the USER of
> 'vc-state' is.
USER denotes string values (which will denote being locked by that user).
I don't think the symbol `rev-and-lock' can ever be the value returned
by 'vc-state', though I'll have to admit not really understanding what
vc-rcs-consult-headers does.
So I removed that bit. Someone should feel free to correct me.
next prev parent reply other threads:[~2021-02-10 1:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 11:42 bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Protesilaos Stavrou
2021-02-07 15:15 ` Eli Zaretskii
2021-02-07 16:15 ` Protesilaos Stavrou
2021-02-08 6:55 ` Lars Ingebrigtsen
2021-02-08 18:17 ` Juri Linkov
2021-02-08 23:24 ` Dmitry Gutov
2021-02-09 6:42 ` Protesilaos Stavrou
2021-02-09 9:19 ` Juri Linkov
2021-02-09 16:30 ` Protesilaos Stavrou
2021-02-09 17:46 ` Protesilaos Stavrou
2021-02-10 1:48 ` Dmitry Gutov [this message]
2021-02-10 4:06 ` Protesilaos Stavrou
2021-02-10 13:32 ` Dmitry Gutov
2021-02-08 15:54 ` Dmitry Gutov
2021-02-08 16:35 ` Protesilaos Stavrou
2021-02-08 23:33 ` Dmitry Gutov
2021-02-09 5:01 ` Protesilaos Stavrou
2021-02-09 13:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba87876-e663-4ec8-2c8d-e3914fb789f2@yandex.ru \
--to=dgutov@yandex.ru \
--cc=46358@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).