From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 20 Dec 2018 03:15:06 +0200 Message-ID: References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545268447 21702 195.159.176.226 (20 Dec 2018 01:14:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2018 01:14:07 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 20 02:14:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZmuY-0005W2-Ba for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 02:14:02 +0100 Original-Received: from localhost ([::1]:34831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZmwf-0004No-2F for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Dec 2018 20:16:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZmwZ-0004NX-53 for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 20:16:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZmwU-0004AJ-5Y for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 20:16:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZmwT-00049u-Sy for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 20:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZmwT-0003r5-Ml for bug-gnu-emacs@gnu.org; Wed, 19 Dec 2018 20:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2018 01:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154526851814753 (code B ref 33567); Thu, 20 Dec 2018 01:16:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 20 Dec 2018 01:15:18 +0000 Original-Received: from localhost ([127.0.0.1]:55327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZmvm-0003pt-2w for submit@debbugs.gnu.org; Wed, 19 Dec 2018 20:15:18 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:54198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZmvk-0003pf-2e for 33567@debbugs.gnu.org; Wed, 19 Dec 2018 20:15:16 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id d15so308048wmb.3 for <33567@debbugs.gnu.org>; Wed, 19 Dec 2018 17:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=55G1khoWZqWjut5jzpMrqDh98Tvj2G2ipsoj43WQUzc=; b=bC3LqMY8rfOLDhA8T/gFQJuzqfd3e4kfCXIvoTl08DD3D3YoijiBw13f7IIQid+cuy pR+B13tTHaWYHug6+UnudNqMFaKQZA+qKRGCtaHqE5lNZCfVGHksEt2Et9ALAtC7aUiW I4rIOYQ0PVK32RQ1PGt+xCYDCkKSQUNr+4ihRk9pa6gBM17kitwX9sh8A0iz+HMuERis M6FcXq0MuIzZZ1Dv13jZ8eqz/IniVAfYmUY9S8XQ2nY8XxGycXzCfnQGinDgwzKdSRGN n1EJ3f1YKH0K5a6UkKuMBccOOiB0SKHAA/Yg+YiBeJItDKsyrERG1oEG9fxtuOXxy6x7 pocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=55G1khoWZqWjut5jzpMrqDh98Tvj2G2ipsoj43WQUzc=; b=pYuCU1wIXFSssW/EzPb8lIueE7En0adtEp7if9CRgGtIXQEVi3rjDaldxS3NShV5c8 kMSd56xjKF+l6QMQG5kGvGnqK8hxyapXC+laKdE+dsNpsaKx/6KG3TZ8PkxMCddPoQeL r7BRs4Yn+fKMSgFaj/ENsn7+oSXx7EeC3awt6gsSyNFWxy2sp6hVZOpUBJTr987gWNfg fMN0f1Qv4i5+zBEQ49hLBbv1wZd5rbUDQGcRXHL0hdktpR5XcMy3b/z960aZW2N9XqyM 2FvzARIfy6O+9m0xS6x4LU1tEJ0z+alTQ7UpYIjvyMlaeXfnwK+ricEYrr9FfviBxRYC mpaQ== X-Gm-Message-State: AA+aEWZvrG9QYb6hG+TJw8q4ShktLBz7evNbU1Pgbj0BDoJ6XRl4Vy4s l/48Pa6wt+treP7NFrDyxSAr+OcB X-Google-Smtp-Source: AFSGD/Ud+5kUyPpbtEzk2fzpLhhPjWuQmj3JqaaVpGZ/tfPi4ijdFc5MXwYUaPbmpqm3zoDA6xAA+A== X-Received: by 2002:a7b:c853:: with SMTP id c19mr8730865wml.61.1545268509665; Wed, 19 Dec 2018 17:15:09 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id l197sm16370577wma.44.2018.12.19.17.15.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Dec 2018 17:15:07 -0800 (PST) In-Reply-To: <87d0pyxtnc.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153632 Archived-At: On 19.12.2018 2:11, Juri Linkov wrote: > Neither GitHub nor GitLab have foreground green/red colors, only background > green/red colors. Speaking of GitHub and GitLab, I wonder if we should take another cue from them and tone down our background colors as well. This makes the new diffs more readable for me: (eval-after-load 'diff-mode '(progn (set-face-background 'diff-added "#eeffee") (set-face-background 'diff-removed "#ffeeee") (set-face-background 'diff-refine-added "#d0ffd0") (set-face-background 'diff-refine-removed "#ffd0d0") ))