From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Mon, 11 Dec 2023 14:02:01 +0200 Message-ID: References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> <212931702208489@mail.yandex.ru> <0c6e2e14-b494-a8cb-3893-ffb39577baf9@gutov.dev> <7b17c99d-6e4b-43b3-af93-993901a3a4ea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4071"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> To: Yuan Fu , Denis Zubarev , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 13:03:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCf0C-0000nW-5J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 13:03:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCezt-0002Yu-3M; Mon, 11 Dec 2023 07:02:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCezn-0002SK-Od for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:02:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCezn-0001RT-F5 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:02:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCf02-0005zx-3C for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 07:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.170229615223001 (code B ref 67061); Mon, 11 Dec 2023 12:03:02 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 11 Dec 2023 12:02:32 +0000 Original-Received: from localhost ([127.0.0.1]:52811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCezY-0005yv-Ch for submit@debbugs.gnu.org; Mon, 11 Dec 2023 07:02:32 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCezV-0005yg-VW for 67061@debbugs.gnu.org; Mon, 11 Dec 2023 07:02:31 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F225E5C01EA; Mon, 11 Dec 2023 07:02:09 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 11 Dec 2023 07:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702296129; x=1702382529; bh=ngzTQUzREoX6QiBZm9KA5VUM9zq0VhoCLek H5YcWwos=; b=vnRV36IVRAtm1lhYxVWCCUURSwmQud4/bR3Oacb7CvpldsQRW19 UUsxPaiG3RVJFlpKt55R0PbEUciYxr5LYissQHR/tZ6bf/l+inKKEiPzgYKWwx+M TRrmfoQ1n/7PU3HepV+Ic7Vowd8V1qM3KbPcqvJdImehkpPacq1kwgVis14hAB3P tWut/42pKG2h/7wshnq1IvXQzh6xhrHuxIE9QUZH1IxAVuK6PLAUaL5W21l2Kb53 4mgvhgJ+J86L3/68LkaM1ao9S5lGatgxnnCZBr5PZXStF4MyPDgklJ9vo1ydyYn8 /O4zCEOB/ZJ6UA6dWmbGu2Vx8+InFT+qrvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702296129; x=1702382529; bh=ngzTQUzREoX6QiBZm9KA5VUM9zq0VhoCLek H5YcWwos=; b=t4/jQ7/PkoXQc3Ue6wbk+TlKqd6GW2dcAKk6HuPXgcT/XXY+Qvy oJmAfzm+zDenkHBHrMmmMSSZJ7/bvz1pKUfF/pqcjuZnW/DEur2yEQ2MY/8ZNU96 xyS1rEZLMZCRJ8yFzokKOrcnY3uEVLMvAvPFsn3lI6hicz1npXaLw1Kbm/44qD6E TZ0TsPPMD9FHANoJdy1roXRk0Stkw0U01l2nviso5G3B1grJVR5saHteoCAO/56J NDayTIH9CHcAyjg8kFGWNJAQQzrK6/sy/xcWepAqzQgBFzUiEvCc0HPLrf/RR/Eu Qcuca6OuorkaSpI6Ii81UNIFtRFHHjMlXaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelvddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Dec 2023 07:02:06 -0500 (EST) Content-Language: en-US In-Reply-To: <7b17c99d-6e4b-43b3-af93-993901a3a4ea@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275978 Archived-At: On 11/12/2023 09:10, Yuan Fu wrote: >>> I wanted shorthand form to be consistent with the full form. >>> Your point makes sense too, I don't have strong opinion about this. >>> Also I'm not sure now about `var[ii] = 1`, since it is actually >>> accessing the list or dictionary element and >>> `font-lock-variable-use-face` may suit better here. >> >> Yep. To sum up, I would add highlighting to your examples `for var in >> range(3)` and `var := 3` but not others. > IMHO, for the assignment feature, we should stick to the narrow > definition of assignments, ie, anything that looks like "a = b". Things > like "for var in range(3)" could be highlighted by variable feature, I > think. I think "for var in range(3)" should be part of the "definition" feature because a variable is defined there. Alongside parameters.