From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#69078: [PATCH] esh-mode: Allow eshell-kill-output to actually kill the output. Date: Thu, 15 Feb 2024 18:27:34 -0800 Message-ID: References: <20240212162451.30490-1-~@wolfsden.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33316"; mail-complaints-to="usenet@ciao.gmane.io" To: Tomas Volf <~@wolfsden.cz>, 69078-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 16 03:30:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ranza-0008Zu-Ff for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Feb 2024 03:30:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ranz8-0006KY-DF; Thu, 15 Feb 2024 21:29:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ranyy-0006JZ-Vy for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 21:29:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ranyy-00021H-2H for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 21:29:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ranzG-0005i7-MD for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 21:30:02 -0500 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Feb 2024 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 69078 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 69078@debbugs.gnu.org, jporterbugs@gmail.com, ~@wolfsden.cz Original-Received: via spool by 69078-done@debbugs.gnu.org id=D69078.170805054221853 (code D ref 69078); Fri, 16 Feb 2024 02:30:02 +0000 Original-Received: (at 69078-done) by debbugs.gnu.org; 16 Feb 2024 02:29:02 +0000 Original-Received: from localhost ([127.0.0.1]:57698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ranyH-0005gL-Uq for submit@debbugs.gnu.org; Thu, 15 Feb 2024 21:29:02 -0500 Original-Received: from mail-oo1-f48.google.com ([209.85.161.48]:51647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ranyG-0005ft-Ev for 69078-done@debbugs.gnu.org; Thu, 15 Feb 2024 21:29:01 -0500 Original-Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-58e256505f7so246639eaf.3 for <69078-done@debbugs.gnu.org>; Thu, 15 Feb 2024 18:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708050456; x=1708655256; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=IShTfCRLRo3Qz/QNNjtkIkw4sIEha3j9zBoBTyedYvs=; b=R7ODOL2cZGNTfmgtlpv5WR8pjegxJafylTRUmxtzVGW4jgVr61zgYRAE0Phx11OiH5 H8RTy/vLZ4ocq6y8nRKWMjJ92AgKohyhXfcxANx7hApdQ1Rlu920JG5GcBwr/x6b0KeL OHVm4oEm65SziIO7G4Sxg1BDfhw+bERHg+JDaLGRxhgqPJ4xsiwllAIXpG00K+KFSqmt tzbaygRxrt1Y5RFnlUkCeDvLa/m9/zEmcDbXpCXapGD5dM/b7xNtFYnHySQC7aX4nhho iRhQsv2dIAThj6E6+tSqegxuDYw8gq/QdQFoPjerIc/kP15sZo6Xs0GCDLXWl+eZ8awd SAaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708050456; x=1708655256; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IShTfCRLRo3Qz/QNNjtkIkw4sIEha3j9zBoBTyedYvs=; b=e6THK5TxkPu7GEjb29xi28vp3ir666IF1wZ+DsgYHOg1Ep5EtdJMVHHhY0IJGE2lfs VS9+yi6P1TKkzqxHc0mlev33Mk61c9hh4LT1ItQSra4oiGWYRctnDHrEbqnJAJQ4UVd0 zQeF2XihZ5jsh6JMckyuNUNt0BgTlHTBWiNCKAa/c1nswPUShWaTcQ6laR1PuLN8FbTz +iRyl/Bt2yIy4mnrRYwIy4bpv43WR0jvgcAvQFlVO7lMrH188ozx7vnK19TTyoOaa8zw jsgp/rTJfmBf4C/E1kxj4v+d0G9pYYJXoAppjFb35w0JekwgDlOhIceqePa3QncVcwOa SIEA== X-Forwarded-Encrypted: i=1; AJvYcCWvHzxuu42ljUjaigtjh0grh1hnM5krwdfVrOH3gp15RNB3fD6IUk38qY4WAl/5gMzCiLbONyugCAktI4hwXDCu/Bm1jolCJ5ycHg== X-Gm-Message-State: AOJu0YzsMy+5f2pyNffL3pM32BVvJSQiHOuGqM/KNhGX4NKawNaPcn2n OsDEibQ1MKLBmbX9TfvuEiBsk1Qgho3enOK+F1gomfY/IUOYundhlClg6QWI X-Google-Smtp-Source: AGHT+IHkSX6UXM8Wy+OmEXzzQpCOdEQYqU9v+9DpuYsmeMrPPQsaTGZEtra7If1ieKsQ5SKxAK8/dw== X-Received: by 2002:a05:6358:5e15:b0:176:6144:2f12 with SMTP id q21-20020a0563585e1500b0017661442f12mr3707828rwn.28.1708050455655; Thu, 15 Feb 2024 18:27:35 -0800 (PST) Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i65-20020a62c144000000b006e118d2db93sm2082734pfg.125.2024.02.15.18.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 18:27:35 -0800 (PST) Content-Language: en-US In-Reply-To: <20240212162451.30490-1-~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280085 Archived-At: On 2/12/2024 8:22 AM, Tomas Volf wrote: > Before this commit, the function eshell-kill-output, despite the name, > did not allow to kill the output, it always just deleted it. This > commit fixes that, allowing to do the kill with C-u. Thanks for noticing this. This makes sense to me, so I've merged it to the master branch as 572d58b5e8d. > The function name is misleading (and in comint is is called > coming-delete-output), but changing it could break code, so I do not think it is > worth it. Adding the argument should be enough. I also fixed this, but added an obsolete alias for the old name. That way, it won't break anything, and we can be a little more consistent with comint. Closing this bug now.