From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#65468: 29.1; describe-theme fails to describe some themes not loaded Date: Thu, 24 Aug 2023 07:16:10 -0300 Message-ID: References: <87lee29m1c.fsf@posteo.net> <83bkeyrmy1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Duz9oUC0VXmwUC1ow07lHdPZ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: thievol@posteo.net, 65468@debbugs.gnu.org, Protesilaos Stavrou To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 12:17:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ7Ou-0007gQ-2m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 12:17:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ7Og-0000ml-AI; Thu, 24 Aug 2023 06:17:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ7Of-0000mY-JU for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 06:17:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ7Oc-0005YC-GC for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 06:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ7Og-0006L8-CB for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 06:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65468 X-GNU-PR-Package: emacs Original-Received: via spool by 65468-submit@debbugs.gnu.org id=B65468.169287218724321 (code B ref 65468); Thu, 24 Aug 2023 10:17:02 +0000 Original-Received: (at 65468) by debbugs.gnu.org; 24 Aug 2023 10:16:27 +0000 Original-Received: from localhost ([127.0.0.1]:36181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ7O6-0006KC-Vf for submit@debbugs.gnu.org; Thu, 24 Aug 2023 06:16:27 -0400 Original-Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:62638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ7O3-0006Jw-BP for 65468@debbugs.gnu.org; Thu, 24 Aug 2023 06:16:25 -0400 Original-Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1c8d2606fc9so403848fac.0 for <65468@debbugs.gnu.org>; Thu, 24 Aug 2023 03:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692872173; x=1693476973; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=FK0/t3fXOJ9QhDm8957qD6A/66v6j8e7cc2juM+a2pA=; b=pR4eNUsjv934XClcT9DqMi19W0TkaZZzxHqQas960pOzgMrSWsXay1vCQ/FE/QDsPY ihvpiKmQIJB8lfA33dV1F++IrpQgywVuZuRChQ2nB9r/AZXaTpYtf5G/VZ9Fv+/khpZI xzxE5IeLDT+79gYnaj5cW3Yv2t5UHHQ3fyPFJkb36vBPBWngU+3ANMpMEzF9xcpnaUSi Qt9bVNqjeK90SAZp8eVQb7RPoScu2itWZWtpKRv/64HO50B3JNx/fSjgODvTJpwkR4uW yYS2FafZ2BlU2qvcvsjQBNmghyfNZPeiKJONxJFvB/1NmIyUZJZsiHxodFQnFoLvRHi4 4vHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692872173; x=1693476973; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FK0/t3fXOJ9QhDm8957qD6A/66v6j8e7cc2juM+a2pA=; b=UpQzIjPCZEdJOlC+2CA9uuqNFt14kMD4rz1cKWOIty3/tSmGkMn4clygRwufpZRFau LPBtXOaK/OlF1xOoxQDdBNVlCLWNlT7hicK7hr247YAM3YeRDKP0hjSzacHTcfDRXzfT nehpxPWGIKwms50Ga5e9XTQJv2vgd9QLIx1z7LhsSu44WfOzATFTIqj0ti+4uouz8I4V AkRTMCJw+ikXminKMFVwP9F5c31dlP7vVY96OKHDCo19JUXUYRdZ4dbOaTT+ukQidBE6 joL+HDBQp+bv3DChu0urP5iqDHeBJBs6n6pg4zyDEwWS8L7yMMfz2KoEp5GZ3IgQm5Jo 3quA== X-Gm-Message-State: AOJu0YzEsuWX1Im0bqeHvLyEF/TrDT6QDC+7d7YWeZsGhAJWcVzjUDl1 l3J08mc7NyxRHvHGpqkKWB4= X-Google-Smtp-Source: AGHT+IGc2iawhcZJp2FZC1sjfUkmwlxKV8CcnaGjhGJMcS87L9sSQ23/9CETlhsPHmlP6NrxfMKjKA== X-Received: by 2002:a05:6830:2682:b0:6bb:132f:a785 with SMTP id l2-20020a056830268200b006bb132fa785mr1346340otu.10.1692872173415; Thu, 24 Aug 2023 03:16:13 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id d28-20020a05683018fc00b006bee5535b44sm134278otf.75.2023.08.24.03.16.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 03:16:12 -0700 (PDT) Content-Language: en-US In-Reply-To: <83bkeyrmy1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268323 Archived-At: This is a multi-part message in MIME format. --------------Duz9oUC0VXmwUC1ow07lHdPZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eli Zaretskii writes: >> Cc: 65468@debbugs.gnu.org >> Date: Wed, 23 Aug 2023 06:53:03 -0300 >> From: Mauro Aranda >> >> Thierry Volpiatto writes: >> >>  > This because `describe-theme-1` is not looping in buffer to find >>  > `deftheme` definition. >> >> It is a convention that the first form should be a call to deftheme. >> But it seems built-in themes have deviated from that convention.  And >> other themes might as well, I don't know. >> >>  > >>  > Try (describe-theme 'leuven) to reproduce (if not already loaded of >> course). >>  > >> >> At least for the leuven themes, it should be easy to make them follow >> the convention. > > I think we should indeed fix the themes that come with Emacs. Here's a patch for the leuven themes.  And I'm CCing Prot so he can take a look to adjust the modus-themes. --------------Duz9oUC0VXmwUC1ow07lHdPZ Content-Type: text/x-patch; charset=UTF-8; name="0001-Adjust-built-in-themes-to-convention-Bug-65468.patch" Content-Disposition: attachment; filename*0="0001-Adjust-built-in-themes-to-convention-Bug-65468.patch" Content-Transfer-Encoding: base64 RnJvbSBhYjQxNzI4NGYyN2QxNzJjYzk1ZjRjNzM1ZjI4YmRmZDYzNjY4MTdiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFRodSwgMjQgQXVnIDIwMjMgMDc6MTI6NDEgLTAzMDAKU3ViamVjdDog W1BBVENIXSBBZGp1c3QgYnVpbHQtaW4gdGhlbWVzIHRvIGNvbnZlbnRpb24gKEJ1ZyM2NTQ2 OCkKCiogZXRjL3RoZW1lcy9sZXV2ZW4tZGFyay10aGVtZS5lbAoqIGV0Yy90aGVtZXMvbGV1 dmVuLXRoZW1lLmVsOiBNYWtlIHRoZSBkZWZ0aGVtZSBjYWxsIHRoZSBmaXJzdCBmb3JtLgot LS0KIGV0Yy90aGVtZXMvbGV1dmVuLWRhcmstdGhlbWUuZWwgfCAyMCArKysrKysrKysrLS0t LS0tLS0tLQogZXRjL3RoZW1lcy9sZXV2ZW4tdGhlbWUuZWwgICAgICB8IDIwICsrKysrKysr KystLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy90aGVtZXMvbGV1dmVuLWRhcmstdGhlbWUu ZWwgYi9ldGMvdGhlbWVzL2xldXZlbi1kYXJrLXRoZW1lLmVsCmluZGV4IDMzYTE1OTQ1ZTcx Li5hMjQ0NTg5NmVhNiAxMDA2NDQKLS0tIGEvZXRjL3RoZW1lcy9sZXV2ZW4tZGFyay10aGVt ZS5lbAorKysgYi9ldGMvdGhlbWVzL2xldXZlbi1kYXJrLXRoZW1lLmVsCkBAIC0zOSw2ICsz OSwxNiBAQAogCiA7OzsgQ29kZToKIAorOzs7IyMjdGhlbWUtYXV0b2xvYWQKKyhkZWZ0aGVt ZSBsZXV2ZW4tZGFyaworICAiRmFjZSBjb2xvcnMgd2l0aCBhIGRhcmsgYmFja2dyb3VuZC4K K0Jhc2ljLCBGb250IExvY2ssIElzZWFyY2gsIEdudXMsIE1lc3NhZ2UsIE9yZyBtb2RlLCBE aWZmLCBFZGlmZiwKK0ZseXNwZWxsLCBTZW1hbnRpYywgYW5kIEFuc2ktQ29sb3IgZmFjZXMg YXJlIGluY2x1ZGVkIC0tIGFuZCBtdWNoCittb3JlLi4uIgorICA6YmFja2dyb3VuZC1tb2Rl ICdkYXJrCisgIDpmYW1pbHkgJ2xldXZlbgorICA6a2luZCAnY29sb3Itc2NoZW1lKQorCiA7 OzsgT3B0aW9ucy4KIAogKGRlZmdyb3VwIGxldXZlbi1kYXJrIG5pbApAQCAtOTMsMTYgKzEw Myw2IEBAIGxldXZlbi1kYXJrLXNjYWxlLWZvbnQKIAogOzs7IFRoZW1lIEZhY2VzLgogCi07 OzsjIyN0aGVtZS1hdXRvbG9hZAotKGRlZnRoZW1lIGxldXZlbi1kYXJrCi0gICJGYWNlIGNv bG9ycyB3aXRoIGEgZGFyayBiYWNrZ3JvdW5kLgotQmFzaWMsIEZvbnQgTG9jaywgSXNlYXJj aCwgR251cywgTWVzc2FnZSwgT3JnIG1vZGUsIERpZmYsIEVkaWZmLAotRmx5c3BlbGwsIFNl bWFudGljLCBhbmQgQW5zaS1Db2xvciBmYWNlcyBhcmUgaW5jbHVkZWQgLS0gYW5kIG11Y2gK LW1vcmUuLi4iCi0gIDpiYWNrZ3JvdW5kLW1vZGUgJ2RhcmsKLSAgOmZhbWlseSAnbGV1dmVu Ci0gIDpraW5kICdjb2xvci1zY2hlbWUpCi0KIChsZXQgKChjbGFzcyAnKChjbGFzcyBjb2xv cikgKG1pbi1jb2xvcnMgODkpKSkKIAogICAgICAgOzsgTGV1dmVuIGdlbmVyaWMgY29sb3Jz LgpkaWZmIC0tZ2l0IGEvZXRjL3RoZW1lcy9sZXV2ZW4tdGhlbWUuZWwgYi9ldGMvdGhlbWVz L2xldXZlbi10aGVtZS5lbAppbmRleCBmN2Q0NTQzODFkNy4uM2Q4ZDBkNDliMzYgMTAwNjQ0 Ci0tLSBhL2V0Yy90aGVtZXMvbGV1dmVuLXRoZW1lLmVsCisrKyBiL2V0Yy90aGVtZXMvbGV1 dmVuLXRoZW1lLmVsCkBAIC0zOCw2ICszOCwxNiBAQAogCiA7OzsgQ29kZToKIAorOzs7IyMj dGhlbWUtYXV0b2xvYWQKKyhkZWZ0aGVtZSBsZXV2ZW4KKyAgIkZhY2UgY29sb3JzIHdpdGgg YSBsaWdodCBiYWNrZ3JvdW5kLgorQmFzaWMsIEZvbnQgTG9jaywgSXNlYXJjaCwgR251cywg TWVzc2FnZSwgT3JnIG1vZGUsIERpZmYsIEVkaWZmLAorRmx5c3BlbGwsIFNlbWFudGljLCBh bmQgQW5zaS1Db2xvciBmYWNlcyBhcmUgaW5jbHVkZWQgLS0gYW5kIG11Y2gKK21vcmUuLi4i CisgIDpiYWNrZ3JvdW5kLW1vZGUgJ2xpZ2h0CisgIDpraW5kICdjb2xvci1zY2hlbWUKKyAg OmZhbWlseSAnbGV1dmVuKQorCiA7OzsgT3B0aW9ucy4KIAogKGRlZmdyb3VwIGxldXZlbiBu aWwKQEAgLTc0LDE2ICs4NCw2IEBAIGxldXZlbi1zY2FsZS1mb250CiAKIDs7OyBUaGVtZSBG YWNlcy4KIAotOzs7IyMjdGhlbWUtYXV0b2xvYWQKLShkZWZ0aGVtZSBsZXV2ZW4KLSAgIkZh Y2UgY29sb3JzIHdpdGggYSBsaWdodCBiYWNrZ3JvdW5kLgotQmFzaWMsIEZvbnQgTG9jaywg SXNlYXJjaCwgR251cywgTWVzc2FnZSwgT3JnIG1vZGUsIERpZmYsIEVkaWZmLAotRmx5c3Bl bGwsIFNlbWFudGljLCBhbmQgQW5zaS1Db2xvciBmYWNlcyBhcmUgaW5jbHVkZWQgLS0gYW5k IG11Y2gKLW1vcmUuLi4iCi0gIDpiYWNrZ3JvdW5kLW1vZGUgJ2xpZ2h0Ci0gIDpraW5kICdj b2xvci1zY2hlbWUKLSAgOmZhbWlseSAnbGV1dmVuKQotCiAobGV0ICgoY2xhc3MgJygoY2xh c3MgY29sb3IpIChtaW4tY29sb3JzIDg5KSkpCiAKICAgICAgIDs7IExldXZlbiBnZW5lcmlj IGNvbG9ycy4KLS0gCjIuMzQuMQoK --------------Duz9oUC0VXmwUC1ow07lHdPZ--