From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Date: Fri, 10 Sep 2021 13:49:07 +0000 Message-ID: References: <97d3ff2c-9e72-4004-88a9-08130ac99a74@default> <838s0fpixr.fsf@gnu.org> <83k0jtr45c.fsf@gnu.org> <87v93avtoe.fsf@gnus.org> <87r1dyvtav.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="w4VIE1SyWO" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 21695@debbugs.gnu.org, hmelman@gmail.com To: Richard Stallman , larsi@gnus.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 15:50:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOgvR-0007Ia-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 15:50:41 +0200 Original-Received: from localhost ([::1]:48620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOgvP-0001LW-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 09:50:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOguo-0000l8-Gu for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 09:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOguo-000400-9X for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOguo-0007Vn-5Z for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Sep 2021 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21695 X-GNU-PR-Package: emacs Original-Received: via spool by 21695-submit@debbugs.gnu.org id=B21695.163128175328802 (code B ref 21695); Fri, 10 Sep 2021 13:50:02 +0000 Original-Received: (at 21695) by debbugs.gnu.org; 10 Sep 2021 13:49:13 +0000 Original-Received: from localhost ([127.0.0.1]:37289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOgu1-0007UU-AK for submit@debbugs.gnu.org; Fri, 10 Sep 2021 09:49:13 -0400 Original-Received: from heytings.org ([95.142.160.155]:55066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOgtz-0007UJ-1b for 21695@debbugs.gnu.org; Fri, 10 Sep 2021 09:49:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1631281749; bh=ZKQOLkMenl2CUq0l24LGaosMRqqxs/mLo7pAWDiW/GU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=YrehL6kuTA3u/AlPc56VkWgXkaOmRkF6zUs9w1x6ENat9L8AYU8wI+yoOeu5Zy5gS wpEhSr4yZ4gOksOwqZuzfFyzKYv8799qwhOvg3VVUTEmg2q9dq/kmF7A3XBpSsYSx0 nG8Z48cB6PRxYBAP4OFu7Hm3IcGr70bINlaeQ77eHqFa/y3Dud7IoCxV45OQpJ+Ykt s2CaZsKSRRBnHLeGWtg5EPMhaD5nqdD/vmietOsd65cGvGfdy3SRZcqg6YvVDM3jCY lRa7RPR/l9QlVYkdGnLYGqqPepp4muDOu1gKdPnQwCOX5hAJtmXac8MvKcRdJl5FGD C8MEyIiOyuX5w== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214013 Archived-At: --w4VIE1SyWO Content-Type: text/plain; format=flowed; charset=us-ascii > > Please see the solution I proposed in the past few days. > The solution you proposed is not optimal I think, in particular because variables can also be set interactively, e.g. with M-: or C-x C-e, so checking that they have been set correctly after loading the init file is not enough. The proposed (two lines!) patch works in all cases. Its commit message was perhaps not clear enough, so I made it longer to make it (hopefully) crystal clear that it does TRT: there are no warnings for preloaded variables whose files are loaded after those variables have been setq'd. --w4VIE1SyWO Content-Type: text/x-diff; name=Warn-when-custom-variable-is-wrongly-set.patch Content-Transfer-Encoding: base64 Content-ID: Content-Description: Content-Disposition: attachment; filename=Warn-when-custom-variable-is-wrongly-set.patch RnJvbSBiNzRlOWRmY2Y5YzY3NDU1MjIzYjJhM2JlOTk2OTI2NjliM2I1MjA1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBGcmksIDEwIFNl cCAyMDIxIDEzOjM1OjUwICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIFdhcm4g d2hlbiBjdXN0b20gdmFyaWFibGUgaXMgd3JvbmdseSBzZXQuDQoNCiogc3Jj L2V2YWwuYyAoRnNldHEpOiBEaXNwbGF5IHdhcm5pbmcgd2hlbiBhIGN1c3Rv bSB2YXJpYWJsZSB3aXRoIGEgOnNldA0KcHJvcGVydHkgaXMgc2V0IHdpdGgg c2V0cS4gIFdhcm5pbmdzIGFyZSBkaXNwbGF5ZWQgb25seSBmb3IgY3VzdG9t IHZhcmlhYmxlcw0Kd2hvc2UgZmlsZXMgaGF2ZSBiZWVuIGxvYWRlZCBhbmQg dGhhdCBoYXZlIGEgOnNldCBwcm9wZXJ0eS4gIE5vIHdhcm5pbmdzIGFyZQ0K ZGlzcGxheWVkIGZvciBjdXN0b20gdmFyaWFibGVzIHdob3NlIGZpbGVzIGhh dmUgbWVyZWx5IGJlZW4gcHJlbG9hZGVkLA0KZm9yIGN1c3RvbSB2YXJpYWJs ZXMgdGhhdCBkbyBub3QgaGF2ZSBhIDpzZXQgcHJvcGVydHksIGFuZCBmb3Ig bm9uLWN1c3RvbQ0KdmFyaWFibGVzLiAgU2VlIGJ1ZyMyMTY5NS4NCi0tLQ0K IHNyYy9ldmFsLmMgfCA5ICsrKysrKysrLQ0KIDEgZmlsZSBjaGFuZ2VkLCA4 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCg0KZGlmZiAtLWdpdCBh L3NyYy9ldmFsLmMgYi9zcmMvZXZhbC5jDQppbmRleCA0ODEwNGJkMGY0Li4x NjhhNzc0OWEwIDEwMDY0NA0KLS0tIGEvc3JjL2V2YWwuYw0KKysrIGIvc3Jj L2V2YWwuYw0KQEAgLTUyNSw4ICs1MjUsMTUgQEAgREVGVU4gKCJzZXRxIiwg RnNldHEsIFNzZXRxLCAwLCBVTkVWQUxMRUQsIDAsDQogCSAgIDogUW5pbCk7 DQogICAgICAgaWYgKCFOSUxQIChsZXhfYmluZGluZykpDQogCVhTRVRDRFIg KGxleF9iaW5kaW5nLCB2YWwpOyAvKiBTWU0gaXMgbGV4aWNhbGx5IGJvdW5k LiAgKi8NCi0gICAgICBlbHNlDQorICAgICAgZWxzZSB7DQorCWlmICghTklM UCAoRmdldCAoc3ltLCBpbnRlcm4gKCJjdXN0b20tc2V0IikpKSkNCisJICBj YWxsMiAoaW50ZXJuICgiZGlzcGxheS13YXJuaW5nIiksIGludGVybiAoInNl dHEiKSwNCisJCSBDQUxMTiAoRmZvcm1hdCwNCisJCQlidWlsZF9zdHJpbmcN CisJCQkoImAlcycgc2hvdWxkIGJlIHNldCB3aXRoIGBjdXN0b21pemUtc2V0 LXZhcmlhYmxlJyIpLA0KKwkJCXN5bSkpOw0KIAlGc2V0IChzeW0sIHZhbCk7 CS8qIFNZTSBpcyBkeW5hbWljYWxseSBib3VuZC4gICovDQorICAgICAgfQ0K ICAgICB9DQogDQogICByZXR1cm4gdmFsOw0KLS0gDQoyLjMzLjANCg0K --w4VIE1SyWO--