From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Mon, 24 Oct 2022 20:10:46 -0700 Message-ID: References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <79a53ecc-dbfc-d088-d80d-96f349be794a@gmail.com> <834k7vw2vb.fsf@gnu.org> <87czc4tosz.fsf@gnus.org> <83lepoi58p.fsf@gnu.org> <83y1tbxbbt.fsf@gnu.org> <83h6zxwujo.fsf@gnu.org> <2738f071-c87f-72cf-226f-6e8597cb07a8@gmail.com> <83a65ouz0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27216"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 25 05:13:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onANL-0006rt-71 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Oct 2022 05:13:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onALL-0001wW-HX; Mon, 24 Oct 2022 23:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onALK-0001sf-6o for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 23:11:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onALG-0004pX-Se for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 23:11:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onALF-0007cH-M4 for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 23:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Oct 2022 03:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.166666745929269 (code B ref 51993); Tue, 25 Oct 2022 03:11:01 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 25 Oct 2022 03:10:59 +0000 Original-Received: from localhost ([127.0.0.1]:49934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onALD-0007c1-49 for submit@debbugs.gnu.org; Mon, 24 Oct 2022 23:10:59 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:47080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onALA-0007bm-0W for 51993@debbugs.gnu.org; Mon, 24 Oct 2022 23:10:57 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id jo13so6507887plb.13 for <51993@debbugs.gnu.org>; Mon, 24 Oct 2022 20:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=qFprMwmRm1GYwNa9eC1hSDKv8o3F/6hwXhMMJbstccU=; b=lDMQLo0pGqUT9j6/PysdfJWh/4uzy6e4aADBKhqXzyEOZ/hvRsk4ANcZoXFbWaMoqj EYSnI088lMqY088T+2NpW31YeJTbl5dMJhH/EULplVu84yh6RB7ZthEzSJRtXN7+KHzJ AgoOBKSAWeOf5J22//fH2pFV0PD72S800dhKhmTRjh17LlASACs6JowUSbgSgwpVM1jc 3JKwd4kpkJoU7s13XcfKPVxpZTPkDHdQLs7U9dSkCOQMLY1TEPGaIbRYBsSt3Bb5sEf3 ejlD0n3sg/LIaK+qnJw8gnESrUR8moozYyrrRr62ukXxpRWBv05j0Tri0vIVk2D92Up8 KeOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qFprMwmRm1GYwNa9eC1hSDKv8o3F/6hwXhMMJbstccU=; b=Lj8lI6jyMuz/XjuhBBGyNCE3eWU4HddrLv4Qzl4+TSc/x8qa90Q7Akm/m2JopC9ifv hdGyg+aZZMzDcIgko4Kl24846jipNYTM6E4xlrH7hzM66jpZYTGYKC+jSEd90OF/nlqe zjTG5/AYxNTgE8aMBptCJ06ZVmMKkHoeW8YmYoTDCjm9+CXBGKEHkkUZ6LieFtrpF6pa eVGH9cD4jA0NRUFCFgSWboEoHQ5Y9SnOaRxI8ck9BMjZj6olbMuTP7nBbWPyjcNBw2g4 iAvvXunb+yN9cMb095jgw7lV8BR9f3wuDm9ot+bVRh4c4I2ko/I22qykauULIm59idrd FACg== X-Gm-Message-State: ACrzQf0lc0AZFHoDNoStWaM8SDzzQ70cpa1devKtTE3xWUn5pSJoJZTd 9AI5K4vGbjzSTYkmILwLgwY= X-Google-Smtp-Source: AMsMyM6OkVzs+m5EnRGSBZANtLFWWnsCOmmojpQSaWUps3xIGGx537mecg4MBEMHtRjfK0iLmoeY7Q== X-Received: by 2002:a17:902:d4c4:b0:186:a951:b8f9 with SMTP id o4-20020a170902d4c400b00186a951b8f9mr8236411plg.130.1666667449868; Mon, 24 Oct 2022 20:10:49 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w8-20020a63f508000000b00462612c2699sm407715pgh.86.2022.10.24.20.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 20:10:48 -0700 (PDT) Content-Language: en-US In-Reply-To: <83a65ouz0e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246128 Archived-At: On 10/21/2022 11:57 PM, Eli Zaretskii wrote: >> Date: Fri, 21 Oct 2022 20:46:47 -0700 >> Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org >> From: Jim Porter >> >> The issue in the quote above is that if you enable automatic server >> shutdown in Emacs 29, it changes the behavior of exiting an emacsclient >> even when it wouldn't stop the server (i.e. when there are other active >> clients). That's surprising to me, I wouldn't expect that setting to >> affect cases when it decides *not* to kill the Emacs daemon. > > Sounds like a bug to me, because it contradicts what the doc string > says. That's how it seems to me too. In that case, I can update the patch I attached in my original message[1] to fix the bug. If we want to preserve the current behavior that Emacs 29 has exactly, we could also add a separate setting for how to handle killing the non-last client; then the two would be independently customizable. I'm not sure this is necessary, but if others think it is, I'm happy to write a patch for it. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-11/msg01702.html