From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Ryan C. Thompson" Newsgroups: gmane.emacs.bugs Subject: bug#41340: 26.3; ido-completing-read doesn't respect completion-auto-help Date: Wed, 20 May 2020 10:34:06 -0400 Message-ID: References: <8d5d0854-f60d-2c69-f0bf-4699e44b298b@thompsonclan.org> <14896214-02df-e462-0d4e-91a5f2972f64@thompsonclan.org> <1908eea2-6174-3fbf-da08-1a8d7b06036a@yandex.ru> <3d90d29b-4be8-dc8e-f02a-d49099ce797b@thompsonclan.org> <61bd2d16-a79b-cfd4-389e-5e92222d7cca@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9FD839D301D15E0B723B4725" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="55230"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Dmitry Gutov , 41340@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 16:35:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbPoM-000EFt-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 16:35:10 +0200 Original-Received: from localhost ([::1]:45716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbPoL-0004SU-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 10:35:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbPoE-0004SJ-Qk for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbPoE-0000HS-HQ for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbPoE-0002wO-Du for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Ryan C. Thompson" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41340 X-GNU-PR-Package: emacs Original-Received: via spool by 41340-submit@debbugs.gnu.org id=B41340.158998525911249 (code B ref 41340); Wed, 20 May 2020 14:35:02 +0000 Original-Received: (at 41340) by debbugs.gnu.org; 20 May 2020 14:34:19 +0000 Original-Received: from localhost ([127.0.0.1]:53897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbPnW-0002vN-O2 for submit@debbugs.gnu.org; Wed, 20 May 2020 10:34:18 -0400 Original-Received: from mail-qv1-f43.google.com ([209.85.219.43]:44302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbPnT-0002v9-Ow for 41340@debbugs.gnu.org; Wed, 20 May 2020 10:34:17 -0400 Original-Received: by mail-qv1-f43.google.com with SMTP id ee19so1391049qvb.11 for <41340@debbugs.gnu.org>; Wed, 20 May 2020 07:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thompsonclan-org.20150623.gappssmtp.com; s=20150623; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=z0F1Hy+mtsg/KGPTT4/nvUfoPMteLgGKdLuEkuiiHxU=; b=Ba29mGSyjcJ1POCk2vjeYTdL8Yon5pp58opNexi9DqJnirZDRlriQYY2BcA9SVI9AF i5LI31E5JBZsJ4RbufG/WxHV7r7hkqSJThJGOVEJjBL7GUdPf3l3x69VHlylPjDyRdNk siMCoL127lS7OX6jq8E0vg//WO0gWnwVCUAqFLK9fbZPB+mcBUSrF1c1+9MVJz1/vN0Q udFRK/5s/M7t36IkKY6sO/8li+oQV+2OJMfwGSWz+VcYQua/lZR7G54f7eBWkOGigtN8 rO4aBnbZyzhmfMCT7uUYwxsNcq0SgnjmAFwLWkilIZ629kagou+lB82MRx+kscEAHZTS HgAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=z0F1Hy+mtsg/KGPTT4/nvUfoPMteLgGKdLuEkuiiHxU=; b=RmjPQijVJZD1PSPncWiseqMjCa+DAiixdoWl8ahW80vKVNutm6QdiqGs83EfOK+3nE f1NtPYjJoShj//1zQcbDwa3jCo6vPvP3ZR4at9MO09OwyjyTReVbHTOG5LAM4IXNyT2B 9qE180wM9RzS2Fxv+cbFcosDX7zpr1UYitxaHcWCSJIAlm3wtGDmCr7pkzSj7CSGxYFw c1ujUdaOiex97RhvPOPc25roOePFOydq/rdo5Cv12+gq2Gj/7BYQtntjad8zYsgazeq3 iZoEYVYGw8bUuntJ4Tn5v3H6WsAqXZNC8yW9XClAOJSbbPslNBQxbSAMjxWC1dbM56ZU ElZA== X-Gm-Message-State: AOAM533CLFyFhMlx6YfvVwjAzqkFyP/gpWSO58dj+HvSN3C++D2Fad0I mMAPxE6a0RsCQHuX65UoGbSXafGqIvZmuw== X-Google-Smtp-Source: ABdhPJx/Zv9/d2aEIUYHHvq21NyrOxxxs0XswnYF/4Hv4LjTmG+e0BrgZkRXU77JpWrtBmZ4G5x7vw== X-Received: by 2002:a05:6214:974:: with SMTP id do20mr5135933qvb.107.1589985249605; Wed, 20 May 2020 07:34:09 -0700 (PDT) Original-Received: from urania.local (c-73-29-32-68.hsd1.nj.comcast.net. [73.29.32.68]) by smtp.gmail.com with ESMTPSA id t88sm2554579qtd.5.2020.05.20.07.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2020 07:34:08 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180657 Archived-At: This is a multi-part message in MIME format. --------------9FD839D301D15E0B723B4725 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/20 10:20 AM, Ryan C. Thompson wrote: > Perhaps an better approach would be to define an auxiliary wrapper > function that only calls `ido-completion-help' if > `completion-auto-help' is non-nil, and set that as the default for > `ido-cannot-complete-command'. Here is a patch to implement the suggestion above. --------------9FD839D301D15E0B723B4725 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-lisp-ido.el-Respect-completion-auto-help-setting.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-lisp-ido.el-Respect-completion-auto-help-setting.patch" RnJvbSAxMDFjMDNmYmVlOWUxNTU0NzA0ZTQ3MGNlNTFlZTA5OTc2NmI1Mjg0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiUnlhbiBDLiBUaG9tcHNvbiIgPHJjdEB0aG9tcHNv bmNsYW4ub3JnPgpEYXRlOiBXZWQsIDIwIE1heSAyMDIwIDEwOjI2OjA4IC0wNDAwClN1Ympl Y3Q6IFtQQVRDSF0gbGlzcC9pZG8uZWw6IFJlc3BlY3QgY29tcGxldGlvbi1hdXRvLWhlbHAg c2V0dGluZwoKVGhpcyBjb21taXQgbWFrZXMgaWRvIGNvbXBsZXRpb24gcmVzcGVjdCB0aGUg dXNlcidzIHNldHRpbmcgZm9yCmBjb21wbGV0aW9uLWF1dG8taGVscCcgYnkgZGVmYXVsdC4g SXQgZG9lcyB0aGlzIGJ5IGRlZmluaW5nIGEgd3JhcHBlcgpmdW5jdGlvbiBgaWRvLWNvbXBs ZXRpb24tYXV0by1oZWxwJywgd2hpY2ggY2FsbHMgYGlkby1jb21wbGV0aW9uLWhlbHAnCm9u bHkgd2hlbiBgY29tcGxldGlvbi1hdXRvLWhlbHAnIGlzIG5vbi1uaWwuCgpOb3RlIHRoYXQg YGNvbXBsZXRpb24tYXV0by1oZWxwJyBjYW4gYWxzbyBiZSBgbGF6eScsIGJ1dCB0aGlzIGlz CmlycmVsZXZhbnQgdG8gaWRvLCB3aGljaCBhbHJlYWR5IHNob3dzIGNvbXBsZXRpb25zIGVh Z2VybHkgYXQgYWxsCnRpbWVzLiBTbyBgbGF6eScgaXMganVzdCB0cmVhdGVkIGxpa2UgdC4K LS0tCiBsaXNwL2lkby5lbCB8IDE2ICsrKysrKysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av aWRvLmVsIGIvbGlzcC9pZG8uZWwKaW5kZXggODE4ODM0MDJhZC4uMTUxNDRmMTMxYiAxMDA2 NDQKLS0tIGEvbGlzcC9pZG8uZWwKKysrIGIvbGlzcC9pZG8uZWwKQEAgLTQ5OSwxMSArNDk5 LDEzIEBAIFRoaXMgbWVhbnMgdGhhdCBcXFtpZG8tY29tcGxldGVdIG11c3QgYWx3YXlzIGJl IGZvbGxvd2VkIGJ5IFxcW2lkby1leGl0LW1pbmlidWZmCiBldmVuIHdoZW4gdGhlcmUgaXMg b25seSBvbmUgdW5pcXVlIGNvbXBsZXRpb24uIgogICA6dHlwZSAnYm9vbGVhbikKIAotKGRl ZmN1c3RvbSBpZG8tY2Fubm90LWNvbXBsZXRlLWNvbW1hbmQgJ2lkby1jb21wbGV0aW9uLWhl bHAKKyhkZWZjdXN0b20gaWRvLWNhbm5vdC1jb21wbGV0ZS1jb21tYW5kICdpZG8tY29tcGxl dGlvbi1hdXRvLWhlbHAKICAgIkNvbW1hbmQgcnVuIHdoZW4gYGlkby1jb21wbGV0ZScgY2Fu J3QgY29tcGxldGUgYW55IG1vcmUuCiBUaGUgbW9zdCB1c2VmdWwgdmFsdWVzIGFyZSBgaWRv LWNvbXBsZXRpb24taGVscCcsIHdoaWNoIHBvcHMgdXAgYQotd2luZG93IHdpdGggY29tcGxl dGlvbiBhbHRlcm5hdGl2ZXMsIG9yIGBpZG8tbmV4dC1tYXRjaCcgb3IKLWBpZG8tcHJldi1t YXRjaCcsIHdoaWNoIGN5Y2xlIHRoZSBidWZmZXIgbGlzdC4iCit3aW5kb3cgd2l0aCBjb21w bGV0aW9uIGFsdGVybmF0aXZlczsgYGlkby1jb21wbGV0aW9uLWF1dG8taGVscCcsCit3aGlj aCBkb2VzIHRoZSBzYW1lIGJ1dCByZXNwZWN0cyB0aGUgdmFsdWUgb2YKK2Bjb21wbGV0aW9u LWF1dG8taGVscCc7IG9yIGBpZG8tbmV4dC1tYXRjaCcgb3IgYGlkby1wcmV2LW1hdGNoJywK K3doaWNoIGN5Y2xlIHRoZSBidWZmZXIgbGlzdC4iCiAgIDp0eXBlICdmdW5jdGlvbikKIAog CkBAIC0zOTI2LDYgKzM5MjgsMTQgQEAgSWYgYGlkby1jaGFuZ2Utd29yZC1zdWInIGNhbm5v dCBiZSBmb3VuZCBpbiBXT1JELCByZXR1cm4gbmlsLiIKICAgICAgICh3aGVuIChib2JwKQog CShuZXh0LWNvbXBsZXRpb24gMSkpKSkpCiAKKyhkZWZ1biBpZG8tY29tcGxldGlvbi1hdXRv LWhlbHAgKCkKKyAgIkNhbGwgYGlkby1jb21wbGV0aW9uLWhlbHAnIGlmIGBjb21wbGV0aW9u LWF1dG8taGVscCcgaXMgbm9uLW5pbC4iCisgIChpbnRlcmFjdGl2ZSkKKyAgOzsgTm90ZTog YGNvbXBsZXRpb24tYXV0by1oZWxwJyBjb3VsZCBhbHNvIGJlIGBsYXp5JywgYnV0IHRoaXMg dmFsdWUKKyAgOzsgaXMgaXJyZWxldmFudCB0byBpZG8sIHdoaWNoIGlzIGZ1bmRhbWVudGFs bHkgZWFnZXIsIHNvIGl0IGlzCisgIDs7IHRyZWF0ZWQgdGhlIHNhbWUgYXMgdC4KKyAgKHdo ZW4gY29tcGxldGlvbi1hdXRvLWhlbHAKKyAgICAoaWRvLWNvbXBsZXRpb24taGVscCkpKQog CiAoZGVmdW4gaWRvLWNvbXBsZXRpb24taGVscCAoKQogICAiU2hvdyBwb3NzaWJsZSBjb21w bGV0aW9ucyBpbiB0aGUgYGlkby1jb21wbGV0aW9uLWJ1ZmZlcicuIgotLSAKMi4yNi4yCgo= --------------9FD839D301D15E0B723B4725--