From: Daniel Mendler <mail@daniel-mendler.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
51517@debbugs.gnu.org, tsuucat <tsuucat@icloud.com>
Subject: bug#51517: GNU ELPA - SVG badge broken
Date: Sun, 31 Oct 2021 23:09:19 +0100 [thread overview]
Message-ID: <c9bfd390-f94c-998e-c798-97f2d321279a@daniel-mendler.de> (raw)
In-Reply-To: <jwvtugwhnzb.fsf-monnier+emacs@gnu.org>
Hi Stefan!
> Lars Ingebrigtsen [2021-10-31 16:30:04] wrote:
>> tsuucat <tsuucat@icloud.com> writes:
>>> The badge from https://elpa.gnu.org/packages/vertico.html is not broken.
>>> (vertico 0.14, updated 2021-Aug-11)
>>> The badge from https://elpa.gnu.org/packages/consult.html is broken.
>>> (consult 0.12, updated 2021-Oct-11)
>>> I read the broken badge (https://elpa.gnu.org/packages/consult.svg) and
>>> elpa-admin.el. I suspect `elpaa--string-width` returns 0.
>> Perhaps Stefan has some insight here; added to the CCs.
>
> I haven't had a chance to look at it yet, but this code is from Daniel,
> so maybe he has an idea of what's going on?
The code uses imagemagick "convert" to determine the width in pixels,
which is font dependent. So I assume something broke on the system -
update of the system package, or maybe imagemagick or the font was
removed. This part of the code is not exactly robust unfortunately - if
I recall correctly, you even had to install a few missing packages to
get this to work after I implemented the badges.
Daniel
next prev parent reply other threads:[~2021-10-31 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 17:18 bug#51517: GNU ELPA - SVG badge broken tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 15:30 ` Lars Ingebrigtsen
2021-10-31 21:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 22:09 ` Daniel Mendler [this message]
2021-11-24 23:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9bfd390-f94c-998e-c798-97f2d321279a@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=51517@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).