From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sat, 15 Apr 2023 15:34:42 +0300 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <87v8hynsbu.fsf@posteo.net> <87a5z935ly.fsf@gmail.com> <875y9x5szf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: larsi@gnus.org, 62720@debbugs.gnu.org, Eli Zaretskii , rpluim@gmail.com, monnier@iro.umontreal.ca To: Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 15 14:35:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnf7c-0002XU-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Apr 2023 14:35:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnf7Q-0007lD-Q1; Sat, 15 Apr 2023 08:35:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnf7O-0007kp-UX for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 08:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnf7O-00034l-IJ for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 08:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnf7O-0006rP-Bl for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168156209426352 (code B ref 62720); Sat, 15 Apr 2023 12:35:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 15 Apr 2023 12:34:54 +0000 Original-Received: from localhost ([127.0.0.1]:48480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnf7F-0006qx-Ip for submit@debbugs.gnu.org; Sat, 15 Apr 2023 08:34:53 -0400 Original-Received: from new1-smtp.messagingengine.com ([66.111.4.221]:36303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnf7D-0006qb-Q0 for 62720@debbugs.gnu.org; Sat, 15 Apr 2023 08:34:52 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id B9556582BDD; Sat, 15 Apr 2023 08:34:46 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 15 Apr 2023 08:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681562086; x=1681565686; bh=xhYdDgFAg5Bab0Ogkgb1i6m+eCSl+wyrqCZ 8jUztjag=; b=bDELLtgAkyBOU4Xfvbz8moNuWnAoUG1tV4OtvpZCvKmf9yT+krC axb7h3sAyAHxqhtsLkh5KOcANED49EdoOpak/87OMYC+hWT79Sf2Qdlqi8sgVe3S YEfk2INj47dh+sN62A4iYytVEqgqF45fe7plqqIYRvLOp/Y7HNW+/9UZ/nszd4wC 4jX5HGw38xOw/35s/STG4oODQ9SArECq0y0kyU/9nbsfCafx936YUBsEqdYcGRe5 iZ5wrx9q115Sq9JGLRj4q6jGMOhhOUlwAl7oQpl9gOsFOl0J3CrthUmsk0W6ll1g +KxF0MLuF2wA7LFPuqnbOMtW22GAs37M8Hw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681562086; x=1681565686; bh=xhYdDgFAg5Bab0Ogkgb1i6m+eCSl+wyrqCZ 8jUztjag=; b=jRD1ZOHq56NrNr12+OfbcXcvRnmD/jsQooU6XAWzvIp7v1DOR2a ZfWl7ctfQURuKatq51wWyg3tOlbF+8pX8eqFCvuKewPK6zepmwyyDWg8bM2tRSWq rppAO2wz1aGXMsdr3xLfIbC6bORJr7j1o4SoRgfvY+SlCRCBjwBNXdDNm+XMSTrJ Sq08bHMf/vZI4Fhp8U+UhkpaFbQy763sRkxehwLIhGaotkk/wwTBPVvCmjojDytd RzvQZFD/YgB8JFEhKL6YrjfuAxVL1a/eHoTWeiLbQgrQKF4vX7Lt8aLE0quS2tdm XbFQ09vIibdRQ48hd+Z3eoCAIulf4MDBHYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelvddghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Apr 2023 08:34:44 -0400 (EDT) Content-Language: en-US In-Reply-To: <875y9x5szf.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260044 Archived-At: On 15/04/2023 13:40, Philip Kaludercic wrote: >> Eli said something like this patch could be acceptable for master and >> maybe 29.2. >> >> ----------8<----------8<----------8<----------8<----------8<----------8< >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -652,6 +652,9 @@ package--builtins >> name (a symbol) and DESC is a `package--bi-desc' structure.") >> (put 'package--builtins 'risky-local-variable t) >> >> +(defvar package--safely-upgradeable-builtins '(eglot use-package) >> + "See bug#62720 for longest docstring ever.") >> + >> (defvar package-alist nil >> "Alist of all packages available for activation. >> Each element has the form (PKG . DESCS), where PKG is a package >> @@ -2201,14 +2204,19 @@ package-install >> (package--archives-initialize) >> (list (intern (completing-read >> "Install package: " >> + (append >> (delq nil >> (mapcar (lambda (elt) >> (unless (package-installed-p (car elt)) >> (symbol-name (car elt)))) >> package-archive-contents)) >> + package--safely-upgradeable-builtins) >> nil t)) >> nil))) >> (package--archives-initialize) >> + (when-let ((desc (and (memq pkg package--safely-upgradeable-builtins) >> + (cadr (assoc pkg package-archive-contents))))) >> + (setq pkg desc)) >> (add-hook 'post-command-hook #'package-menu--post-refresh) >> (let ((name (if (package-desc-p pkg) >> (package-desc-name pkg) >> ---------->8---------->8---------->8---------->8---------->8---------->8 >> >> 1. Node code complexity. It's 6 lines of trivial code. >> 2. Absolutely no risk of "silent installation of software that wasn't ever >> installed before" >> 3. Fixes all the aforementioned issues > Personally I think this would be a fine solution considering the > constraints. +1