From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Thu, 09 Feb 2023 10:33:34 +0000 Message-ID: References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17249"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, Andrea Corallo To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 09 11:34:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ4Fv-0004Hj-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Feb 2023 11:34:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ4Fj-0008P1-Io; Thu, 09 Feb 2023 05:34:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ4Fe-0008Oa-Lu for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 05:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ4Fd-0000fo-Mx for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 05:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQ4Fd-00033C-Ji for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 05:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Feb 2023 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167593882011693 (code B ref 56682); Thu, 09 Feb 2023 10:34:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 9 Feb 2023 10:33:40 +0000 Original-Received: from localhost ([127.0.0.1]:57625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ4FI-00032W-4g for submit@debbugs.gnu.org; Thu, 09 Feb 2023 05:33:40 -0500 Original-Received: from heytings.org ([95.142.160.155]:49434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ4FE-00032K-EL for 56682@debbugs.gnu.org; Thu, 09 Feb 2023 05:33:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1675938815; bh=Ue1Vl++j/8gkGaEfkNprEl3rniv8l1eBzlGk3w0II5s=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jCL19lEMBzqMuE105aRxa+Hrmnq+WGAtKn10RX4H/JQFVkqzlDQ7cnLxZQymPHhfB KxkX1znE8sJOkWceNj/6lBxIYB9ypRiJUE1DLdowhoSFOmEe9ZapiwuRSczhMTNqiV hmTiZKJFXfoLJFWYndAFi+wBirQZTOnVwYcvnOOG6U52Okj0q96wiPVfrNnXG8XWN2 6ZQpiP9CGPcvvKYpn0aTcXf/TlMA/+GGo/4O96Oi0KStrbyv7d5sirjAgISiv4+tLZ bQ46+r8vc+1nyuT6YiCDtnrLzKBo4kAUfpO4dMU8aNMl+IHezFMEeZ7d34cKkG7f7k pmS32az92VpkQ== In-Reply-To: <83357fnwyy.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255207 Archived-At: > > Please describe the bug you discovered and the changes made to fix it > (and maybe also alternatives if you considered them). > The bug is that narrowing locks were not saved and restored by save-restriction as they were supposed to be. AFAIK there are no alternatives to what I did. I did on purpose separate that bugfix (commit 1 on the branch) from the renaming ones (commits 2-5), the documentation one (commit 6) and the one that adds a test (commit 7) to make the reviewing task easier. > > Also, did you test this both with and without native-compilation? > Yes, without and with native-compilation. Though with native-compilation I only checked with the complete changeset. > > Andrea, could you please see if the changes on that branch are okay as > far as native-compilation is concerned? > Note that the only commit you should check is 7691a84d2a.