From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Thu, 09 Feb 2023 16:11:36 +0000 Message-ID: References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83v8kalxsc.fsf@gnu.org> <83r0uylu3z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24972"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 09 17:12:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ9X7-0006Ep-Kl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Feb 2023 17:12:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQ9Wm-0007WI-3V; Thu, 09 Feb 2023 11:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ9Wk-0007Vi-86 for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 11:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQ9Wj-0001X8-W2 for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 11:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQ9Wj-0001Bv-R1 for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 11:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Feb 2023 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16759591014547 (code B ref 56682); Thu, 09 Feb 2023 16:12:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 9 Feb 2023 16:11:41 +0000 Original-Received: from localhost ([127.0.0.1]:33415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9WO-0001BH-NS for submit@debbugs.gnu.org; Thu, 09 Feb 2023 11:11:40 -0500 Original-Received: from heytings.org ([95.142.160.155]:49852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9WM-0001B8-I7 for 56682@debbugs.gnu.org; Thu, 09 Feb 2023 11:11:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1675959097; bh=t/iBR063ZOnjRSH8C9MFP2pmuapK301/izwk3WK1qfk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=9gtN3/0Qxzaui4iZ6sSHPxqDb0SX7uHvEogWP4xIQ/GTz8CW5IdW4JItaNWNcY4Qi 5CJf8tKefXz6C1eL3PprvPRlWXAhahBqOEffMgOH/WxnpFEjPL6juS7+PQ9jXha//F fqp1MI7iOPK+9VLYh5l4IDsB70/BtD5fTnNMjJEUVQi3ur+0W3mJfOum8cRgT7bvh3 sIU9smlbamzJyu1ztw6ynEcSnIDd7VP1l/tq9WhlybLRMfsjTcGQQf6nKlIq9IEfwO EKU8g34ejaOpnW/jotOLzly9wdW+Ej400YKHF66s4EjtQv5samLH3hbDIo0vWfpp5A 1Bg0TzE6+luag== In-Reply-To: <83r0uylu3z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255231 Archived-At: >>> There's one thing I cannot seem to be able to find in the >>> documentation you added: how can a Lisp program know that it is being >>> run under a "labeled narrowing", >> >> A function/macro to check that could indeed be added, its body would >> be: >> >> (save-restriction (widen) (buffer-narrowed-p)) > > We should add it and document it, but I'm surprised that there's no > easier way. One problem with the above is that it could cause a more > thorough redisplay because it fiddles with buffer restrictions. > If necessary, a specific function which does not widen could be added to do that, using narrowing_lock_peek_tag: DEFUN ("...", ...) (void) { if (NILP (narrowing_lock_peek_tag (Fcurrent_buffer ()))) return Qnil; else return Qt; } > > Also, this doesn't return the label itself. > Indeed, but returning the label would defeat the purpose of the tool. If a program can by itself determine that it is in a labeled narrowing and get its label, it can escape that narrowing without much ado. >> That information should be given in the docstring of the function that >> creates that narrowing. It is now present in the docstrings of the >> three hooks where it is used: > > Yes, but how do I know which one of these is in effect when my function > is called? > The only way is to look at the call tree of the function. (Note that I'm writing the above to "defend" a feature that I still believe should better be removed from Emacs.)