From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#46904: Non-unique windows produced by window-state-put Date: Thu, 4 Mar 2021 09:35:26 +0100 Message-ID: References: <877dmo0zdn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="384"; mail-complaints-to="usenet@ciao.gmane.io" To: Juri Linkov , 46904@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 09:36:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHjSy-000AWm-V1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 09:36:16 +0100 Original-Received: from localhost ([::1]:51566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHjSx-0004D3-NQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 03:36:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHjSk-0004Cn-HA for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 03:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHjSk-0005YQ-9d for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 03:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHjSk-0003Gd-5t for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 03:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46904 X-GNU-PR-Package: emacs Original-Received: via spool by 46904-submit@debbugs.gnu.org id=B46904.161484693612510 (code B ref 46904); Thu, 04 Mar 2021 08:36:02 +0000 Original-Received: (at 46904) by debbugs.gnu.org; 4 Mar 2021 08:35:36 +0000 Original-Received: from localhost ([127.0.0.1]:57655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHjSK-0003Fh-8V for submit@debbugs.gnu.org; Thu, 04 Mar 2021 03:35:36 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:55349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHjSI-0003FS-Qd for 46904@debbugs.gnu.org; Thu, 04 Mar 2021 03:35:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1614846928; bh=oeYP3WfF4zguMk86RrKdyZzri0Qb3RsWb243PkoZdIw=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=YoE3NTNqYPndLINrGB75cOdYf8+cxq2Y4gxnpX+3pdznHoW/5RIiBvK5b9GFazYkr 0rzHiSLVmM0AVHfOeKmZxiJEH6F+sYds0wiCNY2A5vlvC9g1r+fdDOf7Ur7zHqOkxE 8uRnpUSlm9fnFqRMCv9fQZJF9O9rhrzcTT7F1L7U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.213]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mzhj9-1lduy11HVJ-00vjRS; Thu, 04 Mar 2021 09:35:28 +0100 In-Reply-To: <877dmo0zdn.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:CTWbcKUv8XVRsshPquRWqAC886/g5vAanTQ1sRKPamvjR5IP9jB faflNyeVrhAsw6zICJTq3WWQbgrJ43ZwzkJ7OWkJf7j3D5SRIOghNhGhCjkBepc6bzTSc0O 5DIcIgkodt++fsRIhtoWauOZuu2DpgYDzVecSli5rn4oOFLc+gOyIgnxR2oflK6KsPozEDE xiM/bZ8sDD5VJpzwpijFQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:iG9K/ioU8Jk=:jSC083SJ7aeEfxoyAjSEq4 T1eYTVrV8dckSCd04gGRZXARSVLtklJ9Q7gbEA6EgAKrwYj3NS4AcTwgTTC0fDW0klSNPA5gG /gqY6YFwEcuSoUlQasOd0TVT2+hK6Ea37CUKjGVxR1P90oXnm9eWAxHuEvEX5UG41KvU9r8lq V1sxCv6q1+0jP994Bwn7NEyeHGb9nv67390crITUYPU5aCWzJ7kBQ/L1UVPEoa/1n0JMK/BLd Fs7A8wG/eF/1mSDiqUDfiqGENEbrxFB8CmzpsvY09rMTxyp6H9ungj2pZNYqcUxAVlz23Lh3u ax6h81tlwOp9Q/GMQ5Kmdt4ES0DF2J1f4Jsrb09lSLKe5XzLAIVLfee+N6LjZDbuq3mn7y/Tw NB92h3w6DIR0QN2uFX63WK3AogVZudbeWJVb/jFRQERByuPIg4MJSKvOMLrumbSmggEMzXpOS 1TYqC6TV5QZOpazK6TrcQgFlfgFdPjt9WgBxqcpS8YEju1Y4v2qBI+aUiCuFz8bU97Ow68tmq 12pjrNlIOfSuSvIiHVdYEqT6U6PmvYlM0inKudmzCyv5R0kD3mCcdIyW4Sa4Wm0TPs2zxKnGI 3OBa2EojLOaJkvsxa5JyUwikXshzX5aaAbCiTIGGaXYA1RA73omTBoLhL4g1jq1p+35vFPQMM vb/hfykdWLXRvZZvjcapCyYSoCxPMrK6Y3m0pTRRZZYJ4vMQKtQM7HqkcQntR7LW616dSduDG FN0vcdRbNuez+uxKm9KjcrgKG2SMomCr5E/k8f2mLVheSXUv5OE4ZwzALtdU7ntOGSiMHP6a X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201367 Archived-At: > We have a problem in window-state-put. For example, in emacs -Q > evaluate this several times: > > (progn > (window-state-put > (window-state-get > (frame-root-window (selected-frame)) > 'writable) > (frame-root-window (selected-frame)) 'safe) > (selected-window)) > > Every time the selected window remains the same: > > # > > But after splitting the window with e.g. 'C-x 2', > evaluating the same every time creates a new window > that it's expected to do even when there is only one window > on the frame. You mean we should do that ;; Create a new window to replace the existing one. (setq window (prog1 (split-window window) (delete-window window))))) in the one window case too? This would be certainly more consistent but I do not remember any more why this is needed in the multiple windows case. > I don't know how severe are the consequences. The only side-effect I noticed > that prev-buffers of restored windows are the same on different tabs because > they share the same window. If that is a problem and the above would help, let's do it. It couldn't possibly harm unless the root window is too small to get split and we want to put only one window there; so we should handle that special case. martin