From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD Date: Wed, 30 Aug 2023 14:07:35 +0200 Message-ID: References: <83jztpwx92.fsf@gnu.org> <875y58bv5w.fsf@yahoo.com> <83a5u8hh8k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2016"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: luangruo@yahoo.com, jcm@SDF.ORG, eggert@cs.ucla.edu, 62216@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 14:08:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbJzc-0000Fq-Nb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 14:08:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbJzI-0005Sh-F6; Wed, 30 Aug 2023 08:07:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbJzG-0005S9-U1 for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:07:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbJzG-0001Ka-HJ for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:07:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbJzO-00007T-0g for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 08:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 12:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62216 X-GNU-PR-Package: emacs Original-Received: via spool by 62216-submit@debbugs.gnu.org id=B62216.1693397276448 (code B ref 62216); Wed, 30 Aug 2023 12:08:01 +0000 Original-Received: (at 62216) by debbugs.gnu.org; 30 Aug 2023 12:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:52314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJzI-000078-33 for submit@debbugs.gnu.org; Wed, 30 Aug 2023 08:07:56 -0400 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:56736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbJzC-00006n-Dp for 62216@debbugs.gnu.org; Wed, 30 Aug 2023 08:07:54 -0400 Original-Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso83868991fa.1 for <62216@debbugs.gnu.org>; Wed, 30 Aug 2023 05:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693397257; x=1694002057; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1NMoo1WqxpfRc0v5Hd58wLXYW14Q7B1OUhxJjKINscY=; b=egJXAG5/hiGACyPBHo0BKu94GNtBxFJAhCh3RbxmTs5PoWGDFw0mLAKahWwWjhfwle 9x1RfnODDpdr5OV6AMY8FL0LsvPvTS9y5ZDaWXF39pKcqW9n2vrC95UEzeSYQcFgp5k1 oUjxvBxQoQxb0rSbggvQlBlYHQnf3oZ0+JKNmQoMISdNO3Kd3er7i1xmSOpIkgTD47ze ryrYtRgUBMMBEsOxO5hh7sA+rXE45WC30cY/mLGAW1soXrkhZqaqjcPW1bT1KfvHoW7K AEsot10qAWhCToXjblFuimqa0hiN/6Y64B/NkMSk7nh0xjR+ZWnYVZe65FgSB0qAP4xX A2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693397257; x=1694002057; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NMoo1WqxpfRc0v5Hd58wLXYW14Q7B1OUhxJjKINscY=; b=FVv6jz6sznratYjrhixi2ayM0oykEKLdgSK7uM45ZHbwsR2Zsp/b/I7uPNKEJDpGdU RVIasTqL2Mwh8cuofUG9fuZH02vZkXS0/otpJGMSdiDNA27JdRrMU49xVzMMDm96tYM1 LQBwfvDlK0kx8kVEAJXqr1gHc3nkN8BMppmG+mGFd3TE7RNBHO8aKSSOEqPM/8v0ezkU IIBycZKYIid5x8TN9+SHLVb5gpnhOSpPfg8TtoUlkfS/+vxt8WkTEkSc+3+riG2/RDKa MN1+BEr6TPiiGKJhI2MWcE+bsgvmREYjXQGgPX3AfnDGPKmu2luxpbTltREKzlzKnlbo uRWg== X-Gm-Message-State: AOJu0YzaklDc4+14VlZHQiqr2aGPW8xgGkSvtWtbp/ROB1fTxr2K4RSa VZlzBpLaKr5iGpfydQmmy0c= X-Google-Smtp-Source: AGHT+IHbmpbngItLUqxOluOpMjn6PMjyc3kqogw2FzwGQOFXLLkiiMGqb9u3AbevMD5Z7ZSLeeoMFA== X-Received: by 2002:a2e:9bc2:0:b0:2bd:ce9:848f with SMTP id w2-20020a2e9bc2000000b002bd0ce9848fmr1574701ljj.17.1693397256632; Wed, 30 Aug 2023 05:07:36 -0700 (PDT) Original-Received: from [192.168.178.21] (p4fe3acd3.dip0.t-ipconnect.de. [79.227.172.211]) by smtp.gmail.com with ESMTPSA id uz16-20020a170907119000b0099b6becb107sm7154446ejb.95.2023.08.30.05.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 05:07:36 -0700 (PDT) Content-Language: en-US In-Reply-To: <83a5u8hh8k.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268702 Archived-At: On 30.08.23 14:00, Eli Zaretskii wrote: >> From: Gerd Möllmann >> Cc: Jonathon McKitrick , Eli Zaretskii , Paul >> Eggert , 62216@debbugs.gnu.org >> Date: Wed, 30 Aug 2023 10:59:08 +0200 >> >> Po Lu writes: >> >>> Jonathon McKitrick writes: >>> >>>> What's the best mechanism to log these values in emacs? >>> >>> In this case, printf. >> >> When I add this assumption: >> >> modified src/fileio.c >> @@ -4805,8 +4805,11 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents, >> >> /* 'try' is reserved in some compilers (Microsoft C). */ >> ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE); >> + ptrdiff_t trytry_old = min (total - inserted, READ_BUF_SIZE); >> if (!NILP (end)) >> trytry = min (trytry, total - inserted); >> + if (trytry != trytry_old) >> + abort (); >> >> if (!seekable && NILP (end)) >> { >> >> and make bootstrap, temacs aborts. >> >> Can someone tell if this assumption should hold? > > You expect READ_BUF_SIZE to never be greater than gap_size? Don't know. This is how I understood Jonathan's nail saying works with this old code, doesn't work with this new code.