From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yuri.v.khan@gmail.com, 26909@debbugs.gnu.org
Subject: bug#26909: 25.1; A face for margins
Date: Tue, 12 May 2020 13:06:00 -0400 [thread overview]
Message-ID: <c8ebffec-c174-b0fa-1b13-07dbe5f83c91@gmail.com> (raw)
In-Reply-To: <83ftc5859u.fsf@gnu.org>
On 12/05/2020 12.52, Eli Zaretskii wrote:
>> Cc: 26909@debbugs.gnu.org
>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>> Date: Mon, 11 May 2020 17:01:23 -0400
>>
>> A margin face would be great to have.
>> How reasonable would it be to fill the margins with a stretched space? Would it be too costly?
>
> It would slow down redisplay, especially if the window is large, but
> maybe the slow-down will not be so awful.
Got it.
> Something like that, yes. But you will need to make sure
> extend_face_to_end_of_line is called also for empty lines. And of
> course the "silly" changes need to be made less silly.
Where the less silly strategy would be to only run the extend_face code when the margins face isn't customized, right?
> And you need
> to compute the pixel-width of the stretch glyph, since the code you
> cited only places a single SPC character there, which is not what you
> want if the margin is wider than one column.
Hmm, I think the code already does that? At least it seems to work with the patch I sent.
>> --- a/src/xfaces.c
>> +++ b/src/xfaces.c
>> @@ -4768,6 +4768,7 @@ lookup_basic_face (struct window *w, struct frame *f, int face_id)
>> case TAB_BAR_FACE_ID: name = Qtab_bar; break;
>> case TOOL_BAR_FACE_ID: name = Qtool_bar; break;
>> case FRINGE_FACE_ID: name = Qfringe; break;
>> + case MARGIN_FACE_ID: name = Qmargin; break;
>
> If this is going to be an additional basic face, then why do you call
> lookup_named_face and not lookup_basic_face?
It's because I have no idea what a basic face is, so I just cribbed from places that use the fringe face. It does things like the following, and I have no idea what those mean:
face_id = NILP (face) ? lookup_named_face (w, f, Qfringe, false)
: lookup_derived_face (w, f, face, FRINGE_FACE_ID, 0);
if (face_id < 0)
face_id = FRINGE_FACE_ID;
next prev parent reply other threads:[~2020-05-12 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 14:07 bug#26909: 25.1; A face for margins Yuri Khan
2017-05-13 14:27 ` Eli Zaretskii
2017-05-13 14:59 ` Yuri Khan
2017-05-13 16:40 ` Eli Zaretskii
2017-05-13 17:19 ` Yuri Khan
2017-05-13 17:42 ` Eli Zaretskii
2020-05-11 21:01 ` Clément Pit-Claudel
2020-05-12 16:52 ` Eli Zaretskii
2020-05-12 17:06 ` Clément Pit-Claudel [this message]
2020-05-12 17:21 ` Eli Zaretskii
2020-05-12 17:28 ` Clément Pit-Claudel
2020-05-12 17:40 ` Eli Zaretskii
2020-10-01 2:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ebffec-c174-b0fa-1b13-07dbe5f83c91@gmail.com \
--to=cpitclaudel@gmail.com \
--cc=26909@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=yuri.v.khan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).