From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62816: 30.0.50; ElDoc blinks echo area when eldoc-documentation-compose is used Date: Fri, 14 Apr 2023 01:58:19 +0300 Message-ID: References: <87leivsusz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 62816@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 14 00:59:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pn5uR-0009GX-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Apr 2023 00:59:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pn5uC-0003RF-4A; Thu, 13 Apr 2023 18:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pn5uA-0003R4-LB for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 18:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pn5uA-00076b-DN for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pn5uA-00066X-9k for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Apr 2023 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62816 X-GNU-PR-Package: emacs Original-Received: via spool by 62816-submit@debbugs.gnu.org id=B62816.168142671223427 (code B ref 62816); Thu, 13 Apr 2023 22:59:02 +0000 Original-Received: (at 62816) by debbugs.gnu.org; 13 Apr 2023 22:58:32 +0000 Original-Received: from localhost ([127.0.0.1]:45012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn5tf-00065n-LA for submit@debbugs.gnu.org; Thu, 13 Apr 2023 18:58:32 -0400 Original-Received: from new3-smtp.messagingengine.com ([66.111.4.229]:53961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pn5tb-00065Y-Tp for 62816@debbugs.gnu.org; Thu, 13 Apr 2023 18:58:30 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id B052D582366; Thu, 13 Apr 2023 18:58:22 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 13 Apr 2023 18:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681426702; x=1681430302; bh=14RPQgkgnEB2UZeS265euT/GO28uOC28AmV KoWanoAc=; b=JR611/XqKzT5qW3Zn+t7FbcKvZls8HPw0OijPoMVtXTHDguSL23 0ZPzwy1f0WSOb5CztpzKqfciRVq1QI3xxEL7OWS8nX0FeCqGvTVtYYbk3Gm8xMHw rhGLR9xBF5PXORTiIvvwg5cduI8xXUwELrv5OQnyN/916/cWuOQqHmOc/Yj9F9Iz UvHhAQhj0EkWYYzhWFktdpVr0Leg7zdPZAwaIvrT70Vd8X9uX9vnGT75OzhKjW9J 9bQQPUqhP1xoML8eHueDtYZ5jiD8xz8+o6h4PYgMVPotKSgqoShP0PA222bu9TMc Pi6+x5y6Nym2BZo1i6ctpQsmi/FwVKLGedg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681426702; x= 1681430302; bh=14RPQgkgnEB2UZeS265euT/GO28uOC28AmVKoWanoAc=; b=W DRrlRs2v4Nh5fHqdYOs/9r6+PYLqsJtiiv+VVUMrf7WCaSvy3KLLV2yYuEtdVdbz 2Eb/RZ8Yk7FlTxOZmLNScnHLxvy4zoCyfYU7pGQTuwsY/lI1UK5QWghTSg4YXYwM Ev+Snz29aWqxYZ9d8uQGAJaURFO3O4F+57rFcLZkznmmsp93Ek9yRDZYOzYguJzx A5lnsRYyXTaFYTlN9fSr3Liswkk9qWJd9yv2fDNPHp/3KrXDStuEZpmjEEsJyyew 2xw2Bpj1u01D7ltLBJGy0iX5ZDNLDMOkiNJ+dBwO7vIVNil5h2T9KOO7IRtH53p5 CCS6dm4qUguv4xUfWPpaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekledgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehffetfeeuiefggeekgefgfeekjeeuuedtheegveejueelfeeiieeuveegfffg tdenucffohhmrghinhepuhhguhhurdhsvgenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 18:58:21 -0400 (EDT) Content-Language: en-US In-Reply-To: <87leivsusz.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259882 Archived-At: On 13/04/2023 17:47, João Távora wrote: > Hello, > > Originally reported by Dmitry Gutov over > at bug#62029: > >> It's trivially reproduced even with 'emacs -Q': just add somewhere >> inside an Elisp buffer: > >> (remove-hook asd) > >> when flymake-mode is enabled and eldoc-documentation-strategy is >> 'eldoc-documentation-compose, and eldoc-echo-area-use-multiline-p is >> not 1, and move around 'asd' with C-f and C-b. > > I've confirmed this in a graphical Emacs frame. In a TTY frame, it's > harder or impossible to spot. > > Traced the problem down to a misimplementation of the > 'eldoc-documentation-compose' strategy, which leads to potentially one > eldoc-message call to be issued for each member of > 'eldoc-documentation-functions'. In fact, with this particular > strategy, the intention at most one such call should occur (after all > the documentation items of different backends have been collected). > > It's reasonably easy to fix, and I've been running the patch after my > sig all day with no problems either in Elisp or other modes. The > "blinking" observed before is gone. > > I'll push it to master soon, but leave this issue open for comments > and/or feedback a little longer. Thank you, it does seems to fix the issue with C-f/C-b in elisp-mode, in the described situation. I still see the problem with window jumping and blinking when typing with company-mode enabled, though. You say: "I do use company and multi-line echo areas liberally". Do you have some extra configuration for company-frontends? Here's a screencast that demonstrates the problem: https://a.uguu.se/csTMrzxc.webm One way to fix that is (delq 'company-echo-metadata-frontend company-frontends) but I wonder whether some better solution exists. OTOH, Eglot implements the attribute which this frontend plugs into via :company-docsig, and it seems like both with LSP servers that I just tried it returns nil. If the feature is generally unused, I could understand if Eglot users all disable this frontend anyway. It is handy to have in emacs-lisp-mode, though. At least when there is no documentation popup floating nearby.