From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17873: 24.4.50; `desktop-save' Date: Sun, 29 Jun 2014 09:47:07 -0700 (PDT) Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1404060521 7804 80.91.229.3 (29 Jun 2014 16:48:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2014 16:48:41 +0000 (UTC) To: 17873@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 29 18:48:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X1IHE-0007jd-4q for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jun 2014 18:48:28 +0200 Original-Received: from localhost ([::1]:58322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IHD-00048f-Lw for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jun 2014 12:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IH0-00047s-2r for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:48:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1IGp-0008E4-CR for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:48:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IGp-0008Dn-9C for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X1IGo-0001b6-Kv for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jun 2014 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14040604696111 (code B ref -1); Sun, 29 Jun 2014 16:48:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jun 2014 16:47:49 +0000 Original-Received: from localhost ([127.0.0.1]:36942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1IGb-0001aV-1R for submit@debbugs.gnu.org; Sun, 29 Jun 2014 12:47:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55734) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1IGW-0001a5-3d for submit@debbugs.gnu.org; Sun, 29 Jun 2014 12:47:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1IGG-0007uJ-EU for submit@debbugs.gnu.org; Sun, 29 Jun 2014 12:47:38 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IGG-0007uF-Bn for submit@debbugs.gnu.org; Sun, 29 Jun 2014 12:47:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IG7-00045I-Gt for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:47:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1IFy-0007qB-QU for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:47:19 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:26735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1IFy-0007q1-JZ for bug-gnu-emacs@gnu.org; Sun, 29 Jun 2014 12:47:10 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s5TGl9aV032171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 29 Jun 2014 16:47:09 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s5TGl8Dc006635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 29 Jun 2014 16:47:09 GMT Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s5TGl8Kk027388 for ; Sun, 29 Jun 2014 16:47:08 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90967 Archived-At: 1. The doc string says: If AUTO-SAVE is non-nil, compare the saved contents to the one last saved, and don't save the buffer if they are the same. Saved contents of what? One what last saved? Saved contents cannot be compared to "the one" anything. I think you mean "compare the current desktop information to that in the desktop file." If you are avoiding saving (because the contents are the same) then you cannot speak of comparing the "saved contents" - the contents have not yet been saved. And what buffer? This is about saving a desktop in a desktop-file. There is no notion of a buffer here - at the user level. The code puts the desktop info into a buffer (which then might get saved), but that is implementation-level. What `desktop-save' does needs to be described at a user level (what, not how, unless that is important to users). Just say that if the desktop information has not changed since it was last saved then the file is not rewritten. 2. I also have a question about the behavior: Why is writing the file even when the content is unchanged the default behavior? Why the need to specify AUTO-SAVE instead of an optional SAVE-EVEN-IF-NO-CHANGE? Is this just for backward compatibility? (Before AUTO-SAVE was introduced the behavior was to update the file even if the desktop info was not changed.) In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-06-17 on ODIEONE Bzr revision: 117359 monnier@iro.umontreal.ca-20140617193358-2t1nl1te9gc2mq= rx Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/snapshot/trunk --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1 -Ic:/Devel/emacs/include''