From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. Date: Sun, 8 Dec 2024 03:54:19 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25650"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Eshel Yaron , 74727@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 02:55:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tK6W7-0006WX-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 02:55:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tK6Vn-0007Ob-Sp; Sat, 07 Dec 2024 20:55:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tK6Vl-0007OS-PK for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 20:55:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tK6Vk-0002Pq-QM for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 20:55:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=AL/Fh3sEqiJjOFEQI25J231I8JIYL7bUU84/dXdHU1Y=; b=Bi2+B+WH/PVoh+vwmIHsSnTAn8N6ulOTIGVbmTRnM54H2HA9Mja94MOFU8AvNYCU0zoQ8dzbH6X5ZtcYB0m7RUisASwKvC2ljJNk5PmirhgXyNKNdoTsfKzFEFAd3kfAkoRShx3xdQRJ7lJg8pmsFVig2C3miCp0BZk3uzlSHY7MEUfbq8hayMsrqecpL1kHnpFraEOpWQU+5Lq6/RrELNiOmXWGAxjeH5FAQ+8eqkyBb0etzKMMxwQTXYwp91fgKZo0Byn1Jxi9DUPgTSrmwPShSggWbD07ElTiKjH25ZOGRj2khvsK5X0kDUIchI/uzTeGZi5AxTCRVNHRUe5DDw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tK6Vj-0000T2-Et for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 20:55:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74727-submit@debbugs.gnu.org id=B74727.17336228781746 (code B ref 74727); Sun, 08 Dec 2024 01:55:02 +0000 Original-Received: (at 74727) by debbugs.gnu.org; 8 Dec 2024 01:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:49099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK6VJ-0000S3-F2 for submit@debbugs.gnu.org; Sat, 07 Dec 2024 20:54:37 -0500 Original-Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:36167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tK6VB-0000Rc-Ps for 74727@debbugs.gnu.org; Sat, 07 Dec 2024 20:54:34 -0500 Original-Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 33138114011A; Sat, 7 Dec 2024 20:54:23 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Sat, 07 Dec 2024 20:54:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1733622863; x=1733709263; bh=AL/Fh3sEqiJjOFEQI25J231I8JIYL7bUU84/dXdHU1Y=; b= W85j5WaZ0a0lVLSTi3dBSo2qJe7QUHB4vmM3DCdqiVDohilaoYC78X0+hieAH3W2 le49UX3/QkdUZ2GvRekjK72EbxUohX03O7sZcDVFB5keoaTfAOFlJeSCywYUKp1Z PAU3BHTgyjFrCDpx54EML51M0GCBsZfbz4EngbZLVIEex5p69x7Lg2IgX9jD5XD+ FvDgRRHn1/XhWHNwikdpySaxjVPCrQ7YKwaWV9xZK7LJ30VjZRvLmRBGrc4YzcXT aBMbRXIU9JpBO9MHOtUTr+u9fMrRAH39rpwcgjVEqblVbTUcPUhX2Q1Wxt8PDrKP 0AK1LeFqlh+QYCYpNGcnrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1733622863; x=1733709263; bh=A L/Fh3sEqiJjOFEQI25J231I8JIYL7bUU84/dXdHU1Y=; b=zPtSwUjCjd7AOXK5J jp/dX3c4PLiMryXGACkNY6hV2JjhUsPTE5jl92lAN8gi5qUP2ISJy54+coD4efQ2 VoyBBTqrFqRg6ssBcMXJufu46raIpfBXnpGKDNDM+gJiAJ95FU22yLiVVbOBSXw5 Nsp2arfYO+reLZCKwRbdf7ZbQkLGdFIppDnYvLgPJh4ts7nHSNJas0fza4U32CQh 8lHZjpujJ2acqaG6Ow4l9xIoB6Jg1jq3QnLVzehXpf/JWWja+ku/llIVpc1/GHe0 4mR4r43M22tn0ku2dp7mQh7UtEuHFcDXbs8nW+2gyujefHkoEKQZ3VI5z0uwWoue wW4wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjedvgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuf fvfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceo ughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeejjeejjeeigf eiffelteehheejveefieevgfejveehhefgjeefffetvdeiledvffenucffohhmrghinhep ghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohepvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgvsegvshhhvghlhigrrhhonhdrtghomh dprhgtphhtthhopeejgeejvdejseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Dec 2024 20:54:21 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296608 Archived-At: Hi Eshel, On 07/12/2024 15:31, Eshel Yaron wrote: > This patch fixes the issue described below, which IIUC originates in a > mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 > > 1. emacs -Q > 2. M-x apropos-library elisp-mode RET > 3. The*Apropos* buffer incorrectly lists methods that elisp-mode.el > defines as if they were_features_ provided by the library. > Accordingly, clicking on one of those references yields an error such > as "Unknown library `xref-backend-definitions'" Thanks! That's a good suggestion. If you've started testing this area, though, do you know of a case when dropping this case - like: diff --git a/lisp/apropos.el b/lisp/apropos.el index 0655fecd0e8..9af8a7269ae 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -733,7 +733,7 @@ apropos-library ('t nil) ; Skip "was an autoload" entries. ;; FIXME: Print information about each individual method: both ;; its docstring and specializers (bug#21422). - ('cl-defmethod (push (cadr x) provides)) + ;; ('cl-defmethod (push (cadr x) provides)) ;; FIXME: Add extension point (bug#72616). (_ (let ((sym (or (cdr-safe x) x))) (and sym (symbolp sym) ...does not work just as well? From what I see now, any 'cl-defmethod' entry in load-history is accompanied by a 'defun' entry anyway. And the original report (https://debbugs.gnu.org/21422) was about an error being raised, but I can't reproduce it now after commenting this line out.