From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: me--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash Date: Sat, 11 Feb 2023 07:43:10 +0000 Message-ID: Reply-To: me@elken.dev Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_ac31fe584b544a0693faae1201319cf0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19853"; mail-complaints-to="usenet@ciao.gmane.io" To: 61411@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 11 08:44:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQkYh-0004yV-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Feb 2023 08:44:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQkYP-00042i-JZ; Sat, 11 Feb 2023 02:44:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQkYF-00042J-EF for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:44:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQkYF-0001gZ-2G for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:44:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pQkYE-0008Rw-JB for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Feb 2023 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167610140332418 (code B ref -1); Sat, 11 Feb 2023 07:44:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Feb 2023 07:43:23 +0000 Original-Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXb-0008Qo-2s for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:36916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXV-0008Qd-EA for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQkXV-0003qr-5x for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:17 -0500 Original-Received: from mail.elken.dev ([165.22.120.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQkXT-0001Vh-1W for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:16 -0500 Original-Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 1EA00452EC for ; Sat, 11 Feb 2023 08:43:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1676101391; bh=LWJC23A5g66LOcXb6Qjd+lrxaqHBTs4HUr2/8CNxAgY=; h=Date:From:To:Subject:From; b=J7OCSg5wf2EQ2JWN+pwY08fyWySE8vl5D9ZfNeyTUugDgjgjn4vo+jTa7g8uy98Es nlv02cUuChKD0XhAVEcvXYvs6eOJHSr/JVQxGU0u1ZWQ+onoJ3BDnOT0LPhC8FBipP BY+N2itE0ctoQDzuFSmkard7RKzKlpJ8z6Maej+/fJiJfAOi0Tz04MYCfgdOmxMU2B BD2ctnoiCdXTqx4xEDWBsBLVlAP7K1Sv9GAakB+DNMVfpK8Qu4XA7K4LqpVfBFLbVK LCKqmlKfFmLTZ08tlYJKs52GAC5C0REjFYoX4BKA3AmzWA3mCuSAGN+MTqeRLMrXcS 6HbwnPkL8ezuA== X-Sender: me@elken.dev Received-SPF: pass client-ip=165.22.120.78; envelope-from=me@elken.dev; helo=mail.elken.dev X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255316 Archived-At: --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi all, This seems like a simple patch, in cases where 'url-request-noninteractive' is set and valid credentials either aren't found or the server sends 401 regardless (which is how I found this bug), this causes Emacs to crash. I have copyright assignment assigned, even though this would fall under a "trivial change". Thanks, Ellis --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-potential-crash-with-url-basic-auth.patch Content-Disposition: attachment; filename=0001-Fix-potential-crash-with-url-basic-auth.patch; size=943 RnJvbSBjMzVlZGRmOGJjOTM4Y2NmYTBkOWE1NWZjNmYxNDI1OTViYzJkZTE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBTYXQs IDExIEZlYiAyMDIzIDA3OjI3OjU2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHBvdGVudGlh bCBjcmFzaCB3aXRoIHVybC1iYXNpYy1hdXRoCgoqIGxpc3AvdXJsL3VybC1hdXRoLmVsICh1cmwt YmFzaWMtYXV0aCk6CkhhbmRsZSBhIGNhc2Ugd2hlcmUgRW1hY3Mgd291bGQgY3Jhc2ggd2hlcmUg bm8gdmFsaWQgY3JlZGVudGlhbHMgYXJlIGZvdW5kCmFuZCAndXJsLXJlcXVlc3Qtbm9uaW50ZXJh Y3RpdmUnIGlzIHQKLS0tCiBsaXNwL3VybC91cmwtYXV0aC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdXJs L3VybC1hdXRoLmVsIGIvbGlzcC91cmwvdXJsLWF1dGguZWwKaW5kZXggZTllZTcyMDI5Zi4uODNi NGZhNjQ2OCAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWF1dGguZWwKKysrIGIvbGlzcC91cmwv dXJsLWF1dGguZWwKQEAgLTEwMCw3ICsxMDAsNyBAQCBpbnN0ZWFkIG9mIHRoZSBmaWxlbmFtZSBp bmhlcml0YW5jZSBtZXRob2QuIgogCQkJICAgICAoc2V0cSByZXR2YWwKIAkJCQkgICAoYmFzZTY0 LWVuY29kZS1zdHJpbmcKIAkJCQkgICAgKGZvcm1hdCAiJXM6JXMiIHVzZXIKLQkJCQkJICAgIChl bmNvZGUtY29kaW5nLXN0cmluZyBwYXNzICd1dGYtOCkpCisJCQkJCSAgICAoZW5jb2RlLWNvZGlu Zy1zdHJpbmcgKG9yIHBhc3MgIiIpICd1dGYtOCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB0KSkpKQogCQkgKHN5bWJvbC12YWx1ZSB1cmwtYmFzaWMtYXV0aC1zdG9yYWdl KSkpKQogICAgICAoYnlzZXJ2Ci0tIAoyLjM5LjAKCg== --=_ac31fe584b544a0693faae1201319cf0--