unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Herman@debbugs.gnu.org, Géza <geza.herman@gmail.com>
To: "João Távora" <joaotavora@gmail.com>,
	"Theodor Thornhill" <theo@thornhill.no>
Cc: Yuan Fu <casouri@gmail.com>, 62412@debbugs.gnu.org
Subject: bug#62412: 29.0.60; strange c++ indentation behavior with tree sitter
Date: Sat, 25 Mar 2023 11:26:04 +0100	[thread overview]
Message-ID: <c83ed667-06a1-80f2-cd48-8e600f9367a5@gmail.com> (raw)
In-Reply-To: <CALDnm51687wKKMmcFg5yKMoaAsKb2QM5t03hm5pLJGYMUGde4g@mail.gmail.com>

That's the difference. c++-ts-mode appends "{}():;,#" to 
electric-indent-chars, while c++-mode doesn't do this.

Nevertheless, I think that the calculated intendation should be a 
correct number. Even if the user turns off electric-indent-mode, but 
dedices to call re-indenting manually for a half-written for loop, emacs 
should re-intent the line properly. At least, this specific example 
works OK with c++-mode.

(note that I understand that this problem is not trivial, tree 
sitter/emacs may get confused if the buffer cannot be properly parsed)

On 3/25/23 09:53, João Távora wrote:
> On Fri, Mar 24, 2023 at 10:02 PM Theodor Thornhill via Bug reports for
> GNU Emacs, the Swiss army knife of text editors
> <bug-gnu-emacs@gnu.org> wrote:
> e about the original purpose for this rule, CC’ing Theo.
>>> Yuan
>> I'll look more deeply into the cause of this, but the rule is covering some preproc directives iirc.
>>
>> Unfortunately tree-sitter behaves better when auto pairs is used. I would advise people to use electric-pairs-mode (if that's the correct name, on mobile now) to avoid these sorts of issues.
> electric-pair-mode, it's not on by default.
>
> But, for some reason, electric-indent-mode _is_ on by default,
> at least in c++-ts-mode.
>
> So this has nothing to do with tree-sitter IMO, it's just
> electric-pair-mode doing its thing.
>
> Why is it on by default?  A fair number of users don't like
> this electricity, or prefer to have it toned down.  At least
> this has been the  argument for not turning on electric-pair-mode
> by default, which is a much less jarring mode IMO, and one which
> would solve these problems.
>
> João






  parent reply	other threads:[~2023-03-25 10:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 20:43 bug#62412: 29.0.60; strange c++ indentation behavior with tree sitter Herman, Geza
2023-03-24 18:17 ` Yuan Fu
2023-03-24 20:04   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-25  8:53     ` João Távora
2023-03-25 10:19       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-25 10:28         ` João Távora
2023-03-25 10:26       ` Herman, Géza [this message]
2023-03-25 11:43         ` João Távora
2023-03-25 13:48           ` Herman, Géza
2023-03-25 16:23             ` João Távora
2023-03-25 17:41               ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12  0:03                 ` Stefan Kangas
2023-03-25 17:47               ` Herman, Géza
2023-03-25 17:53                 ` João Távora
2023-03-26 13:54           ` Herman, Géza
2023-03-26 13:25     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c83ed667-06a1-80f2-cd48-8e600f9367a5@gmail.com \
    --to=herman@debbugs.gnu.org \
    --cc=62412@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=geza.herman@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).