From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Date: Wed, 9 Aug 2023 09:19:37 -0300 Message-ID: References: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------rlOK46iE20fBBRee8w0WzYVR" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9058"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Thomas Fitzsimmons , 63290@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 09 14:20:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTiAq-00028O-MC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Aug 2023 14:20:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTiAW-0005rT-UI; Wed, 09 Aug 2023 08:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTiAV-0005r2-9U for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 08:20:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTiAU-0006fW-Dy for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 08:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTiAT-00032V-NM for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 08:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Aug 2023 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63290 X-GNU-PR-Package: emacs Original-Received: via spool by 63290-submit@debbugs.gnu.org id=B63290.169158358911653 (code B ref 63290); Wed, 09 Aug 2023 12:20:01 +0000 Original-Received: (at 63290) by debbugs.gnu.org; 9 Aug 2023 12:19:49 +0000 Original-Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTiAG-00031s-JB for submit@debbugs.gnu.org; Wed, 09 Aug 2023 08:19:48 -0400 Original-Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:61647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTiAF-00031a-6Y; Wed, 09 Aug 2023 08:19:47 -0400 Original-Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bd0425ad4fso1562991a34.2; Wed, 09 Aug 2023 05:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691583581; x=1692188381; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XFytycnOYEKtNscKOLnKsrcwWiHs8SkjHUxz6ZHx12I=; b=Z2xhmShz/ahyl78vc/JDgRg6btZy7NSKWgZG+/KYOTaBovyX6ljzUQVyl/9EHwBc7F j6ZZ5NwVe6n+u9PPEJWBf3joA7oy97/SLjR6UQJ6u32IUFMR1395un62WcECHgYbB0Ew S6D44lYUtiI08Iv8VIWwKlbbyDeIyOHCJb0SIglhrnKU1iN1FlyAUGZHJZvgkr7afkdC ZFOnLEUbxZfun1EvdaHN/j+EjOh66FeByfd+JmsfvlsQ/IplNbNB4fb1p4opjgHvVZd/ tKdrc9vgOG8vOmF0EXn6pug00/VmN3ETMkMqZK2A2R7jXr1+6C/53FJ3XcRgILgrIyid ZD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691583581; x=1692188381; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XFytycnOYEKtNscKOLnKsrcwWiHs8SkjHUxz6ZHx12I=; b=BsF/lxXJEhWvA3Np+kwEZIZ57wyF2JzmL9SjE3vedG4rcXIocK5dIQdEqb00+Jhy16 IGoYrzMwyCv/SxbKINuT26dJ0SxPMFhDL9uUcBfOhxwNgcp8Ay4tffbpYL/pkqdTnqbV 0JojaccIHjCF75fUYoCHonpJqQN7cn9vso1ncQTV0lDJD0D6Ys0uCacssBcjKpaCBHlW aeX3P5IsilXuTxAAvIRH5CjOYcLHHPxEU2JS0Zo2VDKDmSticKr2Lz5SDs+GmHRCt7// dNuE+vaxacY6kiSHPDnK1eVRqmhZ4Mqw+hOlEAFtluKQhEhmM0zNSnjvhgK3+N/fSlE0 L1VQ== X-Gm-Message-State: AOJu0YxEfBhNhcB5HxjtFR07XEonv/aKMP2Xg6Yl9l+ChGOwkv9nhf/a CT9tGmAfORoB7xo6huTGeVyCEOAyxjQ= X-Google-Smtp-Source: AGHT+IGNO92CBW1NMppiD+cpSPa7E6mTj50v2KBy5ns2qmm2LKj1l1jcyloE9VhVnLfFY2IegJ/R7w== X-Received: by 2002:a05:6830:1e1b:b0:6bc:f5fc:ebb9 with SMTP id s27-20020a0568301e1b00b006bcf5fcebb9mr2758993otr.27.1691583581196; Wed, 09 Aug 2023 05:19:41 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id x24-20020a05683000d800b006b8bf76174fsm6862683oto.21.2023.08.09.05.19.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 05:19:40 -0700 (PDT) Content-Language: en-US In-Reply-To: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267023 Archived-At: This is a multi-part message in MIME format. --------------rlOK46iE20fBBRee8w0WzYVR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit tags 63290 patch quit I ended up adding a custom :default-get function for the list widget, to make it respect a nil value as the :value.  This should be backward compatible with other widgets, and should fix these "ghost" elements insertions. I also added a test for cus-edit-tests. --------------rlOK46iE20fBBRee8w0WzYVR Content-Type: text/x-patch; charset=UTF-8; name="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.patch" Content-Disposition: attachment; filename*0="0001-Respect-the-value-property-in-a-list-widget-Bug-6329.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlNjRmOWM1NWUxYTFlNTdkZTM3ODNmYmJhYzFiZjIzOWFjMzBiYWJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFdlZCwgOSBBdWcgMjAyMyAwOToxNzo0MyAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIFJlc3BlY3QgdGhlIDp2YWx1ZSBwcm9wZXJ0eSBpbiBhIGxpc3Qgd2lkZ2V0IChC dWcjNjMyOTApCgoqIGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1saXN0LWRlZmF1bHQtZ2V0 KTogTmV3IGZ1bmN0aW9uLgoqIHRlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbCAoY3VzLWVk aXQtdGVzdC1idWctNjMyOTAtb3B0aW9uKTogTmV3CnRlc3Qgb3B0aW9uLgooY3VzLWVkaXQt dGVzdC1idWc2MzI5MCk6IE5ldyB0ZXN0LgotLS0KIGxpc3Avd2lkLWVkaXQuZWwgICAgICAg ICAgICB8IDExICsrKysrKysrKysrCiB0ZXN0L2xpc3AvY3VzLWVkaXQtdGVzdHMuZWwgfCAy NCArKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3Avd2lkLWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0 LmVsCmluZGV4IDQ3NTMxMTEzYmE4Li5jNjA0MjI1ZjEwYSAxMDA2NDQKLS0tIGEvbGlzcC93 aWQtZWRpdC5lbAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0zODEyLDggKzM4MTIsMTkg QEAgd2lkZ2V0LWNoYXJhY3Rlci1ub3RpZnkKIChkZWZpbmUtd2lkZ2V0ICdsaXN0ICdncm91 cAogICAiQSBMaXNwIGxpc3QuIgogICA6dGFnICJMaXN0IgorICA6ZGVmYXVsdC1nZXQgIyd3 aWRnZXQtbGlzdC1kZWZhdWx0LWdldAogICA6Zm9ybWF0ICIleyV0JX06XG4ldiIpCiAKKyhk ZWZ1biB3aWRnZXQtbGlzdC1kZWZhdWx0LWdldCAod2lkZ2V0KQorICAiUmV0dXJuIHRoZSBk ZWZhdWx0IGV4dGVybmFsIHZhbHVlIGZvciBhIGxpc3QgV0lER0VULgorCitUaGUgZGVmYXVs dCB2YWx1ZSBpcyB0aGUgb25lIHN0b3JlZCBpbiB0aGUgOnZhbHVlIHByb3BlcnR5LCBldmVu IGlmIGl0IGlzIG5pbCwKK29yIGEgbGlzdCB3aXRoIHRoZSBkZWZhdWx0IHZhbHVlIG9mIGVh Y2ggY29tcG9uZW50IG9mIHRoZSBsaXN0IFdJREdFVC4iCisgICh3aWRnZXQtYXBwbHkgd2lk Z2V0IDp2YWx1ZS10by1leHRlcm5hbAorICAgICAgICAgICAgICAgIChpZiAod2lkZ2V0LW1l bWJlciB3aWRnZXQgOnZhbHVlKQorICAgICAgICAgICAgICAgICAgICAod2lkZ2V0LWdldCB3 aWRnZXQgOnZhbHVlKQorICAgICAgICAgICAgICAgICAgKHdpZGdldC1ncm91cC1kZWZhdWx0 LWdldCB3aWRnZXQpKSkpCisKIChkZWZpbmUtd2lkZ2V0ICd2ZWN0b3IgJ2dyb3VwCiAgICJB IExpc3AgdmVjdG9yLiIKICAgOnRhZyAiVmVjdG9yIgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNw L2N1cy1lZGl0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2N1cy1lZGl0LXRlc3RzLmVsCmluZGV4 IGVjYTM1ZDdjOTZhLi43NWQ1ZjMyYzQyMSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2N1cy1l ZGl0LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9jdXMtZWRpdC10ZXN0cy5lbApAQCAtOTIs NSArOTIsMjkgQEAgdGVzdC1zZXRvcHQKICAgICAgICAgICAgIChidWZmZXItc3Vic3RyaW5n LW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkpCiAgICAgKHNob3Vs ZCAoc3RyaW5nLXNlYXJjaCAiVmFsdWUgYDpmb28nIGRvZXMgbm90IG1hdGNoIHR5cGUgbnVt YmVyIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgd2Fybi10eHQpKSkpCisKKyhkZWZj dXN0b20gY3VzLWVkaXQtdGVzdC1idWc2MzI5MC1vcHRpb24gbmlsCisgICJDaG9pY2Ugb3B0 aW9uIGZvciB0ZXN0aW5nIEJ1ZyM2MzI5MC4iCisgIDp0eXBlICcoY2hvaWNlIChhbGlzdAor ICAgICAgICAgICAgICAgICAgOmtleS10eXBlIChzdHJpbmcgOnRhZyAia2V5IikKKyAgICAg ICAgICAgICAgICAgIDp2YWx1ZS10eXBlIChzdHJpbmcgOnRhZyAidmFsdWUiKSkKKyAgICAg ICAgICAgICAgICAgKGNvbnN0IDp0YWcgImF1dG8iIGF1dG8pKSkKKworKGVydC1kZWZ0ZXN0 IGN1cy1lZGl0LXRlc3QtYnVnNjMyOTAgKCkKKyAgIlRlc3QgdGhhdCBjaGFuZ2luZyBhIGNo b2ljZSB2YWx1ZSBiYWNrIHRvIGFuIGFsaXN0IHJlc3BlY3RzIGl0cyBuaWwgdmFsdWUuIgor ICAoY3VzdG9taXplLXZhcmlhYmxlICdjdXMtZWRpdC10ZXN0LWJ1ZzYzMjkwLW9wdGlvbikK KyAgKHNlYXJjaC1mb3J3YXJkICJWYWx1ZSIpCisgIDs7IFNpbXVsYXRlIGNoYW5naW5nIHRo ZSB2YWx1ZS4KKyAgKGxldCogKChjaG9pY2UgKHdpZGdldC1hdCkpCisgICAgICAgICAoYXJn cyAod2lkZ2V0LWdldCBjaG9pY2UgOmFyZ3MpKQorICAgICAgICAgKGxpc3Qtb3B0IChjYXIg KHdpZGdldC1nZXQgY2hvaWNlIDpjaGlsZHJlbikpKQorICAgICAgICAgKGNvbnN0LW9wdCAo bnRoIDEgYXJncykpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQtY2hvaWNl IGNvbnN0LW9wdCkKKyAgICAod2lkZ2V0LXZhbHVlLXNldCBjaG9pY2UgKHdpZGdldC1kZWZh dWx0LWdldCBjb25zdC1vcHQpKQorICAgICh3aWRnZXQtcHV0IGNob2ljZSA6ZXhwbGljaXQt Y2hvaWNlIGxpc3Qtb3B0KQorICAgICh3aWRnZXQtdmFsdWUtc2V0IGNob2ljZSAod2lkZ2V0 LWRlZmF1bHQtZ2V0IGxpc3Qtb3B0KSkpCisgIDs7IE5vIGVtcHR5IGtleS92YWx1ZSBwYWly cyBzaG91bGQgc2hvdyB1cC4KKyAgKHNob3VsZC1ub3QgKHNlYXJjaC1mb3J3YXJkICJrZXki IG5pbCB0KSkpCisKIChwcm92aWRlICdjdXMtZWRpdC10ZXN0cykKIDs7OyBjdXMtZWRpdC10 ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMzQuMQoK --------------rlOK46iE20fBBRee8w0WzYVR--