From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Tue, 31 Jan 2023 17:58:44 +0200 Message-ID: References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <012b781c-d4dd-0ec5-4c15-a997879690e9@yandex.ru> <83v8kn3kya.fsf@gnu.org> <880256a0-4d91-76d7-1237-4866a3652803@yandex.ru> <83mt5y3nqi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24020"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 16:59:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMt2U-00060M-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 16:59:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMt2H-0002Is-A5; Tue, 31 Jan 2023 10:59:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMt2E-0002IN-M9 for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 10:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMt2D-0000WS-OQ for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 10:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMt2D-0003ax-IR for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 10:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 15:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167518073813809 (code B ref 56682); Tue, 31 Jan 2023 15:59:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 31 Jan 2023 15:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:54790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMt2A-0003af-0S for submit@debbugs.gnu.org; Tue, 31 Jan 2023 10:58:58 -0500 Original-Received: from mail-ej1-f41.google.com ([209.85.218.41]:40958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMt26-0003aQ-2x for 56682@debbugs.gnu.org; Tue, 31 Jan 2023 10:58:57 -0500 Original-Received: by mail-ej1-f41.google.com with SMTP id me3so42952692ejb.7 for <56682@debbugs.gnu.org>; Tue, 31 Jan 2023 07:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=XzClaSqdjBh7Yos65Cis7QDJS5Sv7v9knDr9Q29A5BM=; b=M2OKOwMTZf42pnvYTE6zNk0bqGuAnBHINbMBIw3lWsBfUyUYNNK3JtlP3qONP5D51E bVudoZueU4XDECuoKc/l6rOJfW7B1d6NsM70pk15MErNVRdYaDxwHj4vJaeMVTT0/lA8 iaZ62hkpQYqn2L9SyiBjQQXJnRjNnQV8ib1l8EaDVfcNXr/Jo6D0xqvvPykkoG3RIgwQ JJx+Z7vxjExhaHPk/Kq8Pk1L8jpbY0rZbzgJ5On28sZDrKd5/mODdo/5TptCl5YmXFpP /pG2A6mub/SR8EiNEHOXopw0bIXq41DEUyYU7sk2/2p/+aTv54HGP10+TuRAAoO1uk3U nFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XzClaSqdjBh7Yos65Cis7QDJS5Sv7v9knDr9Q29A5BM=; b=PNlAe8wpatrWP1lRiqhOflbebU4UUZSza8BFwOxdydPMtcwX3+KpPnWO1I7qFf6fEI vFbdqhsQMwK3/kN05gLLYvgcdfJj0ggO2kMbHgm1YNO3SD8r9MdkL/6IVP2tvAy4UIlj lSHPUcFJoKVSUV2OOPJ5aU+1+mT1dhAWDBw6poyDBewiokeQjRL5vflc3JFq7A7Ja555 IADtto+LoJ4duM0bGt30orIVDHmye9HhZiCXd42K4F8l0w3JX73Fxw8h9oI8SbcTFhFh lHQatDorBjJiLbRDYbAGDohrryRNFMvMYk4OeVeaVLV7M79cTf1+uOBe2WrYhKAQh7IW dO/g== X-Gm-Message-State: AO0yUKW/A9ode+Zs5KXAu7ZAct/PrPLckKuwGMBdevAzCK1pm6BFGQdm dpvZvmMOfaN6/HKnTuapC+c= X-Google-Smtp-Source: AK7set+b/RjlCkrD3dRRlWGSkxtYbWrJuSrLoVxhl1u2FEQRD4WQ+ReVoeB9D7nyjFmBbgDMr4r7Pw== X-Received: by 2002:a17:907:6d8a:b0:87b:da70:974 with SMTP id sb10-20020a1709076d8a00b0087bda700974mr4494860ejc.58.1675180727939; Tue, 31 Jan 2023 07:58:47 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id kv11-20020a17090778cb00b0088a2397cb2csm2557058ejc.143.2023.01.31.07.58.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 07:58:46 -0800 (PST) Content-Language: en-US In-Reply-To: <83mt5y3nqi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254532 Archived-At: On 31/01/2023 14:14, Eli Zaretskii wrote: >> Date: Mon, 30 Jan 2023 23:07:22 +0200 >> Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >> With the previous change that Gregory had made (different limits for >> different features, i.e. font-lock uses much wider narrowing bounds >> which are also customizable) I don't have that much of a horse in that >> race anymore. > > Which change is that? I don't think I follow. The addition of long-line-locked-narrowing-region-size, I think, separated the narrowing radius for font-lock from narrowing for the improvement of other display stuff. I could be wrong there, though. >> Also note that previously, I'd never have suggested that redisplay code >> changes the value of font-lock-dont-widen. > > Hmm... not sure how is that variable related to this particular > thread. Please elaborate. If we drop the locking feature, the display engine could still apply narrowing around fontification functions (and hooks, and etc). And perhaps bind font-lock-down-widen to t. Or add a new variable, like Stefan suggested -- that would be tidier. That would still not protect us from misbehaving modes, but modes that absolutely cannot work within a narrowing are a problem anyway. And for the rest, we have an existing convention (discussed at length and rubber-stamped by the previous maintainer back then) that major modes shouldn't call 'widen' in font-lock-keywords. Nor in indentation code. That was part of the convention which made js-mode, python-mode, etc, work better with multil-major-mode packages, and it did.