From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table Date: Wed, 30 Dec 2020 00:43:54 -0800 (PST) Message-ID: References: <1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default> <87y2hgosxo.fsf@gnus.org> <64015d41-a84f-4ff6-a5a1-ab5d92aa20e5@default> <87k0szpyaj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20505"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45539@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 09:47:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuX8T-0005Br-Eu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 09:47:13 +0100 Original-Received: from localhost ([::1]:49616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuX8S-0003Hg-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 03:47:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuX8I-0003HW-Ml for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 03:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuX8I-0005yj-F0 for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 03:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuX8I-0006tb-Az for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 03:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 45539-submit@debbugs.gnu.org id=B45539.160931796723581 (code B ref 45539); Wed, 30 Dec 2020 08:47:02 +0000 Original-Received: (at 45539) by debbugs.gnu.org; 30 Dec 2020 08:46:07 +0000 Original-Received: from localhost ([127.0.0.1]:40853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuX7O-000682-TJ for submit@debbugs.gnu.org; Wed, 30 Dec 2020 03:46:07 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:57424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuX7K-0005yY-2C for 45539@debbugs.gnu.org; Wed, 30 Dec 2020 03:46:05 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BU8cPlQ008693; Wed, 30 Dec 2020 08:45:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=iPxc7N6T/TDPsfuJF/8QuEgfBHjmI96EGuQZOyxblCk=; b=IgKbqvyQ4dBsZbcNJ1lyBFzBFmcl7yuRUKzkVTYxRY1li4edLiLGXOgPPzTkzwEP/5bN Auh2DtlCMhi97S1aZvq3MeT0Y5ZWAEH5tr8Fg3SG8Z6cAnmM7s3Lzy+i3gF1d/dNwD44 xQIY5euz9l0ljrFQWaVZzkeNeCVz2KhajkxsFtSdz/xot6Dy15h+JJrAGYeBZVe88r8A 8V0dz+37VzrvsJLo853+BmQJEq2i+Iz+v2cZ/sgMRyApm3tpaCosUF5QGI0CusNbCGZA Oyqc1q5fKcWiL96u6whi6R1Ia/BjEznbCJXZclprqkpvwGQOxvDx97o7hzkArPIE3AS0 BA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 35rk3brdhp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Dec 2020 08:45:56 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BU8ePs2185015; Wed, 30 Dec 2020 08:43:55 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 35pf2xujwv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Dec 2020 08:43:55 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BU8htZP017849; Wed, 30 Dec 2020 08:43:55 GMT In-Reply-To: <87k0szpyaj.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9849 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012300052 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9849 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012300052 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197011 Archived-At: > > I don't understand. One of us is confused, I think. >=20 > Yeah, that was me. I totally misread what the function is doing. I'll > revert the patch and add the predicate function like you suggested. Thanks. I know the feeling. And when I looked at it again, after your mail, I began to wonder... And double thanks for adding the optional TEST-PRED arg.